From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mary Strodl <mstrodl@csh.rit.edu>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>
Subject: Re: [PATCH v1 1/2] gpio: mpsse: Check for error code from devm_mutex_init() call
Date: Wed, 30 Oct 2024 19:33:17 +0200 [thread overview]
Message-ID: <ZyJt3U-YTpQYwLrq@smile.fi.intel.com> (raw)
In-Reply-To: <ZyJo4dvULIflwhXL@freedom.csh.rit.edu>
On Wed, Oct 30, 2024 at 01:12:01PM -0400, Mary Strodl wrote:
> On Wed, Oct 30, 2024 at 05:30:26PM +0200, Andy Shevchenko wrote:
...
> > + err = devm_mutex_init(dev, &priv->io_mutex);
> > + if (err)
> > + return err;
> > +
> > + ret = devm_mutex_init(dev, &priv->irq_mutex);
>
> I think this should be `err = `
Oh, I haven't compiled that for sure :-)
> Other than that, it looks good to me (I doubt you need this, but just in case):
>
> Reviewed-by: Mary Strodl <mstrodl@csh.rit.edu>
Thanks, I will fix that, I dunno how I missed that because I carefully read
the code before adding the checks.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-10-30 17:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 15:30 [PATCH v1 0/2] gpio: Check for error from devm_mutex_init() Andy Shevchenko
2024-10-30 15:30 ` [PATCH v1 1/2] gpio: mpsse: Check for error code from devm_mutex_init() call Andy Shevchenko
2024-10-30 17:12 ` Mary Strodl
2024-10-30 17:33 ` Andy Shevchenko [this message]
2024-10-30 17:38 ` Mary Strodl
2024-10-30 15:30 ` [PATCH v1 2/2] gpio: sloppy-logic-analyzer: " Andy Shevchenko
2024-10-30 16:59 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyJt3U-YTpQYwLrq@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mstrodl@csh.rit.edu \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®