From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E1777483; Thu, 31 Oct 2024 14:05:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730383555; cv=none; b=XlLOKYOvJcz6u68zbJRv59f0Hw2TOJbsGIO+WFVjvukpvEYOJBjHPVWWDwGZ0U1dWaRy0goFDEsn7Zk0Dk6Jju0K/IxaXD+ANrupwntjWwJw8CYnHgBu/Hkav3eUXmg8Qp4p2pKkSJ02zpcjn9gkk5LGbPkr7YHWauvzCpr3/84= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730383555; c=relaxed/simple; bh=tqhdXipXaApdyzH7wbucKGPUec8wdzKCSf8PtkJTxso=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=c+Yu/v1ZE2nnzFB2f9H1kTX0EK8EjAB0nCz9Vkqby/sd8/tzJwLenwK7XaGZOFCr0KgLMB1vdh/AWrV3kaKUjxwn6XCBxpYpDmMzJrECWPVuCGfR2rjDpB3Y8nVdKQ+tQGLPdoPvfEzxNjNzE5SBtwhOatK/94YrthQbDbce2wg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BTD3lW8f; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BTD3lW8f" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 129CBC4FF0D; Thu, 31 Oct 2024 14:05:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730383555; bh=tqhdXipXaApdyzH7wbucKGPUec8wdzKCSf8PtkJTxso=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BTD3lW8fWB74a1NtwyhYLGCCzQo3c0W2TfXSAtMh9Bnh4z9Oj1I8vdc28lu9B6MRS MQR7yy1N7WVEz+rmypsGxHSSDIlevHnq7EeTDlzHTvovlPGAK8l3dEVkgIuz5HJGgp 46835ueeXuOZlqP2uEDIDGtrdUqplEEvmrQl3lng5yEZsTXGiDwFBQ8IMaxOrO/DfJ seH4cP++XQK4QU83l7G+uPD+J10Lecd3P6+BslCMw1+4sSXhHzn1FphODY4lEe90Xb edVruSFjliiI877b5B6BvS0mL84DHhLfJ1tsrgAxJAjppK4smpL6K9WMKuV+8voGO2 ircghHwu0/29g== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1t6Vo8-000000004NO-3f8I; Thu, 31 Oct 2024 15:05:52 +0100 Date: Thu, 31 Oct 2024 15:05:52 +0100 From: Johan Hovold To: Abel Vesa Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dmitry Baryshkov , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] drm/bridge: Fix assignment of the of_node of the parent to aux bridge Message-ID: References: <20241018-drm-aux-bridge-mark-of-node-reused-v2-1-aeed1b445c7d@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Oct 21, 2024 at 09:23:24AM +0200, Johan Hovold wrote: > On Fri, Oct 18, 2024 at 03:49:34PM +0300, Abel Vesa wrote: > > The assignment of the of_node to the aux bridge needs to mark the > > of_node as reused as well, otherwise resource providers like pinctrl will > > report a gpio as already requested by a different device when both pinconf > > and gpios property are present. > > I don't think you need a gpio property for that to happen, right? And > this causes probe to fail IIRC? > > > Fix that by using the device_set_of_node_from_dev() helper instead. > > > > Fixes: 6914968a0b52 ("drm/bridge: properly refcount DT nodes in aux bridge drivers") > > This is not the commit that introduced the issue. > > > Cc: stable@vger.kernel.org # 6.8 > > I assume there are no existing devicetrees that need this since then we > would have heard about it sooner. Do we still need to backport it? > > When exactly are you hitting this? Abel, even if Neil decided to give me the finger here, please answer the above so that it's recorded in the archives at least. Johan