From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AA541BBBD8; Thu, 31 Oct 2024 16:26:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730392002; cv=none; b=Fzv7m0qT2pY5qQqiykKoloRN6tZJ2/Vl96xn36638/r4or5RFyaEWoCHvzepgYAkQdA08jDNF+f9ZO+aJhe/eNIIO58u1oOx0OUtd5vCHEyF7gRzi8caIkKeNtCpKiXEvpE8+44QLoFKty/NI/vCTg6WkfkS4vZgySJt7pYg7M8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730392002; c=relaxed/simple; bh=MeYpjmAvsTooc9kfh8p42uuv2Bag5WtM3PIxxAl8Flw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FDv1rCh7rJKxk4iQcE7xisMBrHnrlUJj+HgRKb6PnWWfBNHRZW+H2xFIluw+7+t1K5mlF1jLP1KfpfP/cfj1fsDeugJ4bFE48UXMLYPqGcLkHl3dQFmGo1BqiYIdPvNMQQpyjqBQdIhyb9i5DfH0/++vtXk1cMgINS/BAsz0ugo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XPI0Jaw3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XPI0Jaw3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EDF22C58106; Thu, 31 Oct 2024 16:26:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730392002; bh=MeYpjmAvsTooc9kfh8p42uuv2Bag5WtM3PIxxAl8Flw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XPI0Jaw3PrGIL3Gqfkq8ZESXsc99FWmta6Mxd4nyD7C/q2ojqtwLAp3wLbZNUGmyL abdRCI126UQDv1zLIxFZ0fQoQYu+w7BLlKfEhNE5xFad4s51JMA3Liw809RSjX+d1F +MjeQemmA4fRQW3uQ3Xlo8gD+NWbm38goXztCTxhc/abc1jpfLlQ3zsTSLZMzGdu1f p+6x1+7a+oeAnjJR8W8w4Ly8Ir1T6MwSfRDRIDY/tH/eptMu90NZA28xm0QJg6lcdP cV5i4dhfO7c6KHZn2mA1atIY720O710on2fzNDV2YiAU+nRYODNJ8XD/S2IvJDzKkL B/+oPXlVP0LPg== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1t6Y0N-000000007Ab-3Yq2; Thu, 31 Oct 2024 17:26:39 +0100 Date: Thu, 31 Oct 2024 17:26:39 +0100 From: Johan Hovold To: Dmitry Baryshkov Cc: Abel Vesa , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] drm/bridge: Fix assignment of the of_node of the parent to aux bridge Message-ID: References: <20241018-drm-aux-bridge-mark-of-node-reused-v2-1-aeed1b445c7d@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Oct 31, 2024 at 05:48:24PM +0200, Dmitry Baryshkov wrote: > On Mon, 21 Oct 2024 at 10:23, Johan Hovold wrote: > > > > On Fri, Oct 18, 2024 at 03:49:34PM +0300, Abel Vesa wrote: > > > The assignment of the of_node to the aux bridge needs to mark the > > > of_node as reused as well, otherwise resource providers like pinctrl will > > > report a gpio as already requested by a different device when both pinconf > > > and gpios property are present. > > > > I don't think you need a gpio property for that to happen, right? And > > this causes probe to fail IIRC? > > No, just having a pinctrl property in the bridge device is enough. > Without this fix when the aux subdevice is being bound to the driver, > the pinctrl_bind_pins() will attempt to bind pins, which are already > in use by the actual bridge device. Right, and IIRC it then fails to probe as well. This is information that should have been in the commit message. Johan