From: Herbert Xu <herbert@gondor.apana.org.au>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Eric Biggers <ebiggers@kernel.org>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev,
sparclinux@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH v2 04/18] crypto: crc32 - don't unnecessarily register arch algorithms
Date: Sat, 2 Nov 2024 19:08:43 +0800 [thread overview]
Message-ID: <ZyYIO6RpjTFteaxH@gondor.apana.org.au> (raw)
In-Reply-To: <CAMj1kXG8Nqw_f8OsFTq_UKRbca6w58g4uyRAZXCoCr=OwC2sWA@mail.gmail.com>
On Sat, Nov 02, 2024 at 12:05:01PM +0100, Ard Biesheuvel wrote:
>
> The only issue resulting from *not* taking this patch is that btrfs
> may misidentify the CRC32 implementation as being 'slow' and take an
> alternative code path, which does not necessarily result in worse
> performance.
If we were removing crc32* (or at least crc32*-arch) from the Crypto
API then these patches would be redundant. But if we're keeping them
because btrfs uses them then we should definitely make crc32*-arch
do the right thing. IOW they should not be registered if they're
the same as crc32*-generic.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2024-11-02 11:09 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 19:14 [PATCH v2 00/18] Wire up CRC32 library functions to arch-optimized code Eric Biggers
2024-10-25 19:14 ` [PATCH v2 01/18] lib/crc32: drop leading underscores from __crc32c_le_base Eric Biggers
2024-10-25 19:14 ` [PATCH v2 02/18] lib/crc32: improve support for arch-specific overrides Eric Biggers
2024-10-25 19:14 ` [PATCH v2 03/18] lib/crc32: expose whether the lib is really optimized at runtime Eric Biggers
2024-10-25 20:32 ` Ard Biesheuvel
2024-10-25 21:32 ` Eric Biggers
2024-10-25 21:37 ` Ard Biesheuvel
2024-10-25 22:31 ` Eric Biggers
2024-10-25 19:14 ` [PATCH v2 04/18] crypto: crc32 - don't unnecessarily register arch algorithms Eric Biggers
2024-10-25 20:47 ` Ard Biesheuvel
2024-10-25 22:02 ` Eric Biggers
2024-10-26 4:09 ` Eric Biggers
2024-10-27 8:14 ` Ard Biesheuvel
2024-11-02 9:45 ` Herbert Xu
2024-11-02 9:58 ` Ard Biesheuvel
2024-11-02 10:19 ` Herbert Xu
2024-11-02 10:46 ` Ard Biesheuvel
2024-11-02 11:05 ` Ard Biesheuvel
2024-11-02 11:08 ` Herbert Xu [this message]
2024-11-02 16:36 ` Eric Biggers
2024-11-02 16:46 ` Ard Biesheuvel
2024-11-02 17:21 ` Milan Broz
2024-10-25 19:14 ` [PATCH v2 05/18] arm/crc32: expose CRC32 functions through lib Eric Biggers
2024-10-25 19:14 ` [PATCH v2 06/18] loongarch/crc32: " Eric Biggers
2024-11-03 13:36 ` WangYuli
2024-11-03 13:57 ` Eric Biggers
2024-11-04 2:34 ` WangYuli
2024-10-25 19:14 ` [PATCH v2 07/18] mips/crc32: " Eric Biggers
2024-10-25 19:14 ` [PATCH v2 08/18] powerpc/crc32: " Eric Biggers
2024-10-25 19:14 ` [PATCH v2 09/18] s390/crc32: " Eric Biggers
2024-10-25 19:14 ` [PATCH v2 10/18] sparc/crc32: " Eric Biggers
2024-10-25 19:14 ` [PATCH v2 11/18] x86/crc32: update prototype for crc_pcl() Eric Biggers
2024-10-25 19:14 ` [PATCH v2 12/18] x86/crc32: update prototype for crc32_pclmul_le_16() Eric Biggers
2024-10-25 19:14 ` [PATCH v2 13/18] x86/crc32: expose CRC32 functions through lib Eric Biggers
2024-10-25 19:14 ` [PATCH v2 14/18] lib/crc32: make crc32c() go directly to lib Eric Biggers
2024-10-25 19:14 ` [PATCH v2 15/18] ext4: switch to using the crc32c library Eric Biggers
2024-11-02 22:26 ` Theodore Ts'o
2024-10-25 19:14 ` [PATCH v2 16/18] jbd2: " Eric Biggers
2024-10-25 19:14 ` [PATCH v2 17/18] f2fs: switch to using the crc32 library Eric Biggers
2024-10-25 19:14 ` [PATCH v2 18/18] scsi: target: iscsi: switch to using the crc32c library Eric Biggers
2024-10-25 22:14 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyYIO6RpjTFteaxH@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ardb@kernel.org \
--cc=ebiggers@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=sparclinux@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®