From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 828E918C015 for ; Mon, 4 Nov 2024 23:48:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730764118; cv=none; b=L7Hx1FkG1z4kF2SQOcwN1sjwP/i+Y+18q43n9coQDEE21+9ZLobx4zdHpOQZGTa4nWCBzFAsLJ5XGWqCXbFb4ANGzDHdaDF0TSizuZhy+OLVvot15xKTPMdU/CH4KEmIFpGFT4RIVqbLVw8hm6QniwHBiTg265DVSR76WRqlfXg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730764118; c=relaxed/simple; bh=fheCF/gyDLZgx3iDrdSIvn1qSVyQ83QryjFW9Al9qNg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uFKvPOyLkPj9twvuWob3gqpnMgM8360d2oYtWQYWd9AgPf8FcEvlPA6gRQmQ31b32AWV0X2f+2HPl+MQ9YV1MNbGvHiOoSZuMfBW0Z1PZnlK3Uo06053DH6jrhULZihZyEydtLSYuCr8xnL5JCj3ba06MW/ybEgiDqNwSLx+Cvo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=xMzzI+UG; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="xMzzI+UG" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-72061bfec2dso4501336b3a.2 for ; Mon, 04 Nov 2024 15:48:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1730764117; x=1731368917; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=LhLXEc7Psoc35/IvkhZF+2gK0RwcJpvg4PrUOsIjpfY=; b=xMzzI+UG4S2wDDhIKZ62R1Mu+Nvq8KGK0eG201Suggtz/P9eYV0TM/m2Qk5+zALbFi k5fbsE6Wvl+x37aHVQn9jgdcqq6Z3MpXCRH7vsWbMCmjwEpbTXHlCCm1BSwKnJBXjGM/ CSJrsk0LfDqPizONcz571ZnZw9RPsxVipSkjI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730764117; x=1731368917; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LhLXEc7Psoc35/IvkhZF+2gK0RwcJpvg4PrUOsIjpfY=; b=Jckw8P3fgYH9YzS/TP2KEUMZQS/yDowM1ISvs4+eLydD0kVywZ0q+dzHKzIqLu1zxA Ksl7cpiqEuMcHo5Ab8Fec8devQaEBMH/dVqUJZjdS2QK9fxhRbf09kP3Kf1saCRUflbX Z5IsqJYPhlWA2yFMDGY2HW4/ZZGWh+ETq9JfJB1eLwtWGdhDNcxPLQ2O5m4igxBXSsky JDDw25XDAnBViD0IlHMOybYpBJdGAbxe0lj8ypxgQT2nNumV/r0EC0zgNzSp2QMNFjTw mnA9iIHPXuW0JD6Z7MXsbARt6l+bcOy7xRil8Gg8SHIb8UFjpNCbyLWTqwOO6zsGtnfq WCOg== X-Forwarded-Encrypted: i=1; AJvYcCXn08IL0XCaQuHfFpERjvnOk33W8fGqJheQ3gC81585jBneMr8Top8KPo9u+Y3We6hyzIOLl9Xjf1M2lUs=@vger.kernel.org X-Gm-Message-State: AOJu0YzCKTiFQW8437OF73JxeD7M7CckHxkPGHrARnXaS3TJzaErhFo+ ru7RhfFRLj7+Ekrz4e/DSvEe3uhaul4n7XlAs1lGgvnNaPPPrLDemJpauR5HJ3U= X-Google-Smtp-Source: AGHT+IHam0CH1GsyhrKIPmW17xNBcLAbEJeoQbL8o1S+FhQThyRs09uEiRGHTxXe793CArFiCPT6fg== X-Received: by 2002:a05:6a00:88f:b0:71d:fb29:9f07 with SMTP id d2e1a72fcca58-720c990b37amr18395998b3a.15.1730764116811; Mon, 04 Nov 2024 15:48:36 -0800 (PST) Received: from LQ3V64L9R2 (c-24-6-151-244.hsd1.ca.comcast.net. [24.6.151.244]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-720bc1b8cb9sm8494097b3a.11.2024.11.04.15.48.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Nov 2024 15:48:36 -0800 (PST) Date: Mon, 4 Nov 2024 15:48:33 -0800 From: Joe Damato To: Stanislav Fomichev Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, andrew+netdev@lunn.ch, shuah@kernel.org, horms@kernel.org, almasrymina@google.com, willemb@google.com, petrm@nvidia.com Subject: Re: [PATCH net-next v7 04/12] selftests: ncdevmem: Make client_ip optional Message-ID: Mail-Followup-To: Joe Damato , Stanislav Fomichev , netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, andrew+netdev@lunn.ch, shuah@kernel.org, horms@kernel.org, almasrymina@google.com, willemb@google.com, petrm@nvidia.com References: <20241104181430.228682-1-sdf@fomichev.me> <20241104181430.228682-5-sdf@fomichev.me> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241104181430.228682-5-sdf@fomichev.me> On Mon, Nov 04, 2024 at 10:14:22AM -0800, Stanislav Fomichev wrote: > Support 3-tuple filtering by making client_ip optional. When -c is > not passed, don't specify src-ip/src-port in the filter. > > Reviewed-by: Mina Almasry > Signed-off-by: Stanislav Fomichev > --- > tools/testing/selftests/net/ncdevmem.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) Reviewed-by: Joe Damato