From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D8B2A32 for ; Tue, 5 Nov 2024 00:15:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730765716; cv=none; b=IAXFQHHY3479+0BDerpuDUqX4zvlMpfdIRoixixeIVIFV5j80va1gw8Ki1QAO9wYNEhi5Yye865AsJxcIDQvn6mzwDdDe1QxB28DAPtvucqtC/YwzbOoBCyScHMeBCS39kDgAhnezqqt7TUoQQo0XE9U/2kVYMMhMrogcWflkYM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730765716; c=relaxed/simple; bh=yvIGJzhFb84eC4ca0rZJpsDxkqFSOTyuaKPg1OZWAM8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LNOaZ17dH0QHsQ34u+t5XvYNfmMC6bC1wr+FELAy5b1ocxzQ0Rb21ETPr+McrWGQfptX+62EhENHGCBQ9CzvKGnqCHoqLDU9XGSqn3/eCmyTkFhC48eN5TYpq92yVK6jYrdjUX8fF1tn0Z14nmIyTMGAFjCC89ZwdYu59adAX9s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=Xq+xhs5S; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="Xq+xhs5S" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2110a622d76so36765425ad.3 for ; Mon, 04 Nov 2024 16:15:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1730765714; x=1731370514; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=ynHKKKY2R9KZFSpLdWdmwFds5n9xS87KoEUfc7LlVbQ=; b=Xq+xhs5SItiZ9oZVE6vWTAVI0KRaGy3CugbQhmkdGgvgGLhbJjzAtOtJ+0FehLLVqt AABt3fhzOMDSyxncMVfx05UMCIx/x9GcJvreRwqNdy9jpGwa3UJG9LAvr8X0rNgg3hGJ 5gWX8/5hS9uOKbOPMa0MVd+Ou2KIwrx/HA6Es= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730765714; x=1731370514; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ynHKKKY2R9KZFSpLdWdmwFds5n9xS87KoEUfc7LlVbQ=; b=ot2r5/wwuTwBTUez9ZKELEQ772YUCGX2o4PeBxSduseANAAr/g3KVcvOimKXoQMNEn DeGtonGvOYEMEk3ui16YHDGiBDUZeynVWiiAEK4BneCkO1W9HYU9N0uOB6Pd7dSeqmUX vkYyMqxu9z/3zp5z029Jhvpm7S8bPHUkELj4NUL4Yo70JFxvMtLU8nBB98QlE6kR7yqw 44N5dstILBSW0iJsot5bdJD+eeGZQyoGcOaouDilwiG1EDV2iQfGtoTKbx9EcD6Dq5Yk 3dS8ZgtDY10ZTspjSuEquzWSiFC5MsnUyqdUyb7/ClCMDsFNXmwi02vAuQvXUPTr5+Us YiWw== X-Forwarded-Encrypted: i=1; AJvYcCX8EI8Fd6YOeDIN54ha5sfZfLDmcMbtjdYgUcFPb/hfLqAxnWLiBlUx9P0jnvvBZkTd01s5oedXD7CXWS4=@vger.kernel.org X-Gm-Message-State: AOJu0YygV5K7w74nkjDmU7i9UNeW3ECr0oe/qWVF0GqukrTzbGUNxj8A Ei1YE3aHPxzWodlluV/xOAP+5IILgOQ9IhOQV1Ab/cj8KQbK/0px1q8fFf4XyTc= X-Google-Smtp-Source: AGHT+IHEkL8m8bR72apa+vXxyf5vfLzUePunRZZG0kg4JqaPAYNUdMM0D6/JJ1YWfRQjD5W/iT0dUw== X-Received: by 2002:a17:902:db0f:b0:20c:9c09:8280 with SMTP id d9443c01a7336-210c6cc207amr432628295ad.54.1730765714033; Mon, 04 Nov 2024 16:15:14 -0800 (PST) Received: from LQ3V64L9R2 (c-24-6-151-244.hsd1.ca.comcast.net. [24.6.151.244]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2110570835fsm67043375ad.77.2024.11.04.16.15.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Nov 2024 16:15:13 -0800 (PST) Date: Mon, 4 Nov 2024 16:15:10 -0800 From: Joe Damato To: Stanislav Fomichev Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, andrew+netdev@lunn.ch, shuah@kernel.org, horms@kernel.org, almasrymina@google.com, willemb@google.com, petrm@nvidia.com Subject: Re: [PATCH net-next v7 12/12] selftests: ncdevmem: Add automated test Message-ID: Mail-Followup-To: Joe Damato , Stanislav Fomichev , netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, andrew+netdev@lunn.ch, shuah@kernel.org, horms@kernel.org, almasrymina@google.com, willemb@google.com, petrm@nvidia.com References: <20241104181430.228682-1-sdf@fomichev.me> <20241104181430.228682-13-sdf@fomichev.me> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241104181430.228682-13-sdf@fomichev.me> On Mon, Nov 04, 2024 at 10:14:30AM -0800, Stanislav Fomichev wrote: > Only RX side for now and small message to test the setup. > In the future, we can extend it to TX side and to testing > both sides with a couple of megs of data. > > make \ > -C tools/testing/selftests \ > TARGETS="drivers/hw/net" \ > install INSTALL_PATH=~/tmp/ksft > > scp ~/tmp/ksft ${HOST}: > scp ~/tmp/ksft ${PEER}: > > cfg+="NETIF=${DEV}\n" > cfg+="LOCAL_V6=${HOST_IP}\n" > cfg+="REMOTE_V6=${PEER_IP}\n" > cfg+="REMOTE_TYPE=ssh\n" > cfg+="REMOTE_ARGS=root@${PEER}\n" > > echo -e "$cfg" | ssh root@${HOST} "cat > ksft/drivers/net/net.config" > ssh root@${HOST} "cd ksft && ./run_kselftest.sh -t drivers/net:devmem.py" > > Reviewed-by: Mina Almasry > Signed-off-by: Stanislav Fomichev > --- > .../testing/selftests/drivers/net/hw/Makefile | 1 + > .../selftests/drivers/net/hw/devmem.py | 45 +++++++++++++++++++ > 2 files changed, 46 insertions(+) > create mode 100755 tools/testing/selftests/drivers/net/hw/devmem.py > > diff --git a/tools/testing/selftests/drivers/net/hw/Makefile b/tools/testing/selftests/drivers/net/hw/Makefile > index 182348f4bd40..1c6a77480923 100644 > --- a/tools/testing/selftests/drivers/net/hw/Makefile > +++ b/tools/testing/selftests/drivers/net/hw/Makefile > @@ -3,6 +3,7 @@ > TEST_PROGS = \ > csum.py \ > devlink_port_split.py \ > + devmem.py \ > ethtool.sh \ > ethtool_extended_state.sh \ > ethtool_mm.sh \ > diff --git a/tools/testing/selftests/drivers/net/hw/devmem.py b/tools/testing/selftests/drivers/net/hw/devmem.py > new file mode 100755 > index 000000000000..1416c31ff81e > --- /dev/null > +++ b/tools/testing/selftests/drivers/net/hw/devmem.py > @@ -0,0 +1,45 @@ > +#!/usr/bin/env python3 > +# SPDX-License-Identifier: GPL-2.0 > + > +from lib.py import ksft_run, ksft_exit > +from lib.py import ksft_eq, KsftSkipEx > +from lib.py import NetDrvEpEnv > +from lib.py import bkg, cmd, rand_port, wait_port_listen > +from lib.py import ksft_disruptive > + > + > +def require_devmem(cfg): > + if not hasattr(cfg, "_devmem_probed"): > + port = rand_port() > + probe_command = f"./ncdevmem -f {cfg.ifname}" > + cfg._devmem_supported = cmd(probe_command, fail=False, shell=True).ret == 0 > + cfg._devmem_probed = True > + > + if not cfg._devmem_supported: > + raise KsftSkipEx("Test requires devmem support") > + > + > +@ksft_disruptive > +def check_rx(cfg) -> None: > + cfg.require_v6() > + require_devmem(cfg) > + > + port = rand_port() > + listen_cmd = f"./ncdevmem -l -f {cfg.ifname} -s {cfg.v6} -p {port}" > + > + with bkg(listen_cmd) as nc: > + wait_port_listen(port) > + cmd(f"echo -e \"hello\\nworld\"| nc {cfg.v6} {port}", host=cfg.remote, shell=True) FWIW, in the v3 of the series I submit, Jakub asked me to replace nc with socat due to issues with nc [1]. Your usage of nc seems pretty basic though, so maybe it's fine? [1]: https://lore.kernel.org/netdev/20241101063426.2e1423a8@kernel.org/