From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB7F715DBB3 for ; Tue, 5 Nov 2024 16:12:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730823143; cv=none; b=dr3OwNi78Heo+fUtT7AKHSaL0lU4CHgtB0ngEbDLVTAlexJb/xkQ7IKVtZHBURLtnLmAQhWurUmNtJXeulXOQv4Vb4XRarwYEv4BSneORtzTbWuhUIH9cjL9lGHColDTNspe4xrhla2HKQeNqSFkAKoM2b6SOIP9YsWAJvzg++8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730823143; c=relaxed/simple; bh=I2iRxkKM3NVWx6uzM/D8cb0+2M5mNdXMffas92BQWb4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OfYVg7uS7lZHfWOaxuYIHOMfEOgQFjidNuOjXfVB/fmJqOtOkrbfhurVS+/xSLdEfcnOL3XEj1H1+HbHqhgw/QD50LWybXAfs+6I0quBHqugUOqfVJEUwFqR/8yQ/Y/aOmW/0csqm48PU3M/EHlcp4pAXknnm9z10rbXOEhrLpc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=XH15P0nX; arc=none smtp.client-ip=209.85.167.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="XH15P0nX" Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-539e8607c2aso6198663e87.3 for ; Tue, 05 Nov 2024 08:12:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1730823140; x=1731427940; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ttEjCbfgdrl3BvdcxSy4ImFqrGW8bqc6UJKJrO4z/W4=; b=XH15P0nXH0JnXxkhNgKSvra/9I6ccz2rNz5MPSZAmxmzGF2E2n2rUuVelhZmtdC9+d atYKStBhCotae630pUu7TN2Iwpnzaokei4QsZDhPCFwFLTlogOg2sVBE3HpELpGA5Y4v so6NFVpJFk1MesZlmYTuFbSK5osIHijCA7KuP8ftDFK1KjAJUdPBYiItwrXnYTc/HHCN bgUntHX17HO1Z7mlDqHw/saDCfSbU7GJGZXp1HV5FIDRqyPuNTmgZT6bez6eT+RFNFWY /sJzGbo2+bGAP8Va/IoKTFK3KWb9ArDTxhilCJSbz17vKNP96Ji5IUf+v4P3Ec89IY5N Sb+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730823140; x=1731427940; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ttEjCbfgdrl3BvdcxSy4ImFqrGW8bqc6UJKJrO4z/W4=; b=twTZKgfG5brE9kSGrUCh8u5qz00PmkS3LuoQSnSi568AYy5THk7Fzbv69ETll/RVQX 4cHmDRRTCqTkuUmPSFveBmdm0ZE1T3UeTRo7VhXvXlFPWvfBMpv2k/e1BjoZo0cb2LYh RM2+RB6/sFRmj+TuDdiYx9N22PpS/GYAithbFF40Itaz4XA45iLPjcU8SoRgcHFLfBIv vvdWmK2XOYE98bos4FYeVlucccBBQJ2R4HO2mWe/9B9QAk/Av3eLo9229jHHvSFWrokJ 6j4jDmuSVFaTuMKresh1+4CK6Ulxax+Gmg8Tbmq0EB3Vpcjzt5e+q9n2K16mUYf6iNWI 7iDQ== X-Forwarded-Encrypted: i=1; AJvYcCUZ3F62pC60nyEJJ50cxS858rRVFtU+/Fg+0TcGP+f4WZOFmomC0+4Q/JyKVRD1krHjGZWuvvdIZBBS8Wk=@vger.kernel.org X-Gm-Message-State: AOJu0Yycf09JbBvzvJjhnccpAvE6yKtsDodwQ7zyQSBGS1dAc+e7IUUA ltf3PRbchZZ4gENTNOtvWZbGABdJ12XQ5JYfgg4VpBJZjYR0xf8L5xRA02jaVhM= X-Google-Smtp-Source: AGHT+IHPUZr9A8FatRKEkRnjc/0qlX1T40Gkj0a50Y3dgrMI0+B4zd94X/VE7MRVgwbK4ko1t11QaQ== X-Received: by 2002:a05:6512:4022:b0:539:e333:1822 with SMTP id 2adb3069b0e04-53b348b7dc7mr18666577e87.4.1730823139852; Tue, 05 Nov 2024 08:12:19 -0800 (PST) Received: from pathway.suse.cz ([176.114.240.50]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-431bd947c26sm226956235e9.26.2024.11.05.08.12.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Nov 2024 08:12:19 -0800 (PST) Date: Tue, 5 Nov 2024 17:12:17 +0100 From: Petr Mladek To: John Ogness Cc: Greg Kroah-Hartman , Jiri Slaby , Sergey Senozhatsky , Steven Rostedt , Thomas Gleixner , Esben Haabendal , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Rengarajan S , Serge Semin , Lino Sanfilippo Subject: Re: [PATCH tty-next v3 2/6] serial: 8250: Use high-level write function for FIFO Message-ID: References: <20241025105728.602310-1-john.ogness@linutronix.de> <20241025105728.602310-3-john.ogness@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241025105728.602310-3-john.ogness@linutronix.de> On Fri 2024-10-25 13:03:24, John Ogness wrote: > Currently serial8250_console_fifo_write() directly writes into the > UART_TX register, rather than using the high-level function > serial8250_console_putchar(). This is because > serial8250_console_putchar() waits for the holding register to > become empty. That would defeat the purpose of the FIFO code. > > Move the LSR_THRE waiting to a new function > serial8250_console_wait_putchar() so that the FIFO code can use > serial8250_console_putchar(). This will be particularly important > for a follow-up commit, where output bytes are inspected to track > newlines. > > This is only refactoring and has no functional change. > > Signed-off-by: John Ogness Looks good: Reviewed-by: Petr Mladek Best Regards, Petr