mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: wojackbb@gmail.com
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v3]USB: serial: qcserial: add support for Sierra Wireless EM86xx
Date: Wed, 6 Nov 2024 15:14:51 +0100	[thread overview]
Message-ID: <Zyt52y7uc3u99p2V@hovoldconsulting.com> (raw)
In-Reply-To: <20241106105029.338457-1-wojackbb@gmail.com>

On Wed, Nov 06, 2024 at 06:50:29PM +0800, wojackbb@gmail.com wrote:
> From: Jack Wu <wojackbb@gmail.com>
> 
> Add support for Sierra Wireless EM86xx with
> USB-id 0x1199:0x90e5 & 0x1199:0x90e4.

> 0x1199:0x90e4
> T:  Bus=03 Lev=01 Prnt=01 Port=05 Cnt=01 Dev#= 16 Spd=480  MxCh= 0
> D:  Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  1
> P:  Vendor=1199 ProdID=90e4 Rev= 0.00
> S:  Manufacturer=Sierra Wireless, Incorporated
> S:  SerialNumber=004403161882339
> C:* #Ifs= 1 Cfg#= 1 Atr=a0 MxPwr=  2mA
> I:* If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=10 Driver=qcserial
> E:  Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E:  Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> ---
> v3 changes: the entries sorted by PID
> ---
> Signed-off-by: Jack Wu <wojackbb@gmail.com>
> ---

Thanks for the update. Next time make sure you put the changelog here
after your SoB and the --- line.

As it currently stands you SoB is not included when I apply the patch.
I've fixed it up manually, but please remember this for your future
contributions.

Also, the patch revision typically goes inside the PATCH marker:

	[PATCH v3] USB: serial: ...

Johan

      reply	other threads:[~2024-11-06 14:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-06 10:50 wojackbb
2024-11-06 14:14 ` Johan Hovold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zyt52y7uc3u99p2V@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=wojackbb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®