From: Mark Brown <broonie@kernel.org>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>, Shuah Khan <shuah@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v2 3/3] kselftest/arm64: Add FPMR coverage to fp-ptrace
Date: Tue, 12 Nov 2024 13:38:01 +0000 [thread overview]
Message-ID: <ZzNaOSjRrO5bAJ46@finisterre.sirena.org.uk> (raw)
In-Reply-To: <ZzNXnJ3Jc45CctCs@arm.com>
[-- Attachment #1: Type: text/plain, Size: 663 bytes --]
On Tue, Nov 12, 2024 at 01:26:52PM +0000, Catalin Marinas wrote:
> On Tue, Nov 12, 2024 at 01:08:16PM +0000, Mark Brown wrote:
> > + // This has to come after we set PSTATE.SM
> > +check_fpmr_in:
> > + tbz x0, #HAVE_FPMR_SHIFT, wait_for_writes
> > + adrp x7, fpmr_in
> > + ldr x7, [x7, :lo12:fpmr_in]
> > + msr FPMR, x7
> Did this build for you? I may not have a new enough assembler.
Yes, it even ran through tests. I suspect it's picking up some
(possibly stale generated?) header file which has the FPMR define in it.
> fp-ptrace-asm.S:149:6: error: expected writable system register or pstate
> msr FPMR, x7
> I changed it to REG_FPMR locally.
Thanks.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-11-12 13:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 13:08 [PATCH v2 0/3] kselftest/arm64: fp-ptrace enhancements Mark Brown
2024-11-12 13:08 ` [PATCH v2 1/3] kselftets/arm64: Use flag bits for features in fp-ptrace assembler code Mark Brown
2024-11-12 13:08 ` [PATCH v2 2/3] kselftest/arm64: Expand the set of ZA writes fp-ptrace does Mark Brown
2024-11-12 13:08 ` [PATCH v2 3/3] kselftest/arm64: Add FPMR coverage to fp-ptrace Mark Brown
2024-11-12 13:26 ` Catalin Marinas
2024-11-12 13:38 ` Mark Brown [this message]
2024-11-12 16:07 ` [PATCH v2 0/3] kselftest/arm64: fp-ptrace enhancements Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzNaOSjRrO5bAJ46@finisterre.sirena.org.uk \
--to=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=shuah@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®