From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EF5C7082B for ; Wed, 13 Nov 2024 02:05:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731463510; cv=none; b=nP0/PxxVkLdRkwqVYfTeimnHoyGKNF4pV0GmiRQfAhg305X48vcY+D7mA7quVdoqbCTAlXUdAd01brj81tbgmFnySNw43AddxBNTAKmnf5cDsLFpkS9AuM2iSWmOrKXY6KR74HuFHJ8qfA2tLVTY9rH0UjXaEOTAZbvAoOnAFTw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731463510; c=relaxed/simple; bh=cZnw/3d3PzrW45LyARayO0lNM4W6T7F7djT+bgWr9KM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ocAYJIdmCRSUbj8Gpnmm37QvqpLhKuS0y4IRaeU0Z1nvHjC6C+/LwkxPRSul0jeiu/4mXpiEHjwdOSNHC+MD7vKvEOw8lRZH6TKvjxB9rTn1SpZJg3+Jr2vbES1cMMk4jbxjcarfkDYDIcnEXSAlNWkbywnj4PBPKHeEyxFQu5o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=v+WPt11r; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="v+WPt11r" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-2e30fb8cb07so4952670a91.3 for ; Tue, 12 Nov 2024 18:05:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1731463508; x=1732068308; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=SMHgs78kJCT59kXAGyaHtemSt2oZrSdkOMKAYsOBJwg=; b=v+WPt11rn6f+WywNl7fcGBmz9BUQ4BjOvHs1RgyfVhq8no4RyR07DlUua0XokrWrxC hOYiFQICXQrzHKAJsjMoYkQ3m2dgcDGsjv9jXrpruxy9tzUTzb+czjo+gVxHnRge7krr 4tfUUrSHvP67kiVHvwrpkYnMTBuS27QZt6lY8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731463508; x=1732068308; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SMHgs78kJCT59kXAGyaHtemSt2oZrSdkOMKAYsOBJwg=; b=AHHC03lPadCOZNdgdpTdU7AFVRRIAz5fez8067iv0JRVZzS2pOdvQevVAkxhIz98z8 KbJG/lgf87siTeWH2ldSbL/c8xNDZvr/F9Zz5GUe3q2ikL2YCTSufXFhGIFLTAJz/IQ2 MtochqjD9HXz+WYqWPrw/PHl0XLqTKwip4wFYZfFUJudH+WAWJN+qwayWwsjRrIWhZJZ mlCAK7HPev+xlraII1Kl69cj2YosHpYkFgAM8SilwLe0cHWmHWdOKO82bokGUfeNzKZO RnrXG2mm7U6bq23XXUePnuKpPdxBp6084/UcR8SAJW4fM4HGE1qdy8bEU1Bn7CENobfq /mTg== X-Forwarded-Encrypted: i=1; AJvYcCXfPiUPlXbdgIX9Cowalo2dO2WnTYBVoT5PwIebIOc2L14Jm8uD3DoKDTBUiHeSJ9X9YUCrF5cJC3Pf/KU=@vger.kernel.org X-Gm-Message-State: AOJu0YzxqGkDW6qyLnA+spMcSNOV/FG/4+xEkf767UHfwzInUZskL2JG D6fhSfoAJpy7cFQLrCMmrl/QCzWgLaVoDZFtqAhIbtgoVyQBIBiYciiwUw2SJQo= X-Google-Smtp-Source: AGHT+IE3BGRjmhR0ZvvRxux2FPKe4+dk1Cle8rzXMHK76AdSLTy/P4WM0poxY1ZTUsslRuA+89mD9Q== X-Received: by 2002:a17:90b:1d11:b0:2e3:171e:3b8c with SMTP id 98e67ed59e1d1-2e9e4c73c42mr6334898a91.25.1731463508401; Tue, 12 Nov 2024 18:05:08 -0800 (PST) Received: from LQ3V64L9R2 (c-24-6-151-244.hsd1.ca.comcast.net. [24.6.151.244]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e9f3eca101sm275665a91.14.2024.11.12.18.05.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Nov 2024 18:05:07 -0800 (PST) Date: Tue, 12 Nov 2024 18:05:05 -0800 From: Joe Damato To: Jakub Kicinski Cc: netdev@vger.kernel.org, pabeni@redhat.com, edumazet@google.com, amritha.nambiar@intel.com, sridhar.samudrala@intel.com, mkarsten@uwaterloo.ca, stable@vger.kernel.org, "David S. Miller" , Simon Horman , Mina Almasry , open list Subject: Re: [RFC net 1/2] netdev-genl: Hold rcu_read_lock in napi_get Message-ID: Mail-Followup-To: Joe Damato , Jakub Kicinski , netdev@vger.kernel.org, pabeni@redhat.com, edumazet@google.com, amritha.nambiar@intel.com, sridhar.samudrala@intel.com, mkarsten@uwaterloo.ca, stable@vger.kernel.org, "David S. Miller" , Simon Horman , Mina Almasry , open list References: <20241112181401.9689-1-jdamato@fastly.com> <20241112181401.9689-2-jdamato@fastly.com> <20241112172840.0cf9731f@kernel.org> <20241112180102.465dd909@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241112180102.465dd909@kernel.org> On Tue, Nov 12, 2024 at 06:01:02PM -0800, Jakub Kicinski wrote: > On Tue, 12 Nov 2024 17:48:42 -0800 Joe Damato wrote: > > Sorry for the noob question: should I break it up into two patches > > with one CCing stable and the other not like I did for this RFC? > > > > Patch 1 definitely "feels" like a fixes + CC stable > > Patch 2 could be either net-next or a net + "fixes" without stable? > > Oh, sorry, I didn't comment on that because that part is correct. > The split is great, will make backporting easier. OK, cool, that's what I figured. Thanks for the guidance; will repost shortly.