From: Matthew Wilcox <willy@infradead.org>
To: Suraj Sonawane <surajsonawane0215@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+18dd03a3fcf0ffe27da0@syzkaller.appspotmail.com
Subject: Re: [PATCH] hfs: Fix uninitialized value issue in hfs_iget
Date: Fri, 15 Nov 2024 17:03:22 +0000 [thread overview]
Message-ID: <Zzd-2iVB2AtJaxR8@casper.infradead.org> (raw)
In-Reply-To: <e43ec7eb-6acf-41e3-b7f9-f0391bf4cb65@gmail.com>
On Fri, Nov 15, 2024 at 09:22:31PM +0530, Suraj Sonawane wrote:
> On 23/09/24 23:30, SurajSonawane2415 wrote:
> > Fix uninitialized value issue in hfs_iget by initializing the hfs_cat_rec
> > structure in hfs_lookup.
This doesn't make sense to me. I don't see how we get to hfs_iget()
with an uninit "rec".
hfs_cat_rec rec;
...
res = hfs_brec_read(&fd, &rec, sizeof(rec));
if (res) {
...
} else {
inode = hfs_iget(dir->i_sb, &fd.search_key->cat, &rec);
Unless there's a path in hfs_brec_read() which returns 'success' while
not actually filling in all of 'rec', in which case that's the bug which
needs to be fixed.
prev parent reply other threads:[~2024-11-15 17:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 18:00 SurajSonawane2415
2024-11-15 15:52 ` Suraj Sonawane
2024-11-15 17:03 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zzd-2iVB2AtJaxR8@casper.infradead.org \
--to=willy@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=surajsonawane0215@gmail.com \
--cc=syzbot+18dd03a3fcf0ffe27da0@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®