mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matt Coster <Matt.Coster@imgtec.com>
To: Michal Wilczynski <m.wilczynski@samsung.com>
Cc: Frank Binns <Frank.Binns@imgtec.com>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 0/2] Add optional reset for the drm/imagination driver
Date: Tue, 22 Apr 2025 16:16:53 +0000	[thread overview]
Message-ID: <a000c060-bd0b-4225-aa6f-fcfb84b307bf@imgtec.com> (raw)
In-Reply-To: <20250418-apr_18_reset_img-v6-0-85a06757b698@samsung.com>


[-- Attachment #1.1: Type: text/plain, Size: 2900 bytes --]

On 18/04/2025 12:22, Michal Wilczynski wrote:
> This patch series introduces and documents optional reset support for
> the drm/imagination driver. While developed as part of a larger effort
> to enable the Imagination BXM-4-64 GPU upstream, these patches can merge
> independently.
> 
> During the upstreaming process, we discovered that the T-HEAD TH1520 SoC
> requires custom code to manage resets and clocks from the power-domain
> driver [1]. Nevertheless, adding this reset capability is necessary, as
> the GPU Device Tree node would own the reset control and would manage it
> for boards like BPI-F3 that don't have custom requirements for handling
> clocks and resets during their startup sequence.
> 
> For more context, please see the cover letter for the larger series [2].

Hi Michal,

Thank you for persisting with these changes, I know we haven't always
made it easy for you!

This series (sub-series?) is:

Reviewed-by: Matt Coster <matt.coster@imgtec.com>

If nobody has any objections, I'll apply it to drm-misc-next tomorrow.

Cheers,
Matt

> 
> [1] - https://lore.kernel.org/all/20250414-apr_14_for_sending-v2-0-70c5af2af96c@samsung.com/ 
> [2] - https://lore.kernel.org/all/20250219140239.1378758-1-m.wilczynski@samsung.com/ 
> 
> This series is versioned to maintain continuity with the bigger patchset
> it is a subseries of. Please find below changelog for the
> drm/imagination reset part:
> 
> v6:
>  - no changes, just a re-send, bumping version to avoid confusion
> 
> v5:
>  - moved the recommended 1 microsecond delay after de-asserting GPU
>    reset to the Imagination driver itself 
> 
> v4:
>  - reverted reset-cells configuration to single cell as in v2
>  - addressed minor implementation issues in the DRM/Imagination reset driver
> 
> v3:
>  - refactored reset driver to use zero cells
> 
> v2:
>  - updated the drm/imagination driver to act as a reset controller
>    consumer. While this patchset is focused on the LPI4A board, the
>    reset controller is designed to be useful for other boards, such as the
>    BPI-3F, which also require a reset sequence after power-up.
> 
> ---
> Michal Wilczynski (2):
>       dt-bindings: gpu: Add 'resets' property for GPU initialization
>       drm/imagination: Add reset controller support for GPU initialization
> 
>  .../devicetree/bindings/gpu/img,powervr-rogue.yaml |  3 +++
>  drivers/gpu/drm/imagination/pvr_device.c           | 21 +++++++++++++++++++++
>  drivers/gpu/drm/imagination/pvr_device.h           |  9 +++++++++
>  drivers/gpu/drm/imagination/pvr_power.c            | 22 +++++++++++++++++++++-
>  4 files changed, 54 insertions(+), 1 deletion(-)
> ---
> base-commit: fc96b232f8e7c0a6c282f47726b2ff6a5fb341d2
> change-id: 20250418-apr_18_reset_img-b102988052de
> 
> Best regards,


-- 
Matt Coster
E: matt.coster@imgtec.com

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

  parent reply	other threads:[~2025-04-22 16:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20250418112258eucas1p28186b27890dbed4cbc05b2ddd8f94327@eucas1p2.samsung.com>
2025-04-18 11:22 ` Michal Wilczynski
     [not found]   ` <CGME20250418112258eucas1p22817a5693654e02016bcdc79068ed9e0@eucas1p2.samsung.com>
2025-04-18 11:22     ` [PATCH v6 1/2] dt-bindings: gpu: Add 'resets' property for GPU initialization Michal Wilczynski
     [not found]   ` <CGME20250418112259eucas1p14c8a04007b0e279b8e134db9e1502d7c@eucas1p1.samsung.com>
2025-04-18 11:22     ` [PATCH v6 2/2] drm/imagination: Add reset controller support " Michal Wilczynski
2025-04-22 16:16   ` Matt Coster [this message]
2025-04-24 10:12   ` [PATCH v6 0/2] Add optional reset for the drm/imagination driver Matt Coster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a000c060-bd0b-4225-aa6f-fcfb84b307bf@imgtec.com \
    --to=matt.coster@imgtec.com \
    --cc=Frank.Binns@imgtec.com \
    --cc=airlied@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=m.wilczynski@samsung.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®