From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933520AbdHYPG4 (ORCPT ); Fri, 25 Aug 2017 11:06:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33944 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933490AbdHYPGz (ORCPT ); Fri, 25 Aug 2017 11:06:55 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9A08D461FB Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=hdegoede@redhat.com Subject: Re: [RFC v2 1/2] virt: Add vboxguest driver for Virtual Box Guest integration To: Christoph Hellwig Cc: Arnd Bergmann , Greg Kroah-Hartman , Michael Thayer , "Knut St . Osmundsen" , Larry Finger , linux-kernel@vger.kernel.org References: <20170825143732.10836-1-hdegoede@redhat.com> <20170825143732.10836-2-hdegoede@redhat.com> <20170825145806.GA6706@infradead.org> <9e9b6c22-50dd-4935-9dfd-7c8a885f75e9@redhat.com> <20170825150324.GA23830@infradead.org> From: Hans de Goede Message-ID: Date: Fri, 25 Aug 2017 17:06:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170825150324.GA23830@infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 25 Aug 2017 15:06:55 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 25-08-17 17:03, Christoph Hellwig wrote: > On Fri, Aug 25, 2017 at 05:00:31PM +0200, Hans de Goede wrote: >> I've already removed all the typedefs and camel-case outside of >> include/uapi/linux >> >> The ones in include/uapi/linux are preserved to preserve API >> compatibility with the existing VirtualBox userspace tools. > > When merging new drivers we need to fix up the user abis anyway, > we don't want to be stuck with mistakes from the past. And the > APIs look pretty bad, so there will be a lot work required after > this basic cleanup anyway. I'm afraid that the userspace API is more or less a take it or leave it kinda deal, we can do small cleanups, but an entire re-design is out of the question. The vboxguest code has a long (too long) out of tree history and the same ioctl interface is used by VirtualBox upstream on Windows, Mac OS X, the BSDs and Solaris, so we cannot just go and break it to out hart's content. Regards, Hans