mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: "Bernard Zhao" <bernard@vivo.com>,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"Chunming Zhou" <David1.Zhou@amd.com>
Cc: "Andrzej Pietrasiewicz" <andrzej.p@collabora.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"David Airlie" <airlied@linux.ie>,
	"Dhinakaran Pandiyan" <dhinakaran.pandiyan@intel.com>,
	"José Roberto de Souza" <jose.souza@intel.com>,
	"Lyude Paul" <lyude@redhat.com>,
	"Neil Armstrong" <narmstrong@baylibre.com>,
	"Sam Ravnborg" <sam@ravnborg.org>,
	linux-kernel@vger.kernel.org, opensource.kernel@vivo.com
Subject: Re: [PATCH] drm/amdgpu: Return more error codes in amdgpu_connector_set_property()
Date: Sun, 19 Apr 2020 11:34:47 +0200	[thread overview]
Message-ID: <a00cc21a-383f-67ca-cdc5-b727ae59d31c@web.de> (raw)

> The "if(!encoder)" branch return the same value 0 of the success
> branch, maybe return -EINVAL is more better.

I suggest to improve the commit message.

* Would you like to adjust the patch subject?

* How do you think about to add the tag “Fixes”
  because of adjustments for the exception handling?

Regards,
Markus

             reply	other threads:[~2020-04-19  9:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-19  9:34 Markus Elfring [this message]
2020-04-20  0:56 ` 赵军奎

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a00cc21a-383f-67ca-cdc5-b727ae59d31c@web.de \
    --to=markus.elfring@web.de \
    --cc=David1.Zhou@amd.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=andrzej.p@collabora.com \
    --cc=bernard@vivo.com \
    --cc=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dhinakaran.pandiyan@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jose.souza@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lyude@redhat.com \
    --cc=narmstrong@baylibre.com \
    --cc=opensource.kernel@vivo.com \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®