From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92CBC2EA75E for ; Thu, 18 Jun 2026 12:43:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781786625; cv=none; b=nbklKu2/8NS6KNBkMnm2yjLepUFAxCp5QqI76LsbIp1GfhT7j7suud/y8t7EbqN4eeCN3Q9dmLjmU5xu6ONyNI65iCvUulYefWEvzbGjkHVIv3sBk9+9UrpxeVZBXLf88fywRYOZtVM335LSb9gOSxXI05u8wwy6DXQOrKKR980= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781786625; c=relaxed/simple; bh=dlYelIJLOggcvkumlFbjoZM+qpa9euLcPbaxUeQzkHQ=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=gdn3YJqjotNcBKdDxIpY1sN5qg7yEVUE25XBCzUXak14G18EY573i9ucpQ56aCGq5yOAmtNpD2b4CUjUk3oMUCS2NUk/ALxH5X7HM6wwcnjnWCaDfRNu0eXynPo67lGjYmPJvO1ZwBPHJD7uLOq92KlFB6Lzp9CrPfLqRhoY+Fo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yX3VX1E4; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yX3VX1E4" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4921e4dd62dso7330685e9.0 for ; Thu, 18 Jun 2026 05:43:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1781786621; x=1782391421; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=x8JZcEbEN9+L4E/fkgdE7qzbLCs2DJHcRzGzneoeNvg=; b=yX3VX1E4ikIgqpC7qSnubkfvqqKimhMcuea7n8qo0rVpxFPuvEtqT+P4m06jv+iIqX gpX6qq3dfa1hyp8odte2H7HTvUc6UA5Dt5WePIL8lzXPhzdxmg5HRCCxP/x3T0jOJIAo F9HdwkKnuqMyigkJ0W8TxGOkpGEKECVcDUiFTIjljqop6KRO5UNO3nvaYK8yVDSRRj5q 7hOeG7dklbN8YgzHquS5pFhFedG7NeVaWVmNf4V5VntFMHUMf7FK5yYTG0dUYoCWxMwj DUnunXaYCMtux/04wJjnzMHPVIFUF1GHarPOAQg0igTyjjRI8gc6Y4V7j3/eWUthbK07 l5DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781786621; x=1782391421; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x8JZcEbEN9+L4E/fkgdE7qzbLCs2DJHcRzGzneoeNvg=; b=hgQqB1RQcj1Wp/zRc1MhdIGkGD+H+1qg96+JIiW4Xb0e+xF8Szc9Fipr0WY68HLpWm +hKL7B2Dz31N9YGDypuLXOXDannFk90zbI5utN3CVr/q138hBAqJni29Pt74jknNkKyC DApUaGTyTcwGPRyWbFOOAl2IOdpUKtUYgNqgxH8RhOZd6NjWBwpPY//0BlzQ11R8MtxU AcNz7uJc8mWMi0WdF61JvaZWHQxPbILtoPV79yl5Dnep5EJMnmsonnkbHjxXDZxW1Okr RCH25Ju6r6eGaNguAK+BXlBbs8S22mry8DR5u1DU/j2aLH+w1sT1u8B0Fqfgr03Jhtqc 9dXQ== X-Forwarded-Encrypted: i=1; AFNElJ/HVFBr40pUGAYzarWZCVkmZ+MvGtbA8Ebzz8WILQjGLRHo16EfSOfDlUMOaauPj0vKVJeknhitytHcNRE=@vger.kernel.org X-Gm-Message-State: AOJu0YzYP7tbfRZY8n9k5rbf5oOF/0L0CK2gEqh9MOWvim/Q7EdaU/AE 7O3dPdgpcMfbYkoEJpsHU47GPibsjSNF8V3Z7JeqJfCsWlM0REwhvbsDi6/64vdivQ8= X-Gm-Gg: AfdE7ckb19wZsP9o+ggqW6J8nN3BSDyD0O/brYG30EuM3n6tR+fP7VAfRMCrLaO+o6W K2yusGS6M1QKmH8nzkrQwSNWArNYRLT4zQLzl7fOglsVOG0Ji1zeI3ExIo4MlDtkhdqcE6hbT/Y UTiZtEnHgj1azb9VeGqiBVSrGaw9ZU3LX6bRsXknlN4afyAopxbwp/OC15gi4ODbcJW7Brtx4w2 GcQjS5JFJwZOAPdy0KGqxn6xf7Ruo9kiLsaE4AF2Y0emlCNvz2MBgaOKCa6TBOQuZ2TBfiIhYoN 6x0rHoUu92KzNoRnpC6pHPmR1bmA1yPG8jkupSwlTwbrj5WewWLxDEvnTMzDyYQiBSxdhKV49Ez pDBlsNq5uT1CxLRlR6L6zWGNufX9rmcECp41H3RHTuDe47o215gFF9E/ocQWL7T3gZXUHMZNsne ml26CQ5woox/U23HDIf+BuCTRFRV9XGJkGEhGMypFyOiF5A1bpZEtI1678eOTFH/1RBg== X-Received: by 2002:a05:600c:4593:b0:490:4b89:5372 with SMTP id 5b1f17b1804b1-4923817fef2mr47961125e9.11.1781786620771; Thu, 18 Jun 2026 05:43:40 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:6e1b:5a5:b2b5:b2c0? ([2a01:e0a:106d:1080:6e1b:5a5:b2b5:b2c0]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4922fa510e7sm287233905e9.7.2026.06.18.05.43.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2026 05:43:39 -0700 (PDT) Message-ID: Date: Thu, 18 Jun 2026 14:43:39 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v2 2/2] drm/panel: add Ilitek ILI7807S panel driver To: Arpit Saini , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ayushi.makhija@oss.qualcomm.com, rajeevny@qti.qualcomm.com References: <20260618-ili7807s-v2-0-b3f0c109b102@oss.qualcomm.com> <20260618-ili7807s-v2-2-b3f0c109b102@oss.qualcomm.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260618-ili7807s-v2-2-b3f0c109b102@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/18/26 12:24, Arpit Saini wrote: > Add a DRM panel driver for the DLC DLC0697 1080x1920@60Hz MIPI DSI > panel based on the Ilitek ILI7807S display controller. > > The panel operates in video burst mode with four data lanes using > RGB888 pixel format. > > Signed-off-by: Arpit Saini > --- > drivers/gpu/drm/panel/Kconfig | 12 ++ > drivers/gpu/drm/panel/Makefile | 1 + > drivers/gpu/drm/panel/panel-ilitek-ili7807s.c | 297 ++++++++++++++++++++++++++ > 3 files changed, 310 insertions(+) > > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > index 7450b27622a2..1cbaac1bf545 100644 > --- a/drivers/gpu/drm/panel/Kconfig > +++ b/drivers/gpu/drm/panel/Kconfig > @@ -264,6 +264,18 @@ config DRM_PANEL_HYDIS_HV101HD1 > > If M is selected the module will be called panel-hydis-hv101hd1 > > +config DRM_PANEL_ILITEK_ILI7807S > + tristate "Ilitek ILI7807S-based panels" > + depends on OF > + depends on DRM_MIPI_DSI > + depends on BACKLIGHT_CLASS_DEVICE > + help > + Say Y if you want to enable support for panels based on the > + Ilitek ILI7807S display controller, such as the DLC DLC0697 > + 1080x1920 MIPI DSI panel. > + > + If M is selected the module will be called panel-ilitek-ili7807s. > + > config DRM_PANEL_ILITEK_IL9322 > tristate "Ilitek ILI9322 320x240 QVGA panels" > depends on OF && SPI > diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile > index c2c5cf817116..c3002b351cb8 100644 > --- a/drivers/gpu/drm/panel/Makefile > +++ b/drivers/gpu/drm/panel/Makefile > @@ -26,6 +26,7 @@ obj-$(CONFIG_DRM_PANEL_HIMAX_HX83112B) += panel-himax-hx83112b.o > obj-$(CONFIG_DRM_PANEL_HIMAX_HX83121A) += panel-himax-hx83121a.o > obj-$(CONFIG_DRM_PANEL_HIMAX_HX8394) += panel-himax-hx8394.o > obj-$(CONFIG_DRM_PANEL_HYDIS_HV101HD1) += panel-hydis-hv101hd1.o > +obj-$(CONFIG_DRM_PANEL_ILITEK_ILI7807S) += panel-ilitek-ili7807s.o > obj-$(CONFIG_DRM_PANEL_ILITEK_IL9322) += panel-ilitek-ili9322.o > obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9341) += panel-ilitek-ili9341.o > obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9805) += panel-ilitek-ili9805.o > diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili7807s.c b/drivers/gpu/drm/panel/panel-ilitek-ili7807s.c > new file mode 100644 > index 000000000000..bfbb8e29a4aa > --- /dev/null > +++ b/drivers/gpu/drm/panel/panel-ilitek-ili7807s.c > @@ -0,0 +1,297 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > +#include > +#include > + > +struct panel_desc { > + const struct drm_display_mode *mode; > + unsigned int lanes; > + enum mipi_dsi_pixel_format format; > + unsigned long mode_flags; > + void (*init)(struct mipi_dsi_multi_context *dsi_ctx); > +}; > + > +struct ili7807s { > + struct drm_panel panel; > + struct mipi_dsi_device *dsi; > + const struct panel_desc *desc; > + > + struct regulator_bulk_data *supplies; > + struct gpio_desc *reset_gpio; > +}; > + > +static const struct regulator_bulk_data ili7807s_supplies[] = { > + { .supply = "vddi" }, > + { .supply = "avdd" }, > + { .supply = "avee" }, > +}; > + > +static inline struct ili7807s *to_ili7807s(struct drm_panel *panel) > +{ > + return container_of(panel, struct ili7807s, panel); > +} > + > +static void ili7807s_reset(struct ili7807s *ctx) > +{ > + gpiod_set_value_cansleep(ctx->reset_gpio, 0); > + usleep_range(10000, 11000); > + gpiod_set_value_cansleep(ctx->reset_gpio, 1); > + usleep_range(10000, 11000); > + gpiod_set_value_cansleep(ctx->reset_gpio, 0); > + usleep_range(10000, 11000); > +} > + > +static void dlc0697_init_sequence(struct mipi_dsi_multi_context *dsi_ctx) > +{ > + mipi_dsi_dcs_soft_reset_multi(dsi_ctx); > + mipi_dsi_msleep(dsi_ctx, 120); > + > + mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xff, 0x78, 0x07, 0x00); > + mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x35, 0x00); > + mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x5e, 0x09, 0x99); > + mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x53, 0x24); > + mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x55, 0x01); > + mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x51, 0x3f, 0xff); > + > + mipi_dsi_dcs_exit_sleep_mode_multi(dsi_ctx); > + mipi_dsi_msleep(dsi_ctx, 120); > + > + mipi_dsi_dcs_set_display_on_multi(dsi_ctx); > + mipi_dsi_msleep(dsi_ctx, 20); > +} > + > +static int ili7807s_on(struct ili7807s *ctx) > +{ > + struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi }; > + > + ctx->dsi->mode_flags |= MIPI_DSI_MODE_LPM; > + > + ctx->desc->init(&dsi_ctx); > + > + ctx->dsi->mode_flags &= ~MIPI_DSI_MODE_LPM; > + > + return dsi_ctx.accum_err; > +} > + > +static int ili7807s_off(struct ili7807s *ctx) > +{ > + struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi }; > + > + ctx->dsi->mode_flags |= MIPI_DSI_MODE_LPM; > + > + mipi_dsi_dcs_set_display_off_multi(&dsi_ctx); > + mipi_dsi_msleep(&dsi_ctx, 20); > + > + mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx); > + mipi_dsi_msleep(&dsi_ctx, 120); > + > + ctx->dsi->mode_flags &= ~MIPI_DSI_MODE_LPM; > + > + return dsi_ctx.accum_err; > +} > + > +static int ili7807s_prepare(struct drm_panel *panel) > +{ > + struct ili7807s *ctx = to_ili7807s(panel); > + int ret; > + > + ret = regulator_bulk_enable(ARRAY_SIZE(ili7807s_supplies), ctx->supplies); > + if (ret < 0) { > + dev_err(ctx->panel.dev, "failed to enable regulators: %d\n", ret); > + return ret; > + } > + > + msleep(20); > + > + ili7807s_reset(ctx); > + > + ret = ili7807s_on(ctx); > + if (ret < 0) { > + dev_err(ctx->panel.dev, "failed to initialise panel: %d\n", ret); > + goto err; > + } > + > + return 0; > + > +err: > + gpiod_set_value_cansleep(ctx->reset_gpio, 1); > + > + regulator_bulk_disable(ARRAY_SIZE(ili7807s_supplies), ctx->supplies); > + return ret; > +} > + > +static int ili7807s_unprepare(struct drm_panel *panel) > +{ > + struct ili7807s *ctx = to_ili7807s(panel); > + int ret; > + > + ret = ili7807s_off(ctx); > + if (ret < 0) > + dev_err(ctx->panel.dev, "failed to disable panel: %d\n", ret); > + > + gpiod_set_value_cansleep(ctx->reset_gpio, 1); > + > + regulator_bulk_disable(ARRAY_SIZE(ili7807s_supplies), ctx->supplies); > + > + return 0; > +} > + > +static int ili7807s_get_modes(struct drm_panel *panel, > + struct drm_connector *connector) > +{ > + struct ili7807s *ctx = to_ili7807s(panel); > + > + return drm_connector_helper_get_modes_fixed(connector, ctx->desc->mode); > +} > + > +static const struct drm_panel_funcs ili7807s_panel_funcs = { > + .prepare = ili7807s_prepare, > + .unprepare = ili7807s_unprepare, > + .get_modes = ili7807s_get_modes, > +}; > + > +static int ili7807s_bl_update_status(struct backlight_device *bl) > +{ > + struct mipi_dsi_device *dsi = bl_get_data(bl); > + u16 brightness = backlight_get_brightness(bl); > + int ret; > + > + dsi->mode_flags &= ~MIPI_DSI_MODE_LPM; > + > + ret = mipi_dsi_dcs_set_display_brightness_large(dsi, brightness); > + > + dsi->mode_flags |= MIPI_DSI_MODE_LPM; > + > + return ret; > +} > + > +static const struct backlight_ops ili7807s_bl_ops = { > + .update_status = ili7807s_bl_update_status, > +}; > + > +static struct backlight_device *ili7807s_create_backlight(struct mipi_dsi_device *dsi) > +{ > + struct device *dev = &dsi->dev; > + const struct backlight_properties props = { > + .type = BACKLIGHT_RAW, > + .brightness = 0x3fff, > + .max_brightness = 0x3fff, > + }; > + > + return devm_backlight_device_register(dev, dev_name(dev), dev, dsi, > + &ili7807s_bl_ops, &props); > +} > + > +static const struct drm_display_mode dlc0697_mode = { > + .clock = 131911, .clock = (1080 + 18 + 2 + 16) * (1920 + 26 + 4 + 20) * 60 / 1000, > + > + .hdisplay = 1080, > + .hsync_start = 1080 + 18, > + .hsync_end = 1080 + 18 + 2, > + .htotal = 1080 + 18 + 2 + 16, > + > + .vdisplay = 1920, > + .vsync_start = 1920 + 26, > + .vsync_end = 1920 + 26 + 4, > + .vtotal = 1920 + 26 + 4 + 20, > + > + .width_mm = 0, > + .height_mm = 0, > + .type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED, > +}; > + > +static const struct panel_desc dlc0697_desc = { > + .mode = &dlc0697_mode, > + .lanes = 4, > + .format = MIPI_DSI_FMT_RGB888, > + .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST, > + .init = dlc0697_init_sequence, > +}; > + > +static int ili7807s_probe(struct mipi_dsi_device *dsi) > +{ > + struct device *dev = &dsi->dev; > + const struct panel_desc *desc; > + struct ili7807s *ctx; > + int ret; > + > + ctx = devm_drm_panel_alloc(dev, struct ili7807s, panel, > + &ili7807s_panel_funcs, > + DRM_MODE_CONNECTOR_DSI); > + if (IS_ERR(ctx)) > + return PTR_ERR(ctx); > + > + desc = of_device_get_match_data(dev); > + ctx->desc = desc; > + > + ret = devm_regulator_bulk_get_const(dev, ARRAY_SIZE(ili7807s_supplies), > + ili7807s_supplies, &ctx->supplies); > + if (ret < 0) > + return dev_err_probe(dev, ret, "failed to get regulators\n"); > + > + ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); > + if (IS_ERR(ctx->reset_gpio)) > + return dev_err_probe(dev, PTR_ERR(ctx->reset_gpio), > + "failed to get reset gpio\n"); > + > + ctx->dsi = dsi; > + mipi_dsi_set_drvdata(dsi, ctx); > + > + dsi->lanes = desc->lanes; > + dsi->format = desc->format; > + dsi->mode_flags = desc->mode_flags; > + > + ctx->panel.prepare_prev_first = true; > + > + ret = drm_panel_of_backlight(&ctx->panel); > + if (ret) > + return ret; > + > + if (!ctx->panel.backlight) { > + ctx->panel.backlight = ili7807s_create_backlight(dsi); > + if (IS_ERR(ctx->panel.backlight)) > + return dev_err_probe(dev, PTR_ERR(ctx->panel.backlight), > + "failed to create backlight\n"); > + } > + > + ret = devm_drm_panel_add(dev, &ctx->panel); > + if (ret < 0) > + return dev_err_probe(dev, ret, "failed to add panel\n"); > + > + ret = devm_mipi_dsi_attach(dev, dsi); > + if (ret < 0) > + return dev_err_probe(dev, ret, "failed to attach dsi\n"); > + > + return 0; Return devm_mipi_dsi_attach() directly > +} > + > +static const struct of_device_id ili7807s_of_match[] = { > + { .compatible = "dlc,dlc0697", .data = &dlc0697_desc }, > + { } > +}; > +MODULE_DEVICE_TABLE(of, ili7807s_of_match); > + > +static struct mipi_dsi_driver ili7807s_dsi_driver = { > + .probe = ili7807s_probe, > + .driver = { > + .name = "panel-ilitek-ili7807s", > + .of_match_table = ili7807s_of_match, > + }, > +}; > +module_mipi_dsi_driver(ili7807s_dsi_driver); > + > +MODULE_AUTHOR("Arpit Saini "); > +MODULE_DESCRIPTION("Panel driver for Ilitek ILI7807S LCD DSI panel"); > +MODULE_LICENSE("GPL"); > Thanks, Neil