From: Hans de Goede <hdegoede@redhat.com>
To: "Crag Wang" <crag0715@gmail.com>,
mario.limonciello@amd.com, "Prasanth Ksr" <prasanth.ksr@dell.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: crag.wang@dell.com, Crag Wang <crag_wang@dell.com>,
Dell.Client.Kernel@dell.com, platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv4 1/1] platform/x86: dell-sysman: add support for alienware products
Date: Sun, 6 Oct 2024 12:45:48 +0200 [thread overview]
Message-ID: <a014ab86-0767-4ef7-805c-5250e239f4c8@redhat.com> (raw)
In-Reply-To: <8f45a215-1126-41c4-b4dd-92ad04ea5a8b@redhat.com>
Hi,
On 6-Oct-24 12:43 PM, Hans de Goede wrote:
> Hi,
>
> On 4-Oct-24 5:27 PM, Crag Wang wrote:
>> Alienware supports firmware-attributes and has its own OEM string.
>>
>> Signed-off-by: Crag Wang <crag_wang@dell.com>
>
> Thank you for your patch/series, I've applied this patch
> (series) to my review-hans branch:
> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
>
> Note it will show up in the pdx86 review-hans branch once I've
> pushed my local branch there, which might take a while.
>
> I will include this patch in my next fixes pull-req to Linus
> for the current kernel development cycle.
Running checkpatch after applying show:
WARNING: From:/Signed-off-by: email address mismatch: 'From: Crag Wang <crag0715@gmail.com>' != 'Signed-off-by: Crag Wang <crag_wang@dell.com>'
I have fixed this by running:
git commit --amend --author="Crag Wang <crag_wang@dell.com>"
So that things match now. Next time please try to use your Dell
email for submitting the patches instead of gmail.
Regards,
Hans
next prev parent reply other threads:[~2024-10-06 10:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 15:27 Crag Wang
2024-10-06 10:43 ` Hans de Goede
2024-10-06 10:45 ` Hans de Goede [this message]
2024-10-07 8:59 ` Ilpo Järvinen
2024-10-08 4:32 ` Ksr, Prasanth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a014ab86-0767-4ef7-805c-5250e239f4c8@redhat.com \
--to=hdegoede@redhat.com \
--cc=Dell.Client.Kernel@dell.com \
--cc=crag.wang@dell.com \
--cc=crag0715@gmail.com \
--cc=crag_wang@dell.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=prasanth.ksr@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome