From: "Håkon Løvdal" <hlovdal@gmail.com>
To: Matthew Garrett <mjg@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-scsi@vger.kernel.org,
James.Bottomley@hansenpartnership.com, shaohua.li@intel.com,
linux-ide@vger.kernel.org
Subject: Re: [PATCH 2/3] libata: Bind the Linux device tree to the ACPI device tree
Date: Thu, 6 Aug 2009 08:54:31 +0200 [thread overview]
Message-ID: <a01a16b50908052354h28522bafja255c4fcac9a2ea8@mail.gmail.com> (raw)
In-Reply-To: <1247518987-10818-2-git-send-email-mjg@redhat.com>
2009/7/13 Matthew Garrett <mjg@redhat.com>:
> + if (!sata_pmp_attached(ap))
> + adr = SATA_ADR(ap->port_no, NO_PORT_MULT);
> + else
> + adr = SATA_ADR(ap->port_no, dev->link->pmp);
Maybe I am missing something, but wouldn't it be more natural to write this as
if (sata_pmp_attached(ap))
adr = SATA_ADR(ap->port_no, dev->link->pmp);
else
adr = SATA_ADR(ap->port_no, NO_PORT_MULT);
BR Håkon Løvdal
next prev parent reply other threads:[~2009-08-06 6:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-13 21:03 [PATCH 1/3] SCSI: Allow platform-specific code to be run against the SCSI tree Matthew Garrett
2009-07-13 21:03 ` [PATCH 2/3] libata: Bind the Linux device tree to the ACPI device tree Matthew Garrett
2009-07-13 21:03 ` [PATCH 3/3] libata: Migrate ACPI code over to new bindings Matthew Garrett
2009-08-06 6:54 ` Håkon Løvdal [this message]
2009-08-06 14:51 ` [PATCH 2/3] libata: Bind the Linux device tree to the ACPI device tree Matthew Garrett
2009-08-10 13:38 ` [PATCH 1/3] SCSI: Allow platform-specific code to be run against the SCSI tree Matthew Garrett
2009-08-10 14:55 ` James Bottomley
2009-08-10 14:58 ` Matthew Garrett
2009-08-10 16:03 ` James Bottomley
2009-08-10 16:11 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a01a16b50908052354h28522bafja255c4fcac9a2ea8@mail.gmail.com \
--to=hlovdal@gmail.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®