From: Chengming Zhou <zhouchengming@bytedance.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: kernel test robot <lkp@intel.com>,
Johannes Weiner <hannes@cmpxchg.org>, Tejun Heo <tj@kernel.org>,
kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: Re: [peterz-queue:sched/psi 11/11] include/linux/cgroup-defs.h:432:38: error: 'NR_PSI_RESOURCES' undeclared here (not in a function)
Date: Wed, 7 Sep 2022 17:08:52 +0800 [thread overview]
Message-ID: <a0298563-bc74-65db-275e-94bd461e5bcd@bytedance.com> (raw)
In-Reply-To: <YxhQ7U0HggaWTmEm@hirez.programming.kicks-ass.net>
On 2022/9/7 16:06, Peter Zijlstra wrote:
> On Wed, Sep 07, 2022 at 10:45:55AM +0800, Chengming Zhou wrote:
>> On 2022/9/7 02:33, kernel test robot wrote:
>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/psi
>>> head: 51beb408c569e516780c84a2020920432ad4c5ed
>>> commit: 51beb408c569e516780c84a2020920432ad4c5ed [11/11] sched/psi: Per-cgroup PSI accounting disable/re-enable interface
>>> config: i386-randconfig-a001
>>> compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
>>> reproduce (this is a W=1 build):
>>> # https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?id=51beb408c569e516780c84a2020920432ad4c5ed
>>> git remote add peterz-queue https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git
>>> git fetch --no-tags peterz-queue sched/psi
>>> git checkout 51beb408c569e516780c84a2020920432ad4c5ed
>>> # save the config file
>>> mkdir build_dir && cp config build_dir/.config
>>> make W=1 O=build_dir ARCH=i386 prepare
>>>
>>> If you fix the issue, kindly add following tag where applicable
>>> Reported-by: kernel test robot <lkp@intel.com>
>>>
>>> All errors (new ones prefixed by >>):
>>>
>>> In file included from include/linux/cgroup.h:28,
>>> from include/linux/memcontrol.h:13,
>>> from include/linux/swap.h:9,
>>> from include/linux/suspend.h:5,
>>> from arch/x86/kernel/asm-offsets.c:13:
>>>>> include/linux/cgroup-defs.h:432:38: error: 'NR_PSI_RESOURCES' undeclared here (not in a function)
>>> 432 | struct cgroup_file psi_files[NR_PSI_RESOURCES];
>>
>> Sorry, looks like there are two problems here:
>>
>> 1. NR_PSI_RESOURCES is undeclared when !CONFIG_PSI
>>
>> Should I send the below diff as a separate patch?
>
> Please reply to the original patch with an updated version and I'll
> replace it.
Ok, I just sent. Thanks!
next prev parent reply other threads:[~2022-09-07 9:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 18:33 kernel test robot
2022-09-07 2:45 ` Chengming Zhou
2022-09-07 8:06 ` Peter Zijlstra
2022-09-07 9:08 ` Chengming Zhou [this message]
2022-09-07 15:28 ` Tejun Heo
2022-09-07 19:37 ` Peter Zijlstra
2022-09-07 19:38 ` Tejun Heo
2022-09-07 19:55 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0298563-bc74-65db-275e-94bd461e5bcd@bytedance.com \
--to=zhouchengming@bytedance.com \
--cc=hannes@cmpxchg.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=peterz@infradead.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®