From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 643B3C432BE for ; Fri, 30 Jul 2021 11:06:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4BE2C60FE7 for ; Fri, 30 Jul 2021 11:06:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238644AbhG3LGy (ORCPT ); Fri, 30 Jul 2021 07:06:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238602AbhG3LGx (ORCPT ); Fri, 30 Jul 2021 07:06:53 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA9AAC061765 for ; Fri, 30 Jul 2021 04:06:48 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id d8so10805174wrm.4 for ; Fri, 30 Jul 2021 04:06:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7cN7mCAd1PgSaOiwUYeJf080GlnYfimOBZ14rsMi0+0=; b=EIE2baSCXqVT4dVgY1Gguj0uDW2UV88MV3gEfeX1XFWqHh0DznHHGFa58B4wRUEMYh deqJ+oTinvP62Ow2Dv3/AVHnn5K535NV4oBCy9AvGSjg8XETNasDy2r8iaHpxePS0OHF KFp/upiTubTFSIlYPo9o7BY87UbFZDzUjPEHaeDm6edcyDvnCj2sGZL261EonUmJ4i2Y tdCy21VeTSDuf/9Z1GK/8MRairCaptF1pzQnn4obYRll0xYstlM0FcXL65gDBQx3Um5a FxikgGBu3MQ0aD+ykNY/WF55YtUFHzLsNHv9xfmStoEld6AgNt16sfeHnzOfySGjWBMt /TrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7cN7mCAd1PgSaOiwUYeJf080GlnYfimOBZ14rsMi0+0=; b=gmYdinohIaKzcbdxT5oH52QlF5bWaHfvmMPYKIf43aIwiujTXum5IC7doWIGFhe1CU UEPmuSPmLm6JYFwFMM9KlVcdwXFy7RbkheBS9aDpiJH/mTfON2MK16sebq8GB9vkaOHk L1F9CSiK2Az3u+bI22qgBHbv83ZoE2bZ5LDd/dYJn9BQxtl5G+saXF7ow0gqB7HmjcEQ aGF34CN3cP+n17aCEWsdyB6RaGJ7G3QKI2lcCYD++Av1h1yknR1NSyZ2Cn6ptoWsdJ7j VP/NIagLj/Nx6nm7ycfie0MEjLKRkekb8yTnW23+i4sAt9X4+SCJs76q0L1fagoovP52 k9IQ== X-Gm-Message-State: AOAM531IQYKeBr6YoDZh/B7anQY/K0+68cnEMnBuM7tjIwsS9sAKJ6aE N0C0vfHnL9duPM89mmteFDcrug== X-Google-Smtp-Source: ABdhPJwJg9Ja1mRbrDoc3k6Xo2NEMjyjUAiTl4lgkbRru8uTrdydvtGvqnfvahOos5jVuAw9eXwYqQ== X-Received: by 2002:a05:6000:1d0:: with SMTP id t16mr2382907wrx.213.1627643207487; Fri, 30 Jul 2021 04:06:47 -0700 (PDT) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id 6sm1486139wmi.3.2021.07.30.04.06.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Jul 2021 04:06:46 -0700 (PDT) Subject: Re: [PATCH v2 04/16] ASoC: qcom: dt-bindings: add bindings Audio Processing manager To: Mark Brown Cc: Rob Herring , bjorn.andersson@linaro.org, plai@codeaurora.org, tiwai@suse.de, devicetree@vger.kernel.org, perex@perex.cz, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, bgoswami@codeaurora.org References: <20210714153039.28373-1-srinivas.kandagatla@linaro.org> <20210714153039.28373-5-srinivas.kandagatla@linaro.org> <20210728173649.GA1290628@robh.at.kernel.org> <092018be-50ae-6dda-73cd-6c7eb002dc19@linaro.org> <20210729111338.GJ4670@sirena.org.uk> From: Srinivas Kandagatla Message-ID: Date: Fri, 30 Jul 2021 12:06:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210729111338.GJ4670@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks Mark for the review, On 29/07/2021 12:13, Mark Brown wrote: >>> This all looks fairly similar to the prior Qcom audio binding(s). It >>> would be nice to not see this all re-invented. >> AudioReach is a new DSP signal processing framework Which is different to >> its previous DSP firmware(aka Elite). >> It makes use of ASoC Topology to load audio graphs on to the DSP which is >> then managed by APM (Audio Processing Manager) service. >> So internals are not exactly same. >> From device tree side we might end up with similar layout, but there are >> some subtle differences like clocks are managed by q6prm service instead of >> q6afe service in old firmware, front-end pcm dais definitions come from ASoC >> topology. > The software we're running on the hardware shouldn't impact how the > hardware is described, it should be posible to switch DSP frameworks on > the same hardware - look at what Intel have done with SoF. I totally agree with you. There are two parts to the software running on the hardware, first is the hardware itself and second is the services that are running which control parts of hardware. Hardware device tree description across these new and old DSP framework are exactly same, However association between hardware and DSP service would change as per DSP framework services it exposes. Ex: clock controller would be associated with PRM(proxy resource manager) in AudioReach vs AFE (Audio Frontend Manager) in Elite, but the clocks and other hardware properties remain same across these. As exiting DT-bindings had both services and hardware description in same document which Is why I could not reuse it. I will try to split up the hardware parts and DSP services parts in the existing bindings so that we could reuse the hardware bindings across multiple dsp frameworks. It should also be possible to reuse some old code too in this process. --srini > >> Are you suggesting that we should reuse the old bindings (q6afe, q6asm) by >> add new compatible strings along with differences ?