From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B73DA18C26 for ; Mon, 20 Oct 2025 09:20:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760952005; cv=none; b=g1K9UrYvK6jbiwtgW7iRv5djJNyFlc0NQCSyZQg3fIGJEeIEnZLGHJXA7tP4TH6XiGc02wQqQ3jc/KbCytfMxm2JDYIPmZ4XdSFzZeW4Nw/4iZNNCDyUhlfjkHaMEGgGT7VXOEU0sQCmrN69OpFav/aWIve1AyhQPQj4Vp8ppS0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760952005; c=relaxed/simple; bh=iVDOlt8XyF/0gL57nFvuUrvv3rVY9GhGb/oEjhukzyw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pNCQnqf8dLikrMegJHE0B5mdj2hDk4Yyo/Y7ecnfvVBeY6jH80UeYW2TI0xiOT6MZGWNcvin3jCvL292IDah7KhoATCcEEXqRr5NnlYywUiYTF4LjXjeCC0rt9OuY79UCSD27WZe+/NmzeD5l8x/oYPdoukbM54r1ljsQcxFJaE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mF3rRDMQ; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mF3rRDMQ" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-471076f819bso32833715e9.3 for ; Mon, 20 Oct 2025 02:20:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760952002; x=1761556802; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0XCJmz4HW13zmCaIQ84NTp39kjqei0obsLTQVEkJ9Dg=; b=mF3rRDMQXSm7smo7UWNVZCkAehPKg9jizKJO6E9LLRlH+/aLfAkrAICg5bBp9XbI+r 5+AOUafKYfIOesscShW1dVhPeR0q+IvhHlxFv6hhIGKrv7gycWH0qeaWCMEzAWts+6++ s2L06QgbJGZwA08HnnY6Ua5Z6FJXRciE2T766SI128rokZBlOcAYUGpQQ+y84LeVtZmj RMuO6YLqksZ4VujsPIO/7EOpy6mPh1Q/v0Oq3VzMSyZ5Ul/S/kn+Mvl0Js4Y1fR+D7vm K4NXlFwFg7A5Od9N+eGfpLcfnxmlKTFQi51LFqbmDO5TFKNGL3MSdjZfkaGQwsk+1o1i S5YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760952002; x=1761556802; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0XCJmz4HW13zmCaIQ84NTp39kjqei0obsLTQVEkJ9Dg=; b=lNKKkB6OAZmTkKWhXPllDZnqL+FJinV+o80gEb7/jB1BCdi6uf6HdQdvNZiSoOVdhr ro6lMmBI+XT3urzGIGe5FWtVQEvxVKJFEJrDngN6Q6+csPXIMntog4BFLhGhoCM//3yZ 23UKodyAJM11Qm4gbzG5Gb+9Goig3Nm7uC2WlOB6XgosCVw0Ad4kKAIXKwQIldC1NK6H UHfwUratVqIm6evKthvpGo7c+qDBpTkH9az5GDgJKGlb0qcV1RantoRlks8oFdlCZ17S T7qBHmg13sPmEtNdCxAiA84x3mQUamFWgYAPNLyTgDP9W1CtjzBsuK1nlQDJIdzMidyd yaLg== X-Gm-Message-State: AOJu0Yzoo3YSp4xQaTEo+TTxx3ogEvNHN9tYy7pCFyblFNvr8ShEU2wQ FuIqLyXzFh3o+WXaCP2j9OXOTnm8CtmYeWb4ASn3TXW8Nj1wtyS7jLege4FNc9Dg8gw= X-Gm-Gg: ASbGncu8ILrmy1YOo3R9DmveRRspjyMPvdsk2a0ey7xoUxIDWnsqOaK3FpJ7ryHLRN+ kgzoTCniplOz8xkEg/PCjfeZZaO5zMgVmc1ugwrZQ3vEV+ZUNz5eBi45x9efAFy5u/7zVBDRPSw DcJCom54HDf7xpOPkeXW96kvs1gzoKSR448w14b8ffyLbqGVrA6NMNpwCRmAY/SwNV5VDqPeKwn 3FTYyys3qX+RyRpOzNOAVsHCCeAAunTyeoQdo5J5zlNvdWhIf5yxhfGmv5c6ewtYPvQn4fLLfq5 6RU8lsFMgeT11jUvmBDctzSku6UjxaUF1PFBBEoubCiaGAWobWNFG4yJOQu90cBSOiPgMj7L38A KBJ+ejLswe7vnD0Jm0nMCdZB/aqu3Y2sqH+I0fNcbsCgnxWnceqI/Kz7qVENAQvpALexksuNxfS pWafNLJhoEuTBdV3yAn9w= X-Google-Smtp-Source: AGHT+IHDfUmNi5eqw691/M33t81cdCOV6g/HJdfYKSgYwXlWSNi3vurpVr1BkRRnhjmGHUqYcBuwxw== X-Received: by 2002:a05:6000:4008:b0:428:3bf5:b3b8 with SMTP id ffacd0b85a97d-4283bf5b655mr5592745f8f.44.1760952002139; Mon, 20 Oct 2025 02:20:02 -0700 (PDT) Received: from [10.11.12.107] ([79.115.63.145]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-427f00ce3e2sm14354917f8f.47.2025.10.20.02.20.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Oct 2025 02:20:01 -0700 (PDT) Message-ID: Date: Mon, 20 Oct 2025 10:19:59 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 4/6] clk: samsung: add Exynos ACPM clock driver To: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Griffin , =?UTF-8?Q?Andr=C3=A9_Draszik?= , Michael Turquette , Stephen Boyd , Alim Akhtar , Sylwester Nawrocki , Chanwoo Choi , Catalin Marinas , Will Deacon Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, willmcvicker@google.com, kernel-team@android.com References: <20251010-acpm-clk-v6-0-321ee8826fd4@linaro.org> <20251010-acpm-clk-v6-4-321ee8826fd4@linaro.org> <92f1c027-bacc-4537-a158-2e0890e2e8ee@kernel.org> <17695fcf-f33c-4246-8d5c-b2120e9e03b1@linaro.org> <2f8da425-63d9-4321-9cd3-976bbd29a52f@kernel.org> Content-Language: en-US From: Tudor Ambarus In-Reply-To: <2f8da425-63d9-4321-9cd3-976bbd29a52f@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/20/25 9:22 AM, Krzysztof Kozlowski wrote: > On 20/10/2025 09:45, Tudor Ambarus wrote: >> >> >> On 10/20/25 7:54 AM, Krzysztof Kozlowski wrote: >>>> diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfig >>>> index 76a494e95027af26272e30876a87ac293bd56dfa..70a8b82a0136b4d0213d8ff95e029c52436e5c7f 100644 >>>> --- a/drivers/clk/samsung/Kconfig >>>> +++ b/drivers/clk/samsung/Kconfig >>>> @@ -95,6 +95,16 @@ config EXYNOS_CLKOUT >>>> status of the certains clocks from SoC, but it could also be tied to >>>> other devices as an input clock. >>>> >>>> +config EXYNOS_ACPM_CLK >>>> + tristate "Clock driver controlled via ACPM interface" >>>> + depends on EXYNOS_ACPM_PROTOCOL || (COMPILE_TEST && !EXYNOS_ACPM_PROTOCOL) >>> >>> I merged the patches but I don't get why we are not enabling it by >>> default, just like every other clock driver. What is so special here? >> >> Thanks! Are you referring to the depends on line? I needed it otherwise >> on randconfigs where COMPILE_TEST=y and EXYNOS_ACPM_PROTOCOL=n I get: > > > No. I am referring to missing default and defconfig patch. > default m or y would force compilation of EXYNOS_ACPM_CLK and EXYNOS_ACPM_PROTOCOL for all ARCH_EXYNOS, even on Exynos platforms that don't use ACPM. Since ACPM is not universally required by the Exynos architecture, I thought to make it opt-in (default n). Setting it as a module in arm64 defconfig makes it available on compatible platforms. Similar clock drivers do the same: CLK_RASPBERRYPI. COMMON_CLK_SCPI, COMMON_CLK_SCMI - no defaults and set them as builtin in the arm64 defconfig. Cheers, ta