From: Christian Loehle <christian.loehle@arm.com>
To: Benjamin Tang <tangsong8264@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Juri Lelli <juri.lelli@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC/PATCH] sched/fair: Remove unnecessary judgment in pick_next_task_fair()
Date: Mon, 9 Sep 2024 12:26:29 +0100 [thread overview]
Message-ID: <a04070a1-39d5-4362-a28c-39b9b910eaac@arm.com> (raw)
In-Reply-To: <3d9e48ab-869e-4633-8874-b2899c8cc8ce@gmail.com>
On 9/9/24 06:13, Benjamin Tang wrote:
> sched/fair: Remove unnecessary judgment in pick_next_task_fair()
>
> Since 'curr' argument is no longer needed in pick_next_entity(),
> remove unnecessary judgment.
>
> Signed-off-by: Benjamin Tang <tangsong8264@gmail.com>
> ---
> kernel/sched/fair.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 9057584ec06d..92f8ad778205 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -8492,8 +8492,6 @@ pick_next_task_fair(struct rq *rq, struct task_struct *prev, struct rq_flags *rf
> if (curr) {
> if (curr->on_rq)
> update_curr(cfs_rq);
> - else
> - curr = NULL;
>
> /*
> * This call to check_cfs_rq_runtime() will do the
This has been reworked on tip/sched/core and is no longer needed:
[PATCH 05/24] sched/fair: Unify pick_{,next_}_task_fair()
https://lore.kernel.org/all/20240727105028.725062368@infradead.org/
prev parent reply other threads:[~2024-09-09 11:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 5:13 Benjamin Tang
2024-09-09 11:26 ` Christian Loehle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a04070a1-39d5-4362-a28c-39b9b910eaac@arm.com \
--to=christian.loehle@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tangsong8264@gmail.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®