From: Pasha Tatashin <pasha.tatashin@oracle.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, mingo@redhat.com,
peterz@infradead.org, hpa@zytor.com, douly.fnst@cn.fujitsu.com
Subject: Re: [PATCH v5 1/2] sched/clock: interface to allow timestamps early in boot
Date: Mon, 28 Aug 2017 13:59:29 -0400 [thread overview]
Message-ID: <a0487461-3344-6a5d-281e-087e13f0c60b@oracle.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1708281701590.1867@nanos>
>> void __init timekeeping_init(void)
>> {
>> /*
>> * We must determine boot timestamp before getting current
>> * persistent clock value, because implementation of
>> * read_boot_clock64() might also call the persistent
>> * clock, and a leap second may occur.
>> */
>>
>> read_boot_clock64(&boot);
>> ...
>> read_persistent_clock64(&now);
>
> No. That's the same crap just the other way round.
>
> s390 can do that, because the boot timestamp is correlated with the
> persistent clock. Your's not so much.
>
OK, how about reading the persistent clock only once, and send it's
value to use for calculation of boot stamp to read_boot_clock64() via a
new argument:
read_boot_clock64(&now, &boot);
Does this sound alright or is there a better way?
I would need to update read_boot_clock64() everywhere it is declared to
add the __init macro, so this extra argument is not going to increase
number of line changes.
Thank you,
Pasha
next prev parent reply other threads:[~2017-08-28 18:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 20:41 [PATCH v5 0/2] Early boot time stamps for x86 Pavel Tatashin
2017-08-23 20:41 ` [PATCH v5 1/2] sched/clock: interface to allow timestamps early in boot Pavel Tatashin
2017-08-25 22:54 ` Thomas Gleixner
2017-08-28 14:17 ` Pasha Tatashin
2017-08-28 15:13 ` Thomas Gleixner
2017-08-28 17:59 ` Pasha Tatashin [this message]
2017-08-28 15:15 ` Thomas Gleixner
2017-08-28 17:47 ` Pasha Tatashin
2017-08-23 20:41 ` [PATCH v5 2/2] x86/tsc: use tsc early Pavel Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0487461-3344-6a5d-281e-087e13f0c60b@oracle.com \
--to=pasha.tatashin@oracle.com \
--cc=douly.fnst@cn.fujitsu.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®