From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758621AbcH3UdV (ORCPT ); Tue, 30 Aug 2016 16:33:21 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:36333 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752054AbcH3UdQ (ORCPT ); Tue, 30 Aug 2016 16:33:16 -0400 Date: Wed, 31 Aug 2016 02:03:12 +0530 From: Bhaktipriya Shridhar To: David Howells Cc: linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, Tejun Heo Subject: [PATCH v2 2/4] fs/afs/rxrpc: Remove deprecated create_singlethread_workqueue Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The workqueue "afs_async_calls" queues a single work item viz &call->async_work and hence it doesn't require execution ordering. Hence, alloc_workqueue has been used to replace the deprecated create_singlethread_workqueue instance. The WQ_MEM_RECLAIM flag has been set to ensure forward progress under memory pressure because the workqueue is being used on a memory reclaim path. Since there are fixed number of work items, explicit concurrency limit is unnecessary here. Signed-off-by: Bhaktipriya Shridhar --- Changes in v2: -No change fs/afs/rxrpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/afs/rxrpc.c b/fs/afs/rxrpc.c index 63cd9f9..4f9e9b3 100644 --- a/fs/afs/rxrpc.c +++ b/fs/afs/rxrpc.c @@ -85,7 +85,7 @@ int afs_open_socket(void) skb_queue_head_init(&afs_incoming_calls); - afs_async_calls = create_singlethread_workqueue("kafsd"); + afs_async_calls = alloc_workqueue("kafsd", WQ_MEM_RECLAIM, 0); if (!afs_async_calls) { _leave(" = -ENOMEM [wq]"); return -ENOMEM; -- 2.1.4