From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E98743F327A for ; Tue, 28 Jul 2026 13:15:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785244551; cv=none; b=P/Q+15S1+4UJDhiwKiFbM4n7oNgekT6FwC0fBA65QdpPEbwTtSg0H99mEQkndXJ7az5sHV2+OA19gAkmGLCqreVDb3yyFlgok2Tp0nhbVW/i5HCmUTR9YtdoEJQ9UBQPBSFmiVOgrpPF2LQUS/rrMsC+dFwVoGdM6Tp1YacyV6A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785244551; c=relaxed/simple; bh=00q0aNwdmOg6Et5qu0O52+EkBuplSsck0mqjSRMWME8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Cw32ZZaohNIRfnk8U5xGypo6MDY5BzkV8VNhlvQ7+GcqWYKzO5LkScc8yH50YfDxbb57L1k1ycUITB3Pjidp+jBIb33HHENTGSYzDN0Mq4gtnWwAypgVnRey5gASB1qYOElSHZeiZpakdiYJgqgkXDv+rl2MTQOWXrqZDfEpAzc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Zcr4a0XM; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Zcr4a0XM" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-c197e7e4e94so654011266b.2 for ; Tue, 28 Jul 2026 06:15:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1785244548; x=1785849348; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=OdVxKmahjOeWv4mCr7IV2pAwr1j5bRzwVh+tCNucKsc=; b=Zcr4a0XMrcFa9rAmpfK1dkdHKxcMPISArrmEGC5lbiZzrOTVE5Vhftotewk1UbgTrM GvFBlA0QY1L693rflRbQqs2XfEXB4fyLlPcaAsmEasb0jRzU367NqRmcTCt+qOw2uxOH 9Te/t4eZVNnA23iNLeHpaMg7bv4pDOlqNz4Bya5h0x9S4Ro7HEVJRCHyJhdfvUHLUooh QoRqUCP50brydGU3674MZQtwTewyAUbI2MJd8x+KwPQetQiLfTsB7+isOaOJIvYciBBz AOwbMimeqkY4C/SdZTu1pMH68fAHHJEeKVwLbSEgruIUnTeCSBaZ/TxEvmDqEGMMbOb6 STPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785244548; x=1785849348; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OdVxKmahjOeWv4mCr7IV2pAwr1j5bRzwVh+tCNucKsc=; b=CqZ1FoBteDV3EvVtf+wSnq/fxDaD3QZ3Rj4yNH+bJbdUXO80wPk//tyD+zI8nmnSoY UpbgqF1+N6FNK0706i0/+z5iQF/FJPTPNaa8NG/hscctelvfOVFe98D22pbdYkykx76i j3lj9We/qr+vHbIAyqaPdPiS/vtJEoUKUoqYedCklzR7WT7C+CRynoKL98SDteyEO/tz x6hZ+qMtSRnrRlVH84hw8wZrafvGmCn9sd+I2Rdv79v7TVi/ta6g9r7db6woiWGwzlgO t1zo8GfL1SJ5w/zQbY9jkcFuhIJ8Yns7EIxWXbU2aBs0zGmXmb6lMfOPqsHeiiuz6q/f twLQ== X-Forwarded-Encrypted: i=1; AHgh+RqJPBAxmt0l/aFgAmix3jTi6oereoXBSQSzI1lWK1ndgKCvUTOvUu/L6Q48KF/SES5clokonhDrnAQ2C6A=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1ZtHcdammUxwLoe41eQNwTIjAFiMGgrLjbcgvYHKqEcJFJVga dCuNmjGHf5j4gkyOP5G6yOquaTvV7jBpKY5KJNFQUaEjYDoF11FTeF4JhbaOwNQp5MU= X-Gm-Gg: AR+sD12dt7A7T/dtZrEqpl0ngywXTS3lGYHKf2y5OZ1RWM+mEgBktArF4P1131TfXHQ PvbERl5F+1LQ0d7Ngs0gFdL3vqywVvGooqUUZQI87RRythcwkyD/gsb4cfZlFrN9g2kNg5qyIK+ GRCG3o5EdOqgUnKZYG/c14FqybicmPmW7iXbjb+qbRmyixA1LNzHgUION8oRzbndaKkfEi1rxlR eC+QO5z8iHkpSZhTqEaSveJIl73hzAN6nBxOKHpbrP2OGdAGTQ/3rGjuU7cT65ye6mvbDpPtIxo mZSvlxDXJq2YjU6vAqWf5GVS9flRP18JkId4PuCWD8z8OF6w5YlpM2tDCNoS4hs4QHdZskgpQGT j848kMGm+7JDGzuK+5AwMpdzmI2SLCDAmO39zSROHJEN2n5ZgqDuRhkIthKSeFOkGrsWsnTGdTA vYLtL0CzkgNSeWVQ== X-Received: by 2002:a17:907:1c2a:b0:c12:6d25:2c7a with SMTP id a640c23a62f3a-c1f71eb0390mr110717066b.17.1785244548180; Tue, 28 Jul 2026 06:15:48 -0700 (PDT) Received: from [192.168.0.101] ([109.77.204.94]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1c32ebb385sm767508666b.52.2026.07.28.06.15.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Jul 2026 06:15:47 -0700 (PDT) Message-ID: Date: Tue, 28 Jul 2026 14:15:46 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] media: qcom: iris: initialize OPP pointer at declaration To: Hungyu Lin , vikash.garodia@oss.qualcomm.com, dikshita.agarwal@oss.qualcomm.com, mchehab@kernel.org, linux-media@vger.kernel.org Cc: abhinav.kumar@linux.dev, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dmitry.baryshkov@linaro.org References: <20260608120531.83459-1-dennylin0707@gmail.com> From: Bryan O'Donoghue Content-Language: en-GB In-Reply-To: <20260608120531.83459-1-dennylin0707@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 08/06/2026 13:05, Hungyu Lin wrote: > Initialize the managed OPP pointer at declaration rather than > assigning it in a separate statement. > > This avoids a checkpatch warning about a potentially uninitialized > managed pointer. > > Signed-off-by: Hungyu Lin > --- > Changes in v2: > - Initialize the managed pointer directly at declaration as suggested > by Dmitry Baryshkov. > > drivers/media/platform/qcom/iris/iris_resources.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_resources.c b/drivers/media/platform/qcom/iris/iris_resources.c > index 773f6548370a..fd643cbff8d2 100644 > --- a/drivers/media/platform/qcom/iris/iris_resources.c > +++ b/drivers/media/platform/qcom/iris/iris_resources.c > @@ -61,9 +61,9 @@ int iris_unset_icc_bw(struct iris_core *core) > > int iris_opp_set_rate(struct device *dev, unsigned long freq) > { > - struct dev_pm_opp *opp __free(put_opp); > + struct dev_pm_opp *opp __free(put_opp) = > + devfreq_recommended_opp(dev, &freq, 0); > > - opp = devfreq_recommended_opp(dev, &freq, 0); > if (IS_ERR(opp)) > return PTR_ERR(opp); > > -- > 2.34.1 > Reviewed-by: Bryan O'Donoghue