From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13C4F42A7B2 for ; Tue, 7 Jul 2026 07:23:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783409023; cv=none; b=ThPZw4JouVVEpZ3cZHY6PxaDt/qAZ3sdEje/yDOUDndH/MX2Nr/BkjACq3oPvOLNeW7xcpA/XPcnMx4JOR1ivZespZJteBUbMFJMS1GnoFThjY5OGK9KKAE+ClW85rls+i07UDuL3TPljUzuYw2QYsuDmCoGgDUE/4IWNXjpqGg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783409023; c=relaxed/simple; bh=H5uZDARIoPVu0+cgA55LNxyWBPEvQr0/tBGPw/Dmoy8=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=c29zShDCEaGbMbKKWqIgsu/ingoMhS3b+o0dGz0oN2VPhW1pWuDfg9HxpSihK/N7Lb3zLuxuf91f0QcFmcrL2zRZ/9h/Rryti+i59Oimt+WlspU4lzyUKnlHzee3/2N98Q/JeP1sHmtJL1tzPZ/M40cHPdkGNQ7ZK4/kFUJBq8o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Bw8GC0ZO; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=VCPysGx/; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Bw8GC0ZO"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="VCPysGx/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783409016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=H5uZDARIoPVu0+cgA55LNxyWBPEvQr0/tBGPw/Dmoy8=; b=Bw8GC0ZOSEL+AuudOFkZbDd8SFkr3g79x8A15OkTpJtPErnBah6bnjCl0u8XiofIpFHhb1 uOtsWBGcHMEj5J/sD4bXEULpbKdeS27ztuJK8dh/L9KaICjpZxMm/i7JrYF3c37ykvnMUT sJPD/I95gBlHdEd4UhdGZR/YZknzWM0= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-633-j8ewJvlENbm5WCTUUXKaXA-1; Tue, 07 Jul 2026 03:23:35 -0400 X-MC-Unique: j8ewJvlENbm5WCTUUXKaXA-1 X-Mimecast-MFC-AGG-ID: j8ewJvlENbm5WCTUUXKaXA_1783409014 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-4731a357b0aso3422687f8f.2 for ; Tue, 07 Jul 2026 00:23:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783409014; x=1784013814; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :autocrypt:references:in-reply-to:date:cc:to:from:subject:message-id :from:to:cc:subject:date:message-id:reply-to:content-type; bh=H5uZDARIoPVu0+cgA55LNxyWBPEvQr0/tBGPw/Dmoy8=; b=VCPysGx/WN468W/96UQ5Z4BZn5CnnDE+0p35iaVEqJU07W2Rwt4jc2NjT2l1o3phyu WgAtDj/rCC8OnGiqvGBmFLxSF3sBac//eV0cFgqYC7DO/sUhByh0FbGfWkF/LFX/FSuY Y3CsZM/EWJ27aS9P51IuzkjNacK+byx6rj932KPGEGPN5TI+8+R/ZvY9h6j/60uX2evM sjU84mgldr5Sx+IstOFtukxtFTigt0vWbmcvMbaZwKUlQw7kBblbaWC8R+YgtTh9Rp6p etmFKxG0nNQ71GM2u9a8Iw/KeyvTEnmP107NoT/tPKDoA2du9QeFaWAD/vNkMAxIBkAb lgdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783409014; x=1784013814; h=mime-version:user-agent:content-transfer-encoding:content-type :autocrypt:references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=H5uZDARIoPVu0+cgA55LNxyWBPEvQr0/tBGPw/Dmoy8=; b=ige01PghNztTVICrOfv1MLzXMSf7UPmjAxVKz26kJj0eIrDzC3QSdRTEA35+fZzCrZ NzTWsulKoxg5ocuCluftCXYxdwpskPIwWs28WNoOQ6XWDt5KJ5aZU37pqsQOaGhUoH1X TgSllAMY3XGZAxEXi44tZaS0eL7W4xu52Dx754hwcSDuYzGl2O4BcLTndZpaORblNMTM WF4Sc1sQM/CX39s7TJ3Fk60+PhD+UtFnelMHqilGFe/O3DLvy+2gMS2pVIEIH8vzl3UR vKuD+Z2YO8EiqjSXb+xpyIKcG+tfjka4JOVTe+Z2WMvOcU+kv1uBTBp89z9C/33EV0h2 WCkw== X-Forwarded-Encrypted: i=1; AHgh+RrUti/qhEp/pSYIDPdCUvvlY2+feKIRYPRp9KvR8bOSzCeq40Izzv5AJjWPXPnGV+1s+KXPFhqtUZMXNI0=@vger.kernel.org X-Gm-Message-State: AOJu0YxqpZ9nTcs1QgByl0TrlmWcZESFl8SeaHd3TWQsIl93UXa9LcT2 rNx6CUyw9XbwVXsPq3r1SHdsBELKdMATmg0ACVmuY5MnUZUh0f/HjebMTvoIAqH6QvJAd7dL38b zQoabwxVnnvK1E/TQCpP5+Xvi/rcRlfnsFgi9+m8kTG9RyFwjveFBz79N4xox2erOXuF+UREl98 rG X-Gm-Gg: AfdE7clrJbyM6Tqv0reA/BjJe5EzeQQLgPgsrmqizsBU4qFkUjb/FZrV/WsiZZy5GRP bwCQzBDZOYtPCvU9M1jk+0HZfhsbkY8UZDVWfbaoEb4ycbBPsnLMLnk9CzUNhz3QIp9a0N1/wmX dGCR2Cz5AXfeb10ultZGziooJWYWjhZNA6AFpw6im2dGDGVV2gT95pjRVnEibpLvfcCcBuH5yZ/ ZGB4VQHvzbNauAZxdnD2vV5N4DbCmhIkvWWPqwPUkR5q6MGjmnz5/9l0iie+L46Ys4YAqM1ARJ+ Y1E32CrJgqn36n+VSpC5HqXhGquRMxZ6xzTS0qnccx9nb3PxiZiqxFxH8nPW63qUUuARAiVZtFr LYnGocM8tQidIeWpSfHs0lcCFYZJmehoI1XHt38T7V4e0b+GzPF/4bfdgRg2bTY2EhlJWtX2YLP ytXe+2 X-Received: by 2002:a5d:54c7:0:b0:470:2fb1:3db5 with SMTP id ffacd0b85a97d-47de66d30fcmr3131789f8f.30.1783409014303; Tue, 07 Jul 2026 00:23:34 -0700 (PDT) X-Received: by 2002:a5d:54c7:0:b0:470:2fb1:3db5 with SMTP id ffacd0b85a97d-47de66d30fcmr3131699f8f.30.1783409013195; Tue, 07 Jul 2026 00:23:33 -0700 (PDT) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (212-8-243-115.hosted-by-worldstream.net. [212.8.243.115]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47a9e4d780csm32483402f8f.11.2026.07.07.00.23.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 00:23:32 -0700 (PDT) Message-ID: Subject: Re: [PATCH v3 11/17] rv: Prevent unintentional tracepoints during KUnit tests From: Gabriele Monaco To: Nam Cao , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Thomas Weissschuh , Tomas Glozar , John Kacur , Wen Yang , Steven Rostedt , Masami Hiramatsu Date: Tue, 07 Jul 2026 09:23:31 +0200 In-Reply-To: <878q7n2six.fsf@yellow.woof> References: <20260625121440.116317-1-gmonaco@redhat.com> <20260625121440.116317-12-gmonaco@redhat.com> <878q7n2six.fsf@yellow.woof> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.2 (3.60.2-1.fc44) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2026-07-07 at 09:00 +0200, Nam Cao wrote: > Gabriele Monaco writes: > > Monitor initialisation also called during KUnit tests may register some > > tracepoints, this can lead to issues since we don't expect real monitor > > events running during KUnit tests. > >=20 > > Prevent tracepoint registration if an RV KUnit test is running. > >=20 > > Reviewed-by: Nam Cao > > Signed-off-by: Gabriele Monaco >=20 > Somehow I have no recollection of seeing this patch. Well, I'm fairly sure you reviewed it ;) > But since we already hold rv_interface_lock during the test, is this > really necessary? This is for things like ltl_monitor_init() that attaches the newtask probe. The function is also doing a few other things we may not want to do, to be = fair, but calling the monitor_init() function as-is was the easiest solution I co= uld think of. Also ha_monitor_init() may attach a probe. I suppose I could also do some more targeted initialisation/destruction, in= fact right now, the LTL initialisation does a bunch of stuff tests don't need an= d doesn't do what they do need (initialise the dummy tasks, which aren't part= of the task list). I should probably rethink this a little. Thanks, Gabriele