From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753230AbdJLOnt (ORCPT ); Thu, 12 Oct 2017 10:43:49 -0400 Received: from esa8.dell-outbound.iphmx.com ([68.232.149.218]:17208 "EHLO esa8.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752340AbdJLOnr (ORCPT ); Thu, 12 Oct 2017 10:43:47 -0400 From: X-LoopCount0: from 10.166.132.198 X-IronPort-AV: E=Sophos;i="5.43,366,1503378000"; d="scan'208";a="72685020" X-DLP: DLP_GlobalPCIDSS To: CC: , , , , , , , , , , Subject: RE: [PATCH v7 10/15] platform/x86: dell-smbios: add filtering capability for requests Thread-Topic: [PATCH v7 10/15] platform/x86: dell-smbios: add filtering capability for requests Thread-Index: AQHTQ0IniRM7rrgYDka8Ai0Uoa3NM6LgKlSggABxJID//6yg8A== Date: Thu, 12 Oct 2017 14:43:45 +0000 Message-ID: References: <83dc225624f1cde5ee1797aebc945732444ded91.1507733291.git.mario.limonciello@dell.com> <20171012110903.3ab4ed5e@alans-desktop> <1200feb837864baa8a3be9740413f2e9@ausx13mpc120.AMER.DELL.COM> <20171012143335.bbw3cxojzp66nqi2@pali> In-Reply-To: <20171012143335.bbw3cxojzp66nqi2@pali> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.18.86] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v9CEhqPb012179 > -----Original Message----- > From: Pali Rohár [mailto:pali.rohar@gmail.com] > Sent: Thursday, October 12, 2017 9:34 AM > To: Limonciello, Mario > Cc: gnomes@lxorguk.ukuu.org.uk; dvhart@infradead.org; > andy.shevchenko@gmail.com; linux-kernel@vger.kernel.org; platform-driver- > x86@vger.kernel.org; luto@kernel.org; quasisec@google.com; > rjw@rjwysocki.net; mjg59@google.com; hch@lst.de; greg@kroah.com > Subject: Re: [PATCH v7 10/15] platform/x86: dell-smbios: add filtering capability > for requests > > On Thursday 12 October 2017 13:23:08 Mario.Limonciello@dell.com wrote: > > The existing dcdbas calling interface tooling (libsmbios) expects to be able > > to access all calls and all tokens. *The kernel doesn't filter any of it.* > > It does not mean that API/ABI was designed correctly or incorrectly. > Existing old API/ABI is there and we are not going to change it... > > > I understand the ask to filter some calls and that's why patch 10/15 exists, > > but please let me remind you this patch series is intended to /replace and > > deprecate/ dcdbas userspace access. > > Now when there is a proposal for a new API/ABI, it should be designed > correctly without need to redesign it again in future and address all > problems which are found during review. > Well sure I also would hate to have to redesign this again in the future. I believe that this is sufficient now. I'm looking up commands that FW claims can be supported and filtering the rest. There's your whitelist. I addressed the concern on the perceived dangerous calls (write once, debugging, manufacturing use only etc) and those are now filtered. There's your blacklist. Other than the minor errors that kbuild test robot caught from v6 and the s/desc_buffer/buffer/ in an earlier patch, what's left?