From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B51C0155359 for ; Wed, 18 Dec 2024 00:02:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734480173; cv=none; b=ng6ZAXfWnCUW1pt+nfV1K1RGJZMG3Zzk6ZwJGggP3uDyvW4EbUDI0Vy8ru2uZqC3oqWpBNqphWC5EdqVr9hjQSJU8FAQY6IgO+MjsvbeSkYDW6REInakZODbvf+7WdbIZE63TwSNDtYGvCjQmMf2d2h7jvGqsIZkCEB/rT4ZtwY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734480173; c=relaxed/simple; bh=lt8ky7ZpF/9dqaloG1UpQK25UoXzGUgtBgmV5QUauvM=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=R+QH/o78jbkHc+mvxLWgXFWbXXXQ7M2lxfWNo7p4Gt+OsDgqbaOLY6YfmIrgwPa4GyX7qwe6OgnLGVhmbdYQQeqo9dNb6ejrOaOaVn8nyQYix7keNb3WUrOHVUWwwuRoncSB7kbpabk5u9UjiLCB3GTQ3nciDhMdI6at5HTbmV4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fT2F0GFm; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fT2F0GFm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734480170; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j077zAEFv1KDTZ4emlDdtZv2eMWpxvsnBzeSJzo3REo=; b=fT2F0GFm/AG1+EK3N/goBFOCCUcQYhEBEFyx0hBlwUJwdysbCNy/89DicQ2IRh2RQlxO70 B3R7+jddaImNlQyuqiESAMdCXt6mPitKf5Z8l09pE8rhxyhmbMKnq0Hgz/DByEyCZZ7Mr+ vqmifA57qP95PqZvyOb+rPvFWFD6ouo= Received: from mail-il1-f199.google.com (mail-il1-f199.google.com [209.85.166.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-489-PtzSN21pPuCdGRCXe9817w-1; Tue, 17 Dec 2024 19:02:49 -0500 X-MC-Unique: PtzSN21pPuCdGRCXe9817w-1 X-Mimecast-MFC-AGG-ID: PtzSN21pPuCdGRCXe9817w Received: by mail-il1-f199.google.com with SMTP id e9e14a558f8ab-3a7d85ab308so56187155ab.3 for ; Tue, 17 Dec 2024 16:02:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734480169; x=1735084969; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=j077zAEFv1KDTZ4emlDdtZv2eMWpxvsnBzeSJzo3REo=; b=gotZE+8Hirp5/e6LrBWyQxx6+aPoSIgi0r7zU4sIZG0phmBPHXK0799tjJu0G2VJ04 co5uMsBs/wXyi20WwqybX3chm84XiPP5OL9F9sy09DKdeiPQ5Ku9JD7Rv8HrGfV8EEAk WP8iEK26EmAbRYO1+Ih9YuxnGM0+ppp7LniXD1QOEeZdVrMUGGbSlUOA8met5LUwan6W 8jv2WEVR842epp0oQ8KRNf1GkXRTkdIQoz0+WlBxX38gi4tD3+q426yI9Xz1542db9bN MDSvdLVoyCypUUYhCGrLgxOtAiV+h9pdcIGPfMFgqWllMcC2O3o70ZAIHg3YyT3b/B1/ kGMA== X-Forwarded-Encrypted: i=1; AJvYcCXkHTa5KgETJ/EFkqXtlTHAGU3RA+N1xrdNaZjq7uf0vb89MOclTWlCwbuz3sEtu6eZWngvQJOkEJ7FqsA=@vger.kernel.org X-Gm-Message-State: AOJu0YxD0XPHnDMsaJneQyEfIT9J0WWLsAJBQk9CPvBhFDuHo6vSaHuz 2nxZy5DqkHODPHLvvRd8ttX4pUJHOGyEQTaUsng2CDWNgm/2xRv9gN30dAvipzyfZK3lI18OMHC xE6yOHGKFjfrUvrRJjuNo2N6W581EsZE2pYt5uBGVAyd7KdiHvvAeZ0dgXGWeiQ== X-Gm-Gg: ASbGncs0wnlbDGbxqWZE4vu49OQlImnYgLUfqvWd14nnQAWvqD44EQVESzs2+4g8uzO bhAQKI333zrG/25M1oXEb5eeBKZJDqKN9pnNsg8nZ1Jh0hY2skUPTj3A59pG0eZVHnNmAeJ0P+t i1zDyhMY4D/ht+jmq3X4oOu3ynq5CASot1a3ZLbKGzWrOpLaNVEKMmbWrxL5ytdJ+vBiw7WB68g 1+UiqZl8P2s9GOAbGWJ1Y8jEdxP8RQvoW4a6R6LaDsGWJp4utVVQJrC X-Received: by 2002:a05:6e02:164b:b0:3a7:7558:a6ea with SMTP id e9e14a558f8ab-3bdc0bc8239mr10812335ab.10.1734480169091; Tue, 17 Dec 2024 16:02:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IF+W4SQfKhd60InvRuUqmwBd/RmkWU7jcD4h5PXX3dL7NWINYO2eCqr5SyBs0dBuyYO1fy8cg== X-Received: by 2002:a05:6e02:164b:b0:3a7:7558:a6ea with SMTP id e9e14a558f8ab-3bdc0bc8239mr10812065ab.10.1734480168811; Tue, 17 Dec 2024 16:02:48 -0800 (PST) Received: from starship ([2607:fea8:fc01:8d8d:6adb:55ff:feaa:b156]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4e5e0a3de9bsm1929513173.50.2024.12.17.16.02.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2024 16:02:48 -0800 (PST) Message-ID: Subject: Re: [PATCH 15/20] KVM: sefltests: Verify value of dirty_log_test last page isn't bogus From: Maxim Levitsky To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Xu Date: Tue, 17 Dec 2024 19:02:47 -0500 In-Reply-To: <20241214010721.2356923-16-seanjc@google.com> References: <20241214010721.2356923-1-seanjc@google.com> <20241214010721.2356923-16-seanjc@google.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit On Fri, 2024-12-13 at 17:07 -0800, Sean Christopherson wrote: > Add a sanity check that a completely garbage value wasn't written to > the last dirty page in the ring, e.g. that it doesn't contain the *next* > iteration's value. > > Signed-off-by: Sean Christopherson > --- > tools/testing/selftests/kvm/dirty_log_test.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/kvm/dirty_log_test.c b/tools/testing/selftests/kvm/dirty_log_test.c > index 3a4e411353d7..500257b712e3 100644 > --- a/tools/testing/selftests/kvm/dirty_log_test.c > +++ b/tools/testing/selftests/kvm/dirty_log_test.c > @@ -514,8 +514,9 @@ static void vm_dirty_log_verify(enum vm_guest_mode mode, unsigned long **bmap) > * last page's iteration), as the value to be > * written may be cached in a CPU register. > */ > - if (page == dirty_ring_last_page || > - page == dirty_ring_prev_iteration_last_page) > + if ((page == dirty_ring_last_page || > + page == dirty_ring_prev_iteration_last_page) && > + val < iteration) > continue; > } else if (!val && iteration == 1 && bmap0_dirty) { > /* Reviewed-by: Maxim Levitsky