From: Michael Neuling <mikey@neuling.org>
To: ego@linux.vnet.ibm.com
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>,
Akshay Adiga <akshay.adiga@linux.vnet.ibm.com>,
Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>,
Oliver O'Halloran <oohall@gmail.com>,
Nicholas Piggin <npiggin@gmail.com>,
Murilo Opsfelder Araujo <muriloo@linux.ibm.com>,
Anton Blanchard <anton@samba.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 1/3] powerpc: Detect the presence of big-cores via "ibm,thread-groups"
Date: Mon, 24 Sep 2018 09:48:47 +1000 [thread overview]
Message-ID: <a06045cd5f4229113cb301668b2d993060a3ee73.camel@neuling.org> (raw)
In-Reply-To: <20180921171740.GA12919@in.ibm.com>
On Fri, 2018-09-21 at 22:47 +0530, Gautham R Shenoy wrote:
> Hello Michael,
>
> On Fri, Sep 21, 2018 at 01:02:45PM +1000, Michael Neuling wrote:
> > This doesn't compile for me with:
> >
> > arch/powerpc/kernel/smp.c: In function ‘smp_prepare_cpus’:
> > arch/powerpc/kernel/smp.c:812:23: error: ‘tg.threads_per_group’ may be used
> > uninitialized in this function [-Werror=maybe-uninitialized]
> > struct thread_groups tg;
> > ^
> > arch/powerpc/kernel/smp.c:812:23: error: ‘tg.nr_groups’ may be used
> > uninitialized in this function [-Werror=maybe-uninitialized]
> > cc1: all warnings being treated as errors
> > /home/mikey/src/linux-ozlabs/scripts/Makefile.build:305: recipe for target
> > 'arch/powerpc/kernel/smp.o' failed
> >
>
> I couldn't get this error with gcc 4.8.5 and 8.1.1 with
> pseries_defconfig and powernv_defconfig with CONFIG_PPC_WERROR=y.
I'm using 5.4.0 which is in Ubuntu 16.04 (LTS).
> Does the following the following delta patch make it work?
Yep that fixes it, thanks.
Mikey
next prev parent reply other threads:[~2018-09-23 23:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 17:22 [PATCH v8 0/3] powerpc: Detection and scheduler optimization for POWER9 bigcore Gautham R. Shenoy
2018-09-20 17:22 ` [PATCH v8 1/3] powerpc: Detect the presence of big-cores via "ibm,thread-groups" Gautham R. Shenoy
2018-09-21 3:02 ` Michael Neuling
2018-09-21 17:17 ` Gautham R Shenoy
2018-09-23 23:48 ` Michael Neuling [this message]
2018-09-20 17:22 ` [PATCH v8 2/3] powerpc: Use cpu_smallcore_sibling_mask at SMT level on bigcores Gautham R. Shenoy
2018-09-20 17:22 ` [PATCH v8 3/3] powerpc/sysfs: Add topology/smallcore_thread_siblings[_list] Gautham R. Shenoy
2018-09-21 6:20 ` kbuild test robot
2018-09-21 17:20 ` Gautham R Shenoy
2018-09-20 18:04 ` [PATCH v8 0/3] powerpc: Detection and scheduler optimization for POWER9 bigcore Dave Hansen
2018-09-22 11:03 ` Gautham R Shenoy
2018-09-25 22:16 ` Dave Hansen
2018-09-26 6:06 ` Gautham R Shenoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a06045cd5f4229113cb301668b2d993060a3ee73.camel@neuling.org \
--to=mikey@neuling.org \
--cc=akshay.adiga@linux.vnet.ibm.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=ego@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=muriloo@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=oohall@gmail.com \
--cc=shilpa.bhat@linux.vnet.ibm.com \
--cc=srikar@linux.vnet.ibm.com \
--cc=svaidy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®