From: Hui Tang <tanghui20@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <mw@semihalf.com>,
<linux@armlinux.org.uk>, <leon@kernel.org>, <andrew@lunn.ch>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<yusongping@huawei.com>
Subject: Re: [PATCH net v4] net: mvpp2: fix possible invalid pointer dereference
Date: Wed, 16 Nov 2022 14:13:14 +0800 [thread overview]
Message-ID: <a061d870-d0ce-a580-636d-600a9a4b006f@huawei.com> (raw)
In-Reply-To: <20221115202850.7beeea87@kernel.org>
On 2022/11/16 12:28, Jakub Kicinski wrote:
> On Wed, 16 Nov 2022 10:14:37 +0800 Hui Tang wrote:
>> It will cause invalid pointer dereference to priv->cm3_base behind,
>> if PTR_ERR(priv->cm3_base) in mvpp2_get_sram().
>>
>> Fixes: a59d354208a7 ("net: mvpp2: enable global flow control")
>> Signed-off-by: Hui Tang <tanghui20@huawei.com>
>
> Please do not repost new versions so often:
>
> https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#tl-dr
>
> do not use --in-reply-to
Thanks for pointing out, but should I resend it with [PATCH net v3] or [PATCH net v5]?
>> diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
>> index d98f7e9a480e..efb582b63640 100644
>> --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
>> +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
>> @@ -7349,6 +7349,7 @@ static int mvpp2_get_sram(struct platform_device *pdev,
>> struct mvpp2 *priv)
>> {
>> struct resource *res;
>> + void __iomem *base;
>>
>> res = platform_get_resource(pdev, IORESOURCE_MEM, 2);
>> if (!res) {
>> @@ -7359,9 +7360,11 @@ static int mvpp2_get_sram(struct platform_device *pdev,
>> return 0;
>> }
>>
>> - priv->cm3_base = devm_ioremap_resource(&pdev->dev, res);
>> + base = devm_ioremap_resource(&pdev->dev, res);
>> + if (!IS_ERR(base))
>> + priv->cm3_base = base;
>>
>> - return PTR_ERR_OR_ZERO(priv->cm3_base);
>> + return PTR_ERR_OR_ZERO(base);
>
> Use the idiomatic error handling, keep success path un-indented:
>
> ptr = function();
> if (IS_ERR(ptr))
> return PTR_ERR(ptr);
>
> priv->bla = ptr;
> return 0;
>
>
Ok, I will fix it in next version
next prev parent reply other threads:[~2022-11-16 6:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 9:04 [PATCH net v2] " Hui Tang
2022-11-15 9:16 ` Marcin Wojtas
2022-11-15 15:50 ` Andrew Lunn
2022-11-16 2:06 ` [PATCH net v3] " Hui Tang
2022-11-16 2:14 ` [PATCH net v4] " Hui Tang
2022-11-16 4:28 ` Jakub Kicinski
2022-11-16 6:13 ` Hui Tang [this message]
2022-11-16 13:21 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a061d870-d0ce-a580-636d-600a9a4b006f@huawei.com \
--to=tanghui20@huawei.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=yusongping@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®