From: Paolo Bonzini <pbonzini@redhat.com>
To: paulmck@linux.vnet.ibm.com, Jeffrey Hugo <jhugo@codeaurora.org>
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
pprakash@codeaurora.org, Josh Triplett <josh@joshtriplett.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Jens Axboe <axboe@kernel.dk>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Thomas Gleixner <tglx@linutronix.de>,
Richard Cochran <rcochran@linutronix.de>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Richard Weinberger <richard@nod.at>
Subject: Re: [BUG] Deadlock due due to interactions of block, RCU, and cpu offline
Date: Tue, 22 Aug 2017 18:12:04 +0200 [thread overview]
Message-ID: <a0627c12-3406-5e13-8346-649bd8e27edf@redhat.com> (raw)
In-Reply-To: <20170820205658.GS11320@linux.vnet.ibm.com>
On 20/08/2017 22:56, Paul E. McKenney wrote:
>> KVM: async_pf: avoid async pf injection when in guest mode
>> KVM: cpuid: Fix read/write out-of-bounds vulnerability in cpuid emulation
>> arm: KVM: Allow unaligned accesses at HYP
>> arm64: KVM: Allow unaligned accesses at EL2
>> arm64: KVM: Preserve RES1 bits in SCTLR_EL2
>> KVM: arm/arm64: Handle possible NULL stage2 pud when ageing pages
>> KVM: nVMX: Fix exception injection
>> kvm: async_pf: fix rcu_irq_enter() with irqs enabled
>> KVM: arm/arm64: vgic-v3: Fix nr_pre_bits bitfield extraction
>> KVM: s390: fix ais handling vs cpu model
>> KVM: arm/arm64: Fix isues with GICv2 on GICv3 migration
>>
>> Nothing really stands out to me which would "fix" the issue.
>
> My guess would be an undo of the change that provoked the problem
> in the first place. Did you try bisecting within the above group
> of commits?
>
> Either way, CCing Paolo for his thoughts?
There is "kvm: async_pf: fix rcu_irq_enter() with irqs enabled", but it
would have caused splats, not deadlocks.
If you are using nested virtualization, "KVM: async_pf: avoid async pf
injection when in guest mode" can be a wildcard, but only if you have
memory pressure.
My bet is still on the former changing the timing just a little bit.
Paolo
next prev parent reply other threads:[~2017-08-22 16:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-26 23:10 Jeffrey Hugo
2017-03-26 23:28 ` Paul E. McKenney
2017-03-27 18:02 ` Jeffrey Hugo
2017-03-27 18:17 ` Paul E. McKenney
2017-06-20 23:46 ` Paul E. McKenney
2017-06-21 14:39 ` Jeffrey Hugo
2017-06-21 16:18 ` Paul E. McKenney
2017-06-23 3:34 ` Paul E. McKenney
2017-06-27 22:32 ` Jeffrey Hugo
2017-06-28 0:11 ` Paul E. McKenney
2017-06-29 16:29 ` Jeffrey Hugo
2017-06-30 0:18 ` Paul E. McKenney
2017-08-20 19:31 ` Jeffrey Hugo
2017-08-20 20:56 ` Paul E. McKenney
2017-08-22 16:12 ` Paolo Bonzini [this message]
2017-08-22 20:53 ` Jeffrey Hugo
2017-08-15 8:46 ` [tip:core/rcu] rcu: Migrate callbacks earlier in the CPU-offline timeline tip-bot for Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0627c12-3406-5e13-8346-649bd8e27edf@redhat.com \
--to=pbonzini@redhat.com \
--cc=axboe@kernel.dk \
--cc=bigeasy@linutronix.de \
--cc=boris.ostrovsky@oracle.com \
--cc=jhugo@codeaurora.org \
--cc=jiangshanlai@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=pprakash@codeaurora.org \
--cc=rcochran@linutronix.de \
--cc=richard@nod.at \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®