From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933931AbcIOGW5 (ORCPT ); Thu, 15 Sep 2016 02:22:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61326 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933774AbcIOGWn (ORCPT ); Thu, 15 Sep 2016 02:22:43 -0400 Subject: Re: [PATCH] kvm, x86: Properly check whether a pfn is an MMIO or not To: "Raslan, KarimAllah" References: <1466562866-31524-1-git-send-email-karahmed@amazon.de> <6b30fd96-dc04-13a2-aa8b-7760a85337c6@redhat.com> <85E2C33C-8873-4CC8-8D31-9A85C30F8DB5@amazon.de> Cc: "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "x86@kernel.org" , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Borislav Petkov , Denys Vlasenko , Andrew Morton , Toshi Kani , Tony Luck From: Paolo Bonzini Message-ID: Date: Thu, 15 Sep 2016 08:22:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <85E2C33C-8873-4CC8-8D31-9A85C30F8DB5@amazon.de> Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 15 Sep 2016 06:22:42 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/09/2016 07:54, Raslan, KarimAllah wrote: > >> On Jun 22, 2016, at 3:41 PM, Paolo Bonzini wrote: >> >> >> >> On 22/06/2016 04:34, KarimAllah Ahmed wrote: >>> pfn_valid check is not sufficient because it only checks if a page has a struct >>> page or not, if for example "mem=" was passed to the kernel some valid pages >>> won't have a struct page. This means that if guests were assigned valid memory >>> that lies after the mem= boundary it will be passed uncached to the guest no >>> matter what the guest caching attributes are for this memory. >> >> How can you pass memory after the mem= boundary to the guest? > > Does my previous reply answer your question? Yes, but I'm not sure it's the right way to do it. Looking at the e820 memory map seems pretty hacky. Paolo