From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95B721A0BF1 for ; Sat, 17 Jan 2026 17:51:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768672310; cv=none; b=EUEwllssdYOppfhqm7kOFPWbDzo4kCBufUx9WOYftSS4RF/LEZgKBIWzwXcS1L9sqxYrLL1ZTHDD1Qaxb4izd0qZbnSw6+k+yE6pQUCcfmy70P14jLz6huUeZq5cbmMj0bRwtwVy4s52kElyHf+NMPIFpamXBPcA97FRsmG+RDE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768672310; c=relaxed/simple; bh=28WH7l63s5l2WlJhzLByyHNdxvcsiwTY+vNhZgslgDk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EdlhD6sGbS9qCibi/UOtlokAL1sT69Zj1JBEpZCO1apbaY7NtJfRvMneb6Lyt8eQygHE40wLU+wj5+0R2aYizpj7p4DGnSSd4aMu8TdAmbBs9UizFRjsc6WHfRZyddHydFzvunX0KCigxEA/2OUAcDnVT4w4ul45dK/t0r8i94Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BuZTpL+n; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BuZTpL+n" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09562C4CEF7; Sat, 17 Jan 2026 17:51:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768672309; bh=28WH7l63s5l2WlJhzLByyHNdxvcsiwTY+vNhZgslgDk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=BuZTpL+nX1e03f6bjUeIj7bKJNvGLXRyjaOLmhJqx0RMIOtuTjgHPz7wkG5oAlbmJ 34wQ+fWSeKwGQ8d091i9auI6p3iOvc1MPasmHZcrSdm6nFO5qmRIUGfy1V2OrFySt1 ln9jpd9L06/EDA/KbPVJcEckFpPZOk422vcJVuIzGvDZ5ymNy2ypAcpn1AhmzSIFid ShbwM0myUw8LkwCKYGGOTpVY+SkmVTReXv+d/z/XaF/99xb8GB0Bquaf4L42+D9WWZ /Ec7HM8Jr0FHxvRJ0rrEXijuAMB/hSbmg6GeQ+/Kv5N7WfgyfqzesBUjwL8gFR//Yt jvsxSqmJ3VsEA== Message-ID: Date: Sat, 17 Jan 2026 18:51:47 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] memory: emif: fix device tree node reference leak To: Weigang He , Santosh Shilimkar Cc: linux-kernel@vger.kernel.org References: <20260115064237.492714-1-geoffreyhe2@gmail.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <20260115064237.492714-1-geoffreyhe2@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 15/01/2026 07:42, Weigang He wrote: > The EMIF driver acquires a device tree node reference via > of_parse_phandle() but never releases it with of_node_put(), > causing a reference count leak. > > This affects: > 1. Error paths in of_get_memory_device_details() - if allocation > or validation fails after of_parse_phandle() succeeds, the > reference is leaked > 2. Normal driver removal - emif_remove() never releases the > reference stored in emif->np_ddr > > Fix by adding an err_put_node label to properly release the node > reference on error paths, and adding of_node_put() in emif_remove() > to release the reference during normal driver unload. > > Fixes: e6b42eb6a66c ("memory: emif: add device tree support to emif driver") Missing Cc stable. > Signed-off-by: Weigang He > --- > drivers/memory/emif.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c > index 2fadad0666b1f..e4f7547efbff4 100644 > --- a/drivers/memory/emif.c > +++ b/drivers/memory/emif.c > @@ -922,7 +922,7 @@ static struct emif_data *of_get_memory_device_details( > if (!emif || !pd || !dev_info) { > dev_err(dev, "%s: Out of memory!!\n", > __func__); > - goto error; > + goto err_put_node; > } > > emif->plat_data = pd; > @@ -946,7 +946,7 @@ static struct emif_data *of_get_memory_device_details( > pd->device_info->io_width, pd->phy_type, pd->ip_rev, > emif->dev)) { > dev_err(dev, "%s: invalid device data!!\n", __func__); > - goto error; > + goto err_put_node; > } > /* > * For EMIF instances other than EMIF1 see if the devices connected > @@ -970,6 +970,8 @@ static struct emif_data *of_get_memory_device_details( > emif->plat_data->min_tck = of_get_min_tck(np_ddr, emif->dev); > goto out; > > +err_put_node: > + of_node_put(np_ddr); > error: This is unused now. You do not need new label, just use existing one. Best regards, Krzysztof