From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751169AbdFAUAd (ORCPT ); Thu, 1 Jun 2017 16:00:33 -0400 Received: from mx2.suse.de ([195.135.220.15]:39254 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751024AbdFAUAa (ORCPT ); Thu, 1 Jun 2017 16:00:30 -0400 Subject: Re: [PATCH] tty: add TIOCGPTPEER ioctl To: Geert Uytterhoeven Cc: Greg Kroah-Hartman , Jiri Slaby , Arnd Bergmann , "linux-kernel@vger.kernel.org" , alpha , Linux MIPS Mailing List , Parisc List , "linuxppc-dev@lists.ozlabs.org" , Linux-sh list , sparclinux , "linux-xtensa@linux-xtensa.org" , Linux-Arch , Christian Brauner , Valentin Rothberg References: <20170601173803.8698-1-asarai@suse.de> From: Aleksa Sarai Message-ID: Date: Fri, 2 Jun 2017 06:00:17 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> --- a/arch/alpha/include/uapi/asm/ioctls.h >> +++ b/arch/alpha/include/uapi/asm/ioctls.h >> @@ -94,6 +94,7 @@ >> #define TIOCSRS485 _IOWR('T', 0x2F, struct serial_rs485) >> #define TIOCGPTN _IOR('T',0x30, unsigned int) /* Get Pty Number (of pty-mux device) */ >> #define TIOCSPTLCK _IOW('T',0x31, int) /* Lock/unlock Pty */ >> +#define TIOCGPTPEER _IOR('T', 0x41, int) /* Safely open the slave */ > > Shouldn't the list of definitions be kept sorted, by hex number? > (everywhere) Probably. The reason I put it here is because it logically is very similar to TIOCGPTN and TIOSPTLCK, but I can move it if the hex order is more important for maintainence. -- Aleksa Sarai Software Engineer (Containers) SUSE Linux GmbH https://www.cyphar.com/