From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from outbound.st.icloud.com (p-east2-cluster5-host7-snip4-10.eps.apple.com [57.103.79.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8F9332D0FC for ; Sun, 28 Jun 2026 16:09:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=57.103.79.33 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782662962; cv=none; b=pTnkaqGYYQIn2bfuRTS0Qn+XOZXSDyfcOq6MDV/RztOVzH5wPn6ixNGB3vM5wkR8e6hA2V933KV9gHYpJ4Xrb25SZVrwQolZUEuxL+8OEDZPDIChweVU7YqT0vWjZ0qIin1Zzgh395TdLrbWMhfHHzRnOIWBoFJZScTNE+STZfA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782662962; c=relaxed/simple; bh=HsPtSOajqeeyfCW7HxrnAuQ711GqnUaN3sgpgm0Q6LE=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=QlO/6POzQ/u0gpxiK6aRmN4QkJWrSocYq0ZOzsIN3enw7YTwfOnztpBlRS5wRcyn4VK+yee83XSn6CWqcd35/Kz0nEmH4OzAR7Jd2OpL/NsQ8DUtoEyvAjfetU0OkLG0kpQgd39ycpatBaC5k8c27z6S2rwqk/jxBtY8Dg8f/FY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=icloud.com; spf=pass smtp.mailfrom=icloud.com; dkim=pass (2048-bit key) header.d=icloud.com header.i=@icloud.com header.b=weU5cmRn; arc=none smtp.client-ip=57.103.79.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=icloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=icloud.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=icloud.com header.i=@icloud.com header.b="weU5cmRn" Received: from outbound.st.icloud.com (unknown [127.0.0.2]) by p00-icloudmta-asmtp-us-east-1a-60-percent-2 (Postfix) with ESMTPS id B69AF18011D5; Sun, 28 Jun 2026 16:09:18 +0000 (UTC) X-ICL-RepId: 019f0efe-0e54-7854-84c8-409d30ca50b7 X-ICL-Out-Info: HUtFAUMEWwJACUgBTUQeDx5WFlZNRAJCTQhKB0MGWQReCEsLQwZcBlBcHA4XXhtCFUsVXANcDkswUBtfAkIPHBNWFRMLU1ZbE1UXRgkZCF0dGQpQUAVaEhhcFFxQWB5GElYNXQkZGEZeUBtfAkIPHBNWFRMdQxkPKwhKBEMHRQJeCyUTCVNWWxNVF0YJGQhdHRkVWgkKV1NAD0AACQ5ZH0hYQAJAAw4AQRQaUQgPRlNFX0BSCwUIBkkKS3MEVAddBV1WUAJaVRIEQAhWUF4IXh9MHA== Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1782662961; x=1785254961; bh=HsPtSOajqeeyfCW7HxrnAuQ711GqnUaN3sgpgm0Q6LE=; h=Message-ID:Date:MIME-Version:To:Subject:From:Content-Type:x-icloud-hme; b=weU5cmRnFr3gsPtbRquzi/wHP7x93Z84PuBtbEmlgzi3ShkkSe/Xrq/tsM8eBsKYuFCJ4tIbum1Ql/lP6A5ZFpcw6+B0+bDeKpgP9EwiDF8yich9dkbf2koyXSVld/QpLZ6ngLt/4UcEwFMetjOEKJabZpudcKJBnfZIswn6eOOCSgOq0Ud27AU8AUsTYUIlV+SAGcXsk7v+e/4NTW5VR9esBMXXZwCGK8QqwKauqiIsDuQg+dIB8nslf6nEO4IeBS2nEMhMWuR4cXrAxcgJ8A0aOo06SNsbwRC1Jfy37cx0jZGfJcyoZeBnYhqEijKOjfOjaXIhKLpqhmB3y2deIw== Received: from [192.168.255.10] (unknown [17.42.251.67]) by p00-icloudmta-asmtp-us-east-1a-60-percent-2 (Postfix) with ESMTPSA id CA98618000BC; Sun, 28 Jun 2026 16:09:11 +0000 (UTC) Message-ID: Date: Mon, 29 Jun 2026 00:09:03 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: david@kernel.org Cc: akpm@linux-foundation.org, axelrasmussen@google.com, baohua@kernel.org, bruzzhang@tencent.com, hannes@cmpxchg.org, kasong@tencent.com, liam@infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ljs@kernel.org, mhocko@kernel.org, mhocko@suse.com, qi.zheng@linux.dev, rppt@kernel.org, shakeel.butt@linux.dev, surenb@google.com, vbabka@kernel.org, weixugc@google.com, yuanchu@google.com, zippermonkey@icloud.com References: <8a8240ad-049f-4bf8-af65-d5bab2c19024@kernel.org> Subject: Re: [PATCH v4 1/5] mm/vmscan: introduce folio_activate_locked() helper From: Zhang Peng In-Reply-To: <8a8240ad-049f-4bf8-af65-d5bab2c19024@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: zhWZNeanj4DqCr_EBq7T1rv6sTbp8owZ X-Proofpoint-ORIG-GUID: zhWZNeanj4DqCr_EBq7T1rv6sTbp8owZ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI4MDE0NCBTYWx0ZWRfX0TJe5CGKuVqV q4LzJdR1ClNAOUt0Y1ifzFUiQoLN3GQCtEItlxR/oYMSSSDqrhpQ1J0spAxAN1Gbm2VWfOFOaUo BTao+0xzytQmgOEszBVyHDxy4b5AVMhEiZxb3pO2bP+14xyB7jlTsjJ6PE14Pqy78+XJJEcrFrE cLnZjQrNi6Dd3kRtKEjw5LRZFhTorB16Ns0WiG2PIpXyOLWb6qK9efHG+vIpe2Wu6Fc+rOOkH7P fwB+oD7WAsierLfE+KlPX6BphRWcH6efkRkNF/UiecW6wHgL+Slk5bX0nRyNW5wipyQJgnZupSe 8/kE1cEdOr1tv59SDRB On Wed, Jun 17, 2026 at 01:59:55PM +0200, David Hildenbrand wrote: > Passing nr_pages to this helper is rather questionable. Just use > folio_nr_pages(folio) here and make the function less weird. > > Do we want to add a >     VM_WARN_ON_ONCE_FOLIO(!folio_test_locked(folio), folio); > > While at it, do we want to turn this to a VM_WARN_ON_ONCE_FOLIO? > (and can we move that to the beginning of the function?) Yep, all makes sense.  Will drop nr_pages, add the locked check at the top, and switch the BUG_ON to WARN_ON_ONCE — panicking over a bogus active flag is overkill.