From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD2AF185B48 for ; Mon, 29 Jun 2026 13:41:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782740487; cv=none; b=FeojKRBhioDI6RzTTl5UVHKDlpxeAJI2zcJxrxkD8RgLK8qHxoWzqdJot5PaUpRMrpup3Lh/wn4qSnfkTnoqb30z9+9UTrdDfSx/k2Ep5tdtlr+F9aFHq8kq8rJmEqZzxGziXAyInVXMFLctjmYUMTh2wU5o2t3ZcJfZX7BGE3U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782740487; c=relaxed/simple; bh=CQJFHVi3mWhoGuN7PwL+jX0oz9CJw/ur/BmVyt7Uy50=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XHnZ0YJtQUMxMMkk+aeWNKo6jKHInC69Q34bUGmtnqYfchGduVLHwc2fEmk1JBry+xCHtZBwNNI+A7x/Kr3ptdhmqEiLHI8G5GnRgL7mpRUSQdLvWxprkyQxsUOJtuLT7iVtTOtEZiJwWRTwEaRjscsCxNNyjjSqyDjwk7IBZtI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ZCIg6Dl4; arc=none smtp.client-ip=209.85.208.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZCIg6Dl4" Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-39b119855d8so495991fa.0 for ; Mon, 29 Jun 2026 06:41:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1782740483; x=1783345283; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=W1SHPHn50RFg01mCguwYGn/fl6UooE/4FbPssLiu2OM=; b=ZCIg6Dl4o2C93w2kDS32LfgLSNvwQe31Vt801v2ivfnbg2PTe42u0N5tyW94g4cdnJ RgtHhfzh6dH/07gco+VsQ6sZGSed4J2/BFrh9CnpNIqRX4BHstSaTgx2JVGxVO/luJUw 1dbkvCfLuL0S8DVDHWtQHWJZLMnIMsDMjnxsyxwLKvUeLdVJu8dxFPJiu/whSYM7DWqW LZ88TSulr5yXKlTCoIz1h3MvzYVlU3ylTEpqFMK7610346ddr9GOPq5t7SIs1c9IWSAc PVjpzIljWGP0jc8NBa7X1+1oX33NADPPMDaJFUe1X5MvCnsAvNLEkSj9yKpz1E2RWgjA 8OdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782740483; x=1783345283; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=W1SHPHn50RFg01mCguwYGn/fl6UooE/4FbPssLiu2OM=; b=EfDYmWIME3Ms9FI80XrraBxNEdIr0LVFyhI17MvlH0WK1N08DvA5LRNhErvZIs4Si5 tKbdOyFW3ZsN1VfUZqw8ziVEEnfpTrtb4e+3UPgI1tZ84wiJ/brHuFQz3A/HHk4zhKI4 11vw15FtuV6Ji7DesOdcGAW0bEFNgWkUlM9qpwlq53zDZ1Zv4hlJqAm11tVfzagZfqj9 /YBlIG9Az2O1FkktW0TGD11qXYRru5FrPzHsUMvPYQP9ebbPcwRQVIFCKnxtX2N5GUKK dktwLsi+JZ8SQubR97e54YH6lE09xxRkTVR8CLB8gX40EmAh3UikdYQ39mM0x9u61mMw DHIw== X-Forwarded-Encrypted: i=1; AHgh+RqrJzLKqBtS3oz6k8Cmwb4sNXT2Fhp+BjR1YuuZbrcnmWONGC4HqJAGyE2FVKjG+ezDYgUAr4cjvBATIR8=@vger.kernel.org X-Gm-Message-State: AOJu0YwuRDlC+ah3q7/qzjo8zvsHNcq+IsAPYofV0qpVQLhoWI/s44gg 4I46zEKT0rlzwX0FLFfIw+Ly5jaRh4h830x5bphIPjDA0VBDMqGkuAYjkWpmxZk60Gw= X-Gm-Gg: AfdE7ckYDxcDSLTgPn8n5Isw8WNUbtLcQua6fAKCUg+jd5fyEDlfo3KznRdYSzO85pa h0XKWWUJ1nSvG8If9oCOpeqmB2g3SH+e30nBdiZEih/4ZU1eBs8jOXVJvUuN7u0BDYhjaiL6R3u RKon4hIwcsqNw4ZZllrimTMzByE7AWcDBOBjfI3doL6mTbtx6cRXRFcQudLqh9GKOsYYCvy/wuq hHo0GNEj9DJTv+ZsY0uDaYNbdfTsieJtu+3DI+WEUI1WPZv+/aKy9Wcl/7/eSPCwPdO8LQQhOFl 6ozHIbwHfWzR1/DFxnm/C4RKfoLntQaQ3k2Sp3ACj3wCedHT1nOxVVQpeUyT/SG1A6y4tGRaAzu d+aIqm0P6UFpCGkxpKDpp3ktuWu3Cl3N9ccZ3onYfcxGkQ9l2MGrGV63VV42u6vDiqByP5clBMI 7OlhV6l4EdzpC+k9zc4bBcHPFMtGU2wuIv5+DDH93DbSIxvHvaL+GQBsxr5hOS/KLsFSw= X-Received: by 2002:a2e:ab06:0:b0:396:8c78:3d53 with SMTP id 38308e7fff4ca-39acb9ac8a6mr17363281fa.8.1782740483113; Mon, 29 Jun 2026 06:41:23 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-39b176967a1sm3100311fa.13.2026.06.29.06.41.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jun 2026 06:41:22 -0700 (PDT) Message-ID: Date: Mon, 29 Jun 2026 16:41:21 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] media: qcom: camss: populate child platform devices To: Atanas Filipov , linux-media@vger.kernel.org Cc: mchehab@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, andersson@kernel.org, quic_vgarodia@quicinc.com, quic_jesszhan@quicinc.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue References: <20260629121750.3469292-1-atanas.filipov@oss.qualcomm.com> <20260629121750.3469292-2-atanas.filipov@oss.qualcomm.com> From: Vladimir Zapolskiy In-Reply-To: <20260629121750.3469292-2-atanas.filipov@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/29/26 15:17, Atanas Filipov wrote: > Call of_platform_populate() at the end of camss_probe() so that child > nodes of the CAMSS DT node are registered as platform devices and > probed via their own platform_driver. This allows hardware blocks that > are physically part of the Camera SubSystem - such as the JPEG encoder > - to be described as sub-nodes of the CAMSS DT node and probe > automatically without any changes to their own drivers. > > Call of_platform_depopulate() at the start of camss_remove() to tear > down child devices before the parent unwinds its own resources. > > Suggested-by: Bryan O'Donoghue > Link: https://patchwork.linuxtv.org/project/linux-media/patch/20260326-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v11-4-5b93415be6dd@linaro.org/ > Signed-off-by: Atanas Filipov Instead please include this unmodified change to the series: https://lore.kernel.org/linux-media/20260508-camss-isp-ope-v3-11-bb1055274603@oss.qualcomm.com/ > --- > drivers/media/platform/qcom/camss/camss.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c > index 2123f6388e3d..d2ecc79d5269 100644 > --- a/drivers/media/platform/qcom/camss/camss.c > +++ b/drivers/media/platform/qcom/camss/camss.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -5460,6 +5461,8 @@ static int camss_probe(struct platform_device *pdev) > goto err_media_device_unregister; > } > > + of_platform_populate(dev->of_node, NULL, NULL, dev); > + > return 0; > > err_media_device_unregister: > @@ -5497,6 +5500,7 @@ static void camss_remove(struct platform_device *pdev) > { > struct camss *camss = platform_get_drvdata(pdev); > > + of_platform_depopulate(&pdev->dev); > v4l2_async_nf_unregister(&camss->notifier); > v4l2_async_nf_cleanup(&camss->notifier); > camss_unregister_entities(camss); -- Best wishes, Vladimir