From: Pavel Skripkin <paskripkin@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Zameer Manji <zmanji@gmail.com>,
gregkh@linuxfoundation.org,
Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Michael Straube <straube.linux@gmail.com>,
"Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: remove unused defines in wifi.h
Date: Tue, 16 Nov 2021 18:01:42 +0300 [thread overview]
Message-ID: <a072c468-f9dd-25f4-70fa-535cb7196b13@gmail.com> (raw)
In-Reply-To: <20211116141838.GI26989@kadam>
On 11/16/21 17:18, Dan Carpenter wrote:
>> I cannot ack, since I am not the maintainer (or even reviewer) of this
>> driver :) I just saw this BIT() definition and decided to say, that it can
>> be also removed
>
> Just give a Reviewed-by tag... No one is appointed as a maintainer, you
> just have to start handing our reviewed-by tags until people start to
> respect your judgement and then you're a maintainer.
>
Ok, I will send the R-b tag, since patch looks correct to me as is :)
I think, I misunderstood what "ack" means. I thought Zameer means
Acked-by tag, which can sent only by maintainers (Larry and Phillip in
case of r8188eu), but I was wrong, I guess...
With regards,
Pavel Skripkin
next prev parent reply other threads:[~2021-11-16 15:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 1:14 Zameer Manji
2021-11-16 4:56 ` Pavel Skripkin
2021-11-16 13:48 ` Zameer Manji
2021-11-16 14:00 ` Pavel Skripkin
2021-11-16 14:18 ` Dan Carpenter
2021-11-16 15:01 ` Pavel Skripkin [this message]
2021-11-16 15:11 ` Dan Carpenter
2021-11-16 15:03 ` Pavel Skripkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a072c468-f9dd-25f4-70fa-535cb7196b13@gmail.com \
--to=paskripkin@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
--cc=zmanji@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®