From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
David Teigland <teigland@redhat.com>,
Jeff Layton <jlayton@poochiereds.net>,
Christine Caulfield <ccaulfie@redhat.com>,
cluster-devel@redhat.com, linux-kernel@vger.kernel.org
Subject: [PATCH 6/9] dlm: plock: Add argument descriptions to notify
Date: Sun, 20 Jul 2014 11:23:40 -0700 [thread overview]
Message-ID: <a07ad29be89c2fd35c356cbe968aa3276abe2d54.1405879494.git.joe@perches.com> (raw)
In-Reply-To: <cover.1405879494.git.joe@perches.com>
Function pointer arguments without type names
are not very clear. Add them.
Signed-off-by: Joe Perches <joe@perches.com>
---
fs/dlm/plock.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/dlm/plock.c b/fs/dlm/plock.c
index f704458..e59d332 100644
--- a/fs/dlm/plock.c
+++ b/fs/dlm/plock.c
@@ -30,7 +30,7 @@ struct plock_op {
struct plock_xop {
struct plock_op xop;
- void *callback;
+ int (*callback)(struct file_lock *, struct file_lock *, int);
void *fl;
void *file;
struct file_lock flc;
@@ -190,7 +190,7 @@ static int dlm_plock_callback(struct plock_op *op)
struct file *file;
struct file_lock *fl;
struct file_lock *flc;
- int (*notify)(void *, void *, int) = NULL;
+ int (*notify)(struct file_lock *fl, struct file_lock *cont, int result) = NULL;
struct plock_xop *xop = (struct plock_xop *)op;
int rv = 0;
--
1.8.1.2.459.gbcd45b4.dirty
next prev parent reply other threads:[~2014-07-20 18:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-20 18:23 [PATCH 0/9] fs.h/dlm: Neatening and argument removals Joe Perches
2014-07-20 18:23 ` [PATCH 1/9] fs.h: Remove unnecessary extern prototypes Joe Perches
2014-07-23 17:58 ` Jeff Layton
2014-07-20 18:23 ` [PATCH 2/9] fs.h: Whitespace neatening Joe Perches
2014-07-23 17:57 ` Jeff Layton
2014-07-20 18:23 ` [PATCH 3/9] fs.h: A few more whitespace neatenings Joe Perches
2014-07-23 18:12 ` Jeff Layton
2014-07-20 18:23 ` [PATCH 4/9] fs.h: Add argument names to struct file_lock_operations (*funcs) Joe Perches
2014-07-23 17:59 ` Jeff Layton
2014-07-20 18:23 ` [PATCH 5/9] fs.h: Add member argument descriptions to lock_manager_operations Joe Perches
2014-07-23 17:59 ` Jeff Layton
2014-07-20 18:23 ` Joe Perches [this message]
2014-07-20 18:23 ` [PATCH 7/9] dlm: fs: Remove unused conf from lm_grant Joe Perches
2014-07-23 18:00 ` Jeff Layton
2014-07-20 18:23 ` [PATCH 8/9] dlm: plock: Reduce indentation by rearranging order Joe Perches
2014-07-23 18:01 ` Jeff Layton
2014-07-20 18:23 ` [PATCH 9/9] fs: dlm: lockd: Convert int result to unsigned char type Joe Perches
2014-07-23 18:11 ` Jeff Layton
2014-07-23 18:33 ` David Teigland
2014-07-24 3:53 ` Joe Perches
2014-07-24 16:24 ` Jeff Layton
2014-07-24 16:35 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a07ad29be89c2fd35c356cbe968aa3276abe2d54.1405879494.git.joe@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=ccaulfie@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=jlayton@poochiereds.net \
--cc=linux-kernel@vger.kernel.org \
--cc=teigland@redhat.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®