From: "Michel Dänzer" <michel@daenzer.net>
To: Lyude Paul <lyude@redhat.com>
Cc: amd-gfx@lists.freedesktop.org,
"David (ChunMing) Zhou" <David1.Zhou@amd.com>,
"Andrey Grodzovsky" <andrey.grodzovsky@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Tony Cheng" <Tony.Cheng@amd.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
"Shirish S" <shirish.s@amd.com>,
"Leo (Sunpeng) Li" <sunpeng.li@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Harry Wentland" <harry.wentland@amd.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH] drm/amdgpu: Count disabled CRTCs in commit tail earlier
Date: Fri, 22 Jun 2018 09:38:30 +0200 [thread overview]
Message-ID: <a07b99f8-e5ea-fa8c-dc43-75c032c4afd0@daenzer.net> (raw)
In-Reply-To: <20180621204832.22448-1-lyude@redhat.com>
On 2018-06-21 10:48 PM, Lyude Paul wrote:
> This fixes a regression I accidentally reduced that was picked up by
> kasan, where we were checking the CRTC atomic states after DRM's helpers
> had already freed them. Example:
>
> [...]
>
> So, we fix this by counting the number of CRTCs this atomic commit disabled
> early on in the function before their atomic states have been freed, then use
> that count later to do the appropriate number of RPM puts at the end of the
> function.
>
> Fixes: 97028037a38ae ("drm/amdgpu: Grab/put runtime PM references in atomic_commit_tail()")
> Signed-off-by: Lyude Paul <lyude@redhat.com>
> Cc: Michel Dänzer <michel@daenzer.net>
> Reported-by: Michel Dänzer <michel@daenzer.net>
Actually, it was reported by Tom St Denis <tom.stdenis@amd.com>. With
that fixed,
Acked-by: Michel Dänzer <michel.daenzer@amd.com>
(needs review by DC folks)
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
next prev parent reply other threads:[~2018-06-22 7:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 20:48 Lyude Paul
2018-06-22 7:38 ` Michel Dänzer [this message]
2018-06-22 17:34 ` Andrey Grodzovsky
2018-06-22 18:56 ` Lyude Paul
2018-06-23 1:03 ` Andrey Grodzovsky
2018-06-23 2:42 ` Andrey Grodzovsky
2018-06-22 17:52 ` Harry Wentland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a07b99f8-e5ea-fa8c-dc43-75c032c4afd0@daenzer.net \
--to=michel@daenzer.net \
--cc=David1.Zhou@amd.com \
--cc=Tony.Cheng@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andrey.grodzovsky@amd.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=shirish.s@amd.com \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome