mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: Baoyou Xie <baoyou.xie@linaro.org>, <tony@atomide.com>
Cc: <linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<arnd@linaro.org>, <xie.baoyou@zte.com.cn>
Subject: Re: [PATCH] fix:memory:omap-gpmc:mark symbols static where possible
Date: Mon, 29 Aug 2016 10:32:44 +0300	[thread overview]
Message-ID: <a07bfba4-0e75-4797-85f9-67c279b374f4@ti.com> (raw)
In-Reply-To: <1472362095-15715-1-git-send-email-baoyou.xie@linaro.org>

Hi,

On 28/08/16 08:28, Baoyou Xie wrote:
> We get 1 warning when build kernel with W=1:
> drivers/memory/omap-gpmc.c:354:14: warning: no previous prototype for 'gpmc_clk_ticks_to_ns' [-Wmissing-prototypes]
> 
> In fact, this function is only used in the file in which it is declared
> and don't need a declaration, but can be made static.
> so this patch marks it 'static'.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
>  drivers/memory/omap-gpmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
> index 869c83f..f71cbf7 100644
> --- a/drivers/memory/omap-gpmc.c
> +++ b/drivers/memory/omap-gpmc.c
> @@ -350,7 +350,7 @@ static unsigned int gpmc_ps_to_ticks(unsigned int time_ps)
>  	return (time_ps + tick_ps - 1) / tick_ps;
>  }
>  
> -unsigned int gpmc_clk_ticks_to_ns(unsigned ticks, int cs,
> +static unsigned int gpmc_clk_ticks_to_ns(unsigned int ticks, int cs,
>  				  enum gpmc_clk_domain cd)
>  {
>  	return ticks * gpmc_get_clk_period(cs, cd) / 1000;
> 

This patch fails checkpatch with following error

CHECK: Alignment should match open parenthesis
#28: FILE: drivers/memory/omap-gpmc.c:354:
+static unsigned int gpmc_clk_ticks_to_ns(unsigned int ticks, int cs,
 				  enum gpmc_clk_domain cd)

Also IMO patch subject is better as
"memory: omap-gpmc: make gpmc_clk_ticks_to_ns() static"

I'll fix these issues myself this time. Thanks for the fix.
Picked for v4.9.

regards,
-roger

      reply	other threads:[~2016-08-29  7:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-28  5:28 Baoyou Xie
2016-08-29  7:32 ` Roger Quadros [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a07bfba4-0e75-4797-85f9-67c279b374f4@ti.com \
    --to=rogerq@ti.com \
    --cc=arnd@linaro.org \
    --cc=baoyou.xie@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    --cc=xie.baoyou@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®