From: Dan Carpenter <dan.carpenter@linaro.org>
To: Paolo Perego <pperego@suse.de>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Dave Penkler <dpenkler@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kees Bakker <kees@ijzerbout.nl>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] staging:gpib: Fix a dereference before null check issue
Date: Wed, 20 Nov 2024 20:04:06 +0300 [thread overview]
Message-ID: <a0807e04-b2c9-4261-9b3f-7660fe258f56@stanley.mountain> (raw)
In-Reply-To: <20241120144653.377795-1-pperego@suse.de>
On Wed, Nov 20, 2024 at 03:46:53PM +0100, Paolo Perego wrote:
> This commit fixes a dereference before null check issue discovered by
> Coverity (CID 1601566).
>
> The check ad line 1450 suggests that a_priv can be NULL, however it has
> been derefenced before, in the interface_to_usbdev() call.
>
> Signed-off-by: Paolo Perego <pperego@suse.de>
> ---
You need a Fixes tag. But I'm pretty sure the correct fix is to remove the NULL
check.
regards,
dan carpenter
next prev parent reply other threads:[~2024-11-20 17:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 14:46 Paolo Perego
2024-11-20 16:42 ` [PATCH] staging: gpib: " Markus Elfring
2024-11-20 17:04 ` Dan Carpenter [this message]
2024-11-20 19:54 ` [PATCH] staging:gpib: " Kees Bakker
2024-11-21 7:37 ` Dan Carpenter
2024-11-21 14:10 ` Paolo Perego
2024-11-21 14:17 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0807e04-b2c9-4261-9b3f-7660fe258f56@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=arnd@arndb.de \
--cc=dpenkler@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kees@ijzerbout.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=pperego@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®