From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933276AbcI0L0F (ORCPT ); Tue, 27 Sep 2016 07:26:05 -0400 Received: from mail-pf0-f178.google.com ([209.85.192.178]:33462 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753698AbcI0LZz (ORCPT ); Tue, 27 Sep 2016 07:25:55 -0400 Subject: Re: [PATCH] brcmfmac: replace WARNING on timeout with a simple error message To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Kalle Valo References: <20160927101224.3534-1-zajec5@gmail.com> Cc: Franky Lin , Hante Meuleman , Pieter-Paul Giesberts , Franky Lin , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= From: Arend Van Spriel Message-ID: Date: Tue, 27 Sep 2016 13:25:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20160927101224.3534-1-zajec5@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27-9-2016 12:12, Rafał Miłecki wrote: > From: Rafał Miłecki > > Even with timeout increased to 950 ms we get WARNINGs from time to time. > It mostly happens on A-MPDU stalls (e.g. when station goes out of > range). It may take up to 5-10 secods for the firmware to recover and > for that time it doesn't process packets. > > It's still useful to have a message on time out as it may indicate some > firmware problem and incorrect key update. Raising a WARNING however > wasn't really that necessary, it doesn't point to any driver bug anymore > and backtrace wasn't much useful. Indeed the interesting part would be in another context. So: Acked-by: Arend van Spriel > Signed-off-by: Rafał Miłecki > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c > index 6d046ba..9e6f60a 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c > @@ -1161,7 +1161,8 @@ int brcmf_netdev_wait_pend8021x(struct brcmf_if *ifp) > !brcmf_get_pend_8021x_cnt(ifp), > MAX_WAIT_FOR_8021X_TX); > > - WARN_ON(!err); > + if (!err) > + brcmf_err("Timed out waiting for no pending 802.1x packets\n"); > > return !err; > } >