From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 004FEC83F19 for ; Wed, 30 Aug 2023 04:00:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241857AbjH3EAD (ORCPT ); Wed, 30 Aug 2023 00:00:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241941AbjH3D7f (ORCPT ); Tue, 29 Aug 2023 23:59:35 -0400 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05ECDEA; Tue, 29 Aug 2023 20:59:32 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id DBB025C018F; Tue, 29 Aug 2023 23:59:29 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 29 Aug 2023 23:59:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flygoat.com; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1693367969; x=1693454369; bh=B7v0oKwXlhirKI8pFGlX+Cq5iQeRFkHRzlG lNb+nzfw=; b=2sADCFHW5sbgkFcJ0EdRYBEKUTK9VJaJe8hb6N904J9biqCdGaE EoqOTGYBYNs3HuvCYbFoD6SFg3DgAB6+WLf5uQnmg99nhRCSIkx9ppFW8vccXwTM SRkBxIYf2K0wTMnEizkh0J+KiP0P72c/A4DONtdrURWCb9FthfhwtnqnTNSHibHI H5iGxbnOpaTSyH5jTfMheC+rI6Vajre5fOCDJg3CsGD2p5s5ZvgSnwDkZDXj/+ka WDBdsFjgpZM3xwel/ZFeIaSM8+agec6cSBL4A0bAwS1q0wwCXabCQ0Flss2e+UK0 pTgGzWJS/wSvdtkRod9SAsfHkUB/9zSB2MQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1693367969; x=1693454369; bh=B7v0oKwXlhirKI8pFGlX+Cq5iQeRFkHRzlG lNb+nzfw=; b=wmapuD0lAvq1BXqvqduR9c5acm+NKGsAeGoEVDr0iCAAEhmraH0 pdrkUc7+1xa93AaDLhmMJCxi3BYA9AIOgHK1rXQKk1E+6gfHxQoJvyal38jU+WQo Is8W+5q+Z3Ir8SWPeIf+0MlqIlIWJYTs/uWb1EGZh4D/GS74pjGnR9ZMkpEkovBX yTqkRSDMvhuMW8s5zBZipl0Hyz/PzsZClK3yxk7/Ubz9lcPzjxqhn+9Wz/Q39Nj1 q+7PGiqXN/C6dK1pKw5hjuXo2BU9yI4Qrzj0PHBnGMHCgJ47jWTlhwz/LZ2kv+2z 45kG56Z62vpkfH5rlCbX0SkqXYZIeCafvAw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudefjedgjeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfvfevfhfhufgjtgfgsehtkeertddtfeejnecuhfhrohhmpeflihgr gihunhcujggrnhhguceojhhirgiguhhnrdihrghnghesfhhlhihgohgrthdrtghomheqne cuggftrfgrthhtvghrnhepgeekgfevffegueefvdfftddtgedvhfduieevgeekgeeifffh tedtjedvfeelgfelnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjihgrgihunhdrhigrnhhg sehflhihghhorghtrdgtohhm X-ME-Proxy: Feedback-ID: ifd894703:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 29 Aug 2023 23:59:23 -0400 (EDT) Message-ID: Date: Wed, 30 Aug 2023 11:59:20 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 To: Krzysztof Kozlowski , Binbin Zhou Cc: Binbin Zhou , Huacai Chen , Thomas Gleixner , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Huacai Chen , loongson-kernel@lists.loongnix.cn, devicetree@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, diasyzhang@tencent.com, linux-kernel@vger.kernel.org References: <20230821061315.3416836-1-zhoubinbin@loongson.cn> <6ba31912-6738-6156-d5f4-3c8d3a3ca7bc@linaro.org> From: Jiaxun Yang Content-Language: , en-GB Subject: Re: [PATCH v2] dt-bindings: interrupt-controller: loongson,liointc: Fix warnings about liointc-2.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2023/8/25 20:56, Krzysztof Kozlowski 写道: [...] > How did you sneak this property? The version - v2 - which was reviewed > by Rob: > https://lore.kernel.org/all/20190905144316.12527-7-jiaxun.yang@flygoat.com/ > did not have it. > > Now v3 suddenly appears with Rob's review and this property: > https://lore.kernel.org/all/20200112081416.722218-4-jiaxun.yang@flygoat.com/ > > Please help me understand this property appeared there and how did you > get it reviewed? Hi all, It has been some years since this series was merged. My vague memory tells me there was some off-list discussion made in IRC with linux-arch folks and IRQ folks to come up with this binding design. In this case I guess I forgot to drop Rob's R-b tag when updating this patch between reversions. I  apologize for any inconvenience this may have caused. > >> <0xffffffff>, /* int1 */ >> <0x00000000>, /* int2 */ >> <0x00000000>; /* int3 */ > So now you will keep bringing more hacks for a hacky property. No, this > cannot go on. What's the best way, in your opinion, to overhaul this property? As we don't really care backward compatibility of DTBs on those systems we can just redesign it. A little bit background about this property, LIOINTC can route a interrupt to any of 4 upstream core interrupt pins. Downstream interrupt devicies should not care about which pin the interrupt go but we want to leave a knob in devicetree for performance tuning. So we designed such property that use masks corresponding to each upsteam interrupt pins to tell where should a interrupt go. Thnaks - Jiaxun > > Best regards, > Krzysztof >