From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 430133CBE92 for ; Fri, 13 Mar 2026 17:24:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773422696; cv=none; b=RPIsq6mJRlARS1Y8SLjXjvoNoth+TUTRf8+ftZ40oOYYGYnSlc5QxGT3Y+ewnRbb82O0Dt+5JYjZShvYw9OnsypEfPMOt/njKoR76IM6OoMI+mrpRZC0gdVC7jXGPq4tXL8oay/FEZIu2UEb6ycG5NjGENigK+HsYshQ9hScWKs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773422696; c=relaxed/simple; bh=RYUtDu4/ksEGv2btHhMUsGqDiMCF5NNiK6mOhT67obA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qfV9XJ17aNXXOOtKVu5ud62E6ZQgmapVdVCdsYss5oGcN7LTvUXqpb958u4nKPTgoXJ5RZatny/m3MYF6Y4AE4KjFcHqYf38sfG1Pe5dbMNfB0zSxAPc9Bys6Thp3VtwsC3IZ6N1ng3uOwuRju0SOJl1WbMFIu1Fuyrr7i9ViKQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PcnxHi78; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jyPOOsRk; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PcnxHi78"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jyPOOsRk" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62DEUeec2262606 for ; Fri, 13 Mar 2026 17:24:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= dgiFOIwoyS3Ji9sphkLmcFmfMQca4IMGuI+uQ4NwSYk=; b=PcnxHi78X2qZcKs5 zimmNyty7xM9XtxC9lw3mmn0xUAiy4v+pQYpSTY2r0VMd/MljAIRFLz18DiJpLs2 oeDNPoQ+POmYO0wk48tJ4k2kciJTcu0cXUxXlXISzKMxR+Cl8N7lxJD3wzCcAUMe eBhxJ0rF4SL1lEgZLpMuPJvs3doQJIRpeWcZy17lFSpj2Pw02pzomt2bmaV2nse8 IMN2IwpF8d9JrA+lYv6OLZ12Ft5bCJxPC+AF6ZLYREJlZYTKp1mURtKLRU3X6ndv zyBHH06q0n12N3N+foD9zEWZPLgLMiVmvADg/tlxlrjFiBc3UqkhY1L+Y0vwCRg/ 6qpvXA== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cvef4sytg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 13 Mar 2026 17:24:54 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2aecd4f7ca1so4573675ad.2 for ; Fri, 13 Mar 2026 10:24:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773422694; x=1774027494; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dgiFOIwoyS3Ji9sphkLmcFmfMQca4IMGuI+uQ4NwSYk=; b=jyPOOsRk8WYckMrFzEy67hDPOTgb5LjKxUBgVORMNwRPd2xfVvr9hyJdrDUeiiwUb+ XdAn/OB4ddrHUo+kGpwAGeC7pBv6SAO7NhRczlTrFrpheiaZq0f4cwXnfrsYKAbvjLhY bzAqdZBrIzRvovITLauj8fsbYTI7s3ToXmG3f2n/g24ecHzR6+JL78MKVNNVYgJKipw2 lMfp3h2hf7FUXAmAVOybBLlzFbzciz+Dfi3GBFvupjJTAa3ff2BN7mQkaCr6+25ansvB YBDfRezVUMwUSruylz+K6h289TSEdCEb0vnt2g4c1msrM/Zib2iChdNUw5nTVB2st4Ob PH6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773422694; x=1774027494; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dgiFOIwoyS3Ji9sphkLmcFmfMQca4IMGuI+uQ4NwSYk=; b=AZNoOYyKX+G2ZBZ739Af6DWngg2K4oUhOtb2zm6UEkg1oFXlXDeINOA1/x9caHgxV4 RErMVvKDKMIz8RA2CEAY3BIbXN61jpFNxPbq19TWC0GzeMOkGQmEGzBr0Ci36OwO0OVw t1eHKq0Pn/AjrxEcBYhJHEDSBYwirmrS79Z3Om6zkWzB9k3Wi4dpZUzEsxwO28rv2+t2 9o0zkhwqkziKm0ORBhwseX2VrChypsAyv9Nco2e9ApwBXmfU9BAVxJEpSNnF+idSLlOf 7uXdyrjHIN2763GJ2yWeTRLGwOvZIW7OEj0IZWEcnyWt1gRWH37tktisEPKv4gnIahl9 HKPQ== X-Forwarded-Encrypted: i=1; AJvYcCWvXYJZAUY+YnLPc1Mz0LBH2zlzKm1qE2Jlt0dqo/8TpqMEVLkckxCwlh1C52PRALR1l36Bwk29wPuidvw=@vger.kernel.org X-Gm-Message-State: AOJu0YxVcd0pt10SctxjcIlePs/ABc2t93536nCvySbxx9FeU2wshegu LhnpZ9CrpYG/liZyJOzl7PbOrFJI3/YfgeNu/juLj7dTuR1ilrL3THt9ceYriXIYspOrCZZjT0R yG5dgJg9vldFKZXGphKkitbNFz4PoZd4sDt2lXfUGFDMeo2W4byCy3DQHByDit2INeMM= X-Gm-Gg: ATEYQzxJfhDU9Aldlbhi0UQyFqR79GsjpWoQIWeXpwcqxOGFQ3UT8fTH251hE9knE1/ N0ESRc+WdqEytV3YnJnicOGFQJpDhr0FoN82a0g+3qlmtiUVus+IUGZPeUtxFvIVehfnVfX8Ln1 bkV7qiXs5zJR7TZDAKA+A/3B8k1F7AeqQrwc2/KphONKLE7WgoBfDif4r58B7pmtfGNyeqFRKDP SYDrXFqJ9lzIhcPbXQJX5cM6fpoWNpvOknFWs0xbkHoNpQ/1iLwqPawTwbgmmSjZKeZTawHhijD d7YNTQLmG2WZSUArowgH4no4E5xTHRPn8XwijUZDeTdIzMdxmcZ54GHzU0iw+HjcApn35vBuhkH mBXDSLqY30sVkcSPGFA/c/6jTS0Wu9qhVJCmbVYrrhdo= X-Received: by 2002:a17:903:3b8e:b0:2ae:3afc:eb42 with SMTP id d9443c01a7336-2aecab04a1dmr37715425ad.38.1773422693613; Fri, 13 Mar 2026 10:24:53 -0700 (PDT) X-Received: by 2002:a17:903:3b8e:b0:2ae:3afc:eb42 with SMTP id d9443c01a7336-2aecab04a1dmr37715155ad.38.1773422693145; Fri, 13 Mar 2026 10:24:53 -0700 (PDT) Received: from [192.168.1.8] ([101.0.62.124]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aece83d391sm35439165ad.79.2026.03.13.10.24.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2026 10:24:52 -0700 (PDT) Message-ID: Date: Fri, 13 Mar 2026 22:54:47 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/5] platform: arm64: Add driver for EC found on Qualcomm reference devices To: Dmitry Baryshkov Cc: Sibi Sankar , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, Maya Matuszczyk References: <20260313-v04-add-driver-for-ec-v4-0-ca9d0efd62aa@oss.qualcomm.com> <20260313-v04-add-driver-for-ec-v4-2-ca9d0efd62aa@oss.qualcomm.com> <44xgivai4jqlc7f5xxe6yohzrqicb2sgso465xuip66n5tatqt@6cu2u4erpe5j> Content-Language: en-US From: Anvesh Jain P In-Reply-To: <44xgivai4jqlc7f5xxe6yohzrqicb2sgso465xuip66n5tatqt@6cu2u4erpe5j> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: acbeShDYRYfAUVfp_4YZFWmGe5ARm5I- X-Proofpoint-GUID: acbeShDYRYfAUVfp_4YZFWmGe5ARm5I- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEzMDEzOSBTYWx0ZWRfX7el/FlAIjmVf PvtCJxjYfmlWbgMmSS3mtPQUoxQBXsS8f+uT6emyOS/0UdqkeAw64eDh5GTn2FiIEYZp92K+mcs 4z1RsNDeeQg4YWNuWl0nU0zz7UlDJPzv9rucIYaf0VoLSVddOS7QHFXtISElDiuhR+tiz+LTnjr 0dJKS4WzQwTU33Ru9kUu3fI7hbtZrjOJoI0Gvt8UqeujIrYgD5S6wu/SFZEaVXdrLYACYUfNq0e 2U+In635otd2QwzBvQBFzpqnKLU118s2aYuQLG07PQAR7ygekrGI5iUXMryt4nXZgjk5jM6mYId OMqV5Wi0pN/KKVjT1YpahRYhUGHFtmnqZa6BnT2U0H7m5VFXF/mCxTa4LHWZLrTutviZfC6HGVF AHli+87iwAQJM/I0amx/WKx+pIfuw7fsxFs3KMhX4psLsBgrZq9niYfcNTKJtrIEBa0wm9BJpag nQHqvltXG6nVHN/FN0w== X-Authority-Analysis: v=2.4 cv=S9nUAYsP c=1 sm=1 tr=0 ts=69b44866 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=EhmMhbG5NVnfTD3xWHIiWQ==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=pGLkceISAAAA:8 a=VOWR3M7HpeV8rc-S3HoA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-13_03,2026-03-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 malwarescore=0 priorityscore=1501 suspectscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603130139 On 3/13/2026 8:05 PM, Dmitry Baryshkov wrote: > On Fri, Mar 13, 2026 at 03:59:52PM +0530, Anvesh Jain P wrote: >> From: Sibi Sankar >> >> Add Embedded controller driver support for Hamoa/Purwa/Glymur qualcomm >> reference boards. It handles fan control, temperature sensors, access >> to EC state changes and supports reporting suspend entry/exit to the >> EC. >> >> Co-developed-by: Maya Matuszczyk >> Signed-off-by: Maya Matuszczyk >> Signed-off-by: Sibi Sankar >> Co-developed-by: Anvesh Jain P >> Signed-off-by: Anvesh Jain P >> --- >> MAINTAINERS | 8 + >> drivers/platform/arm64/Kconfig | 12 + >> drivers/platform/arm64/Makefile | 1 + >> drivers/platform/arm64/qcom-hamoa-ec.c | 468 +++++++++++++++++++++++++++++++++ >> 4 files changed, 489 insertions(+) >> >> --- /dev/null >> +++ b/drivers/platform/arm64/qcom-hamoa-ec.c >> @@ -0,0 +1,468 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +/* >> + * Copyright (c) 2024 Maya Matuszczyk >> + * Copyright (c) 2026, Qualcomm Technologies, Inc. and/or its subsidiaries. > > Drop the year from Qualcomm copyright, please. Will fix in v5. > >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include > > Please add and Will add both headers in v5. > > With that and with the typo fixed, Thanks for the review! > > > Reviewed-by: Dmitry Baryshkov > > > -- Best Regards, Anvesh