From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754023AbdJIKAJ (ORCPT ); Mon, 9 Oct 2017 06:00:09 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:52081 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753968AbdJIKAI (ORCPT ); Mon, 9 Oct 2017 06:00:08 -0400 X-Google-Smtp-Source: AOwi7QCxkhEsiI81JvprrtaTYgjOMYdmwu1sectw0SldlwS0floDMfFdFHPA42eJwvrGb2nLFei2zA== Subject: Re: [PATCH] cklight: tps65217_bl: Remove unnecessary default brightness check To: Christos Gkekas , Lee Jones , Jingoo Han , Bartlomiej Zolnierkiewicz , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1507499808-12896-1-git-send-email-chris.gekas@gmail.com> From: Daniel Thompson Message-ID: Date: Mon, 9 Oct 2017 11:00:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1507499808-12896-1-git-send-email-chris.gekas@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/10/17 22:56, Christos Gkekas wrote: > Variable val holds the default brightness and is unsigned, therefore > checking whether it is less than zero is redundant. > > Signed-off-by: Christos Gkekas Acked-by: Daniel Thompson > --- > drivers/video/backlight/tps65217_bl.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/video/backlight/tps65217_bl.c b/drivers/video/backlight/tps65217_bl.c > index fd524ad..61ea82d 100644 > --- a/drivers/video/backlight/tps65217_bl.c > +++ b/drivers/video/backlight/tps65217_bl.c > @@ -239,8 +239,7 @@ tps65217_bl_parse_dt(struct platform_device *pdev) > } > > if (!of_property_read_u32(node, "default-brightness", &val)) { > - if (val < 0 || > - val > 100) { > + if (val > 100) { > dev_err(&pdev->dev, > "invalid 'default-brightness' value in the device tree\n"); > err = ERR_PTR(-EINVAL); >