From: Mark Brown <broonie@kernel.org>
To: Vitaly Rodionov <vitalyr@opensource.cirrus.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
David Rhodes <david.rhodes@cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com, devicetree@vger.kernel.org,
Simon Trimmer <simont@opensource.cirrus.com>
Subject: Re: [PATCH v4 07/11] ASoC: cs530x: Add CODEC and DAC support
Date: Fri, 17 Oct 2025 17:41:35 +0100 [thread overview]
Message-ID: <a0944336-e6e0-4ab2-95c3-be446e20230f@sirena.org.uk> (raw)
In-Reply-To: <20251017161543.214235-8-vitalyr@opensource.cirrus.com>
[-- Attachment #1: Type: text/plain, Size: 1563 bytes --]
On Fri, Oct 17, 2025 at 05:15:34PM +0100, Vitaly Rodionov wrote:
> --- a/sound/soc/codecs/cs530x.c
> +++ b/sound/soc/codecs/cs530x.c
> @@ -45,6 +45,18 @@ static const struct reg_default cs530x_reg_defaults[] = {
> { CS530X_IN_VOL_CTRL3_1, 0x8000 },
> { CS530X_IN_VOL_CTRL4_0, 0x8000 },
> { CS530X_IN_VOL_CTRL4_1, 0x8000 },
> + { CS530X_OUT_ENABLES, 0 },
> + { CS530X_OUT_RAMP_SUM, 0x0022 },
> + { CS530X_OUT_FILTER, 0 },
> + { CS530X_OUT_INV, 0 },
> + { CS530X_OUT_VOL_CTRL1_0, 0x8000 },
> + { CS530X_OUT_VOL_CTRL1_1, 0x8000 },
> + { CS530X_OUT_VOL_CTRL2_0, 0x8000 },
> + { CS530X_OUT_VOL_CTRL2_1, 0x8000 },
> + { CS530X_OUT_VOL_CTRL3_0, 0x8000 },
> + { CS530X_OUT_VOL_CTRL3_1, 0x8000 },
> + { CS530X_OUT_VOL_CTRL4_0, 0x8000 },
> + { CS530X_OUT_VOL_CTRL4_1, 0x8000 },
Do these new registers apply to all parts or just some (I'm guessing
these might be different packaging/binnings of the same die in which
case this should be fine if a little messy, but just checking).
> /* Write IN_VU bit for the volume change to take effect */
> - regmap_write(regmap, CS530X_IN_VOL_CTRL5, CS530X_IN_VU);
> + regmap_write(regmap, CS530X_IN_VOL_CTRL5, CS530X_INOUT_VU);
The comment is now out of sync. I can't help but feel that this change
might be easier to read if the rename of everything to INOUT were a
separate patch.
> + cs530x->dac_pairs_count--;
> + if (!cs530x->dac_pairs_count) {
> + usleep_range(1000, 1100);
> + return regmap_write(regmap, CS530X_OUT_VOL_CTRL5,
> + CS530X_INOUT_VU);
> + }
Should dac_pairs_count be a supply widget?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-10-17 16:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 16:15 [PATCH v4 00/11] Add support for Cirrus Logic CS530x DAC and CODEC variants Vitaly Rodionov
2025-10-17 16:15 ` [PATCH v4 01/11] ASoC: cs530x: Correct log message with expected variable Vitaly Rodionov
2025-10-17 16:15 ` [PATCH v4 02/11] ASoC: cs530x: Update the copyright headers Vitaly Rodionov
2025-10-17 16:15 ` [PATCH v4 03/11] ASoC: cs530x: Sort #include directives and tidy up whitespaces Vitaly Rodionov
2025-10-17 16:15 ` [PATCH v4 04/11] ASoC: cs530x: Remove unused struct members and constants Vitaly Rodionov
2025-10-17 16:28 ` Mark Brown
2025-10-17 16:15 ` [PATCH v4 05/11] ASoC: cs530x: Correct constant naming Vitaly Rodionov
2025-10-17 16:15 ` [PATCH v4 06/11] ASoC: dt-bindings: sound: cirrus: cs530x: Add cs530x variants Vitaly Rodionov
2025-10-17 16:31 ` Mark Brown
2025-10-17 16:46 ` Vitaly Rodionov
2025-10-19 10:32 ` Krzysztof Kozlowski
2025-10-19 14:23 ` Vitaly Rodionov
2025-10-17 16:15 ` [PATCH v4 07/11] ASoC: cs530x: Add CODEC and DAC support Vitaly Rodionov
2025-10-17 16:41 ` Mark Brown [this message]
2025-10-17 16:15 ` [PATCH v4 08/11] ASoC: cs530x: Check the DEVID matches the devtype Vitaly Rodionov
2025-10-17 16:15 ` [PATCH v4 09/11] ASoC: cs530x: Correct MCLK reference frequency values Vitaly Rodionov
2025-10-17 16:44 ` Mark Brown
2025-10-17 16:57 ` Vitaly Rodionov
2025-10-17 16:15 ` [PATCH v4 10/11] ASoC: cs530x: Rename i2c related structures Vitaly Rodionov
2025-10-17 16:15 ` [PATCH v4 11/11] ASoC: cs530x: Add SPI bus support for cs530x parts Vitaly Rodionov
2025-10-17 16:46 ` Mark Brown
2025-10-21 12:11 ` (subset) [PATCH v4 00/11] Add support for Cirrus Logic CS530x DAC and CODEC variants Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0944336-e6e0-4ab2-95c3-be446e20230f@sirena.org.uk \
--to=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=david.rhodes@cirrus.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=robh@kernel.org \
--cc=simont@opensource.cirrus.com \
--cc=tiwai@suse.com \
--cc=vitalyr@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®