From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751960AbeBDO5D (ORCPT ); Sun, 4 Feb 2018 09:57:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:48994 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750888AbeBDO5A (ORCPT ); Sun, 4 Feb 2018 09:57:00 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC029217AB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=chao@kernel.org Subject: Re: [PATCH 1/2] f2fs: enable to gc page whose inode already atomic commit To: Yunlong Song , jaegeuk@kernel.org, yuchao0@huawei.com, yunlong.song@icloud.com Cc: miaoxie@huawei.com, bintian.wang@huawei.com, shengyong1@huawei.com, heyunlei@huawei.com, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <1517626068-49739-1-git-send-email-yunlong.song@huawei.com> From: Chao Yu Message-ID: Date: Sun, 4 Feb 2018 22:56:37 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1517626068-49739-1-git-send-email-yunlong.song@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/2/3 10:47, Yunlong Song wrote: > If inode has already started to atomic commit, then set_page_dirty will > not mix the gc pages with the inmem atomic pages, so the page can be > gced safely. Let's avoid Ccing fs mailing list if the patch didn't change vfs common codes. As you know, the problem here is mixed dnode block flushing w/o writebacking gced data block, result in making transaction unintegrated. So how about just using dio_rwsem[WRITE] during atomic committing to exclude GCing data block of atomic opened file? Thanks, > > Signed-off-by: Yunlong Song > --- > fs/f2fs/data.c | 5 ++--- > fs/f2fs/gc.c | 6 ++++-- > 2 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c > index 7435830..edafcb6 100644 > --- a/fs/f2fs/data.c > +++ b/fs/f2fs/data.c > @@ -1580,14 +1580,13 @@ bool should_update_outplace(struct inode *inode, struct f2fs_io_info *fio) > return true; > if (S_ISDIR(inode->i_mode)) > return true; > - if (f2fs_is_atomic_file(inode)) > - return true; > if (fio) { > if (is_cold_data(fio->page)) > return true; > if (IS_ATOMIC_WRITTEN_PAGE(fio->page)) > return true; > - } > + } else if (f2fs_is_atomic_file(inode)) > + return true; > return false; > } > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > index b9d93fd..84ab3ff 100644 > --- a/fs/f2fs/gc.c > +++ b/fs/f2fs/gc.c > @@ -622,7 +622,8 @@ static void move_data_block(struct inode *inode, block_t bidx, > if (!check_valid_map(F2FS_I_SB(inode), segno, off)) > goto out; > > - if (f2fs_is_atomic_file(inode)) > + if (f2fs_is_atomic_file(inode) && > + !f2fs_is_commit_atomic_write(inode)) > goto out; > > if (f2fs_is_pinned_file(inode)) { > @@ -729,7 +730,8 @@ static void move_data_page(struct inode *inode, block_t bidx, int gc_type, > if (!check_valid_map(F2FS_I_SB(inode), segno, off)) > goto out; > > - if (f2fs_is_atomic_file(inode)) > + if (f2fs_is_atomic_file(inode) && > + !f2fs_is_commit_atomic_write(inode)) > goto out; > if (f2fs_is_pinned_file(inode)) { > if (gc_type == FG_GC) >