From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S965148AbcJQLbq (ORCPT <rfc822;w@1wt.eu>);
        Mon, 17 Oct 2016 07:31:46 -0400
Received: from mout.web.de ([212.227.17.12]:54446 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S933289AbcJQLbj (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 17 Oct 2016 07:31:39 -0400
Subject: Re: ARM64-cpuinfo: Combine six calls for sequence output into one
 seq_printf() call in c_show()
To: Mark Rutland <mark.rutland@arm.com>
References: <83d98772-8872-1b75-a9a5-5f08b8462e18@users.sourceforge.net>
 <20161017105605.GB29095@leverpostej>
Cc: linux-arm-kernel@lists.infradead.org,
        "Suzuki K. Poulose" <suzuki.poulose@arm.com>,
        Will Deacon <will.deacon@arm.com>, kernel-janitors@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <a09542e6-9851-45ef-583d-338205217cfc@users.sourceforge.net>
Date: Mon, 17 Oct 2016 13:30:59 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <20161017105605.GB29095@leverpostej>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:nuIIXCD1eBQqT3rofwW/4SmNN2LoCSEfb94cAgkM6Q7rS3qPl7K
 GBWbtV2L2TSqUpZqPyc6cOvnerCczPHOZJewPQt05rOulMCnE8cYtUuScSOxT6RfWiMuoJd
 nk3Dl7eGLlVKBZxpQ/IqVdOXkUprPVhrj6Iu4MGkUMv94rBbLE+9tq0Fb1MeGMt92wyXBNS
 pEiq5yF5z/zqnbFJ5OZ/A==
X-UI-Out-Filterresults: notjunk:1;V01:K0:U+4ue189NZ8=:GrAHJgHhIYp8Ze3yMyXKdU
 hnJ8/V5Cl+rLnmwaXQuIgV0AkMEHP/Hg/5be47Cb3tdJSnDORysFi1eGahOpgHqQrZJwpe+FK
 mamnpN1Oa5GGdqARX3koHxkd1Z34IUvTIFsUgOCMOKafgiRFU/GeCrJWBWtrKU9LTC4xn9MOm
 ePRB1XEZFcnhZPm1Q7tD8Cw3GTvfunXeirrqqLaS8r1lZWeNO5mNDQrfwBurf9P1/TpTWjW4J
 WstRZjlAst2itTyjMcsSIhGXX7CJ0XG00u3ZesmhRr+3BKFBqn5+Fcmf9X+Yx7uozAbxlMjgL
 d6j5YrbfTMVE8kF56u9Z8jyd8i8NGlIJ4D356nMGGjJnWwr+FHePz3z2ORvbTXtOFI2HX3OwE
 eAxeodzOtZiG5OypZTe/744blsucpY7ipsKia0x04Pg9EkJekQLnIvq+nn89Hk5k+8SQO3Eca
 yb/AcKhjK4jQs8pPTnvPcMq5U5HwqrAOnpYqMf7tusAbx5oQRilT4bSLUqdG+DxAsM9w7Fj/i
 mcCbFh5ssXryaniMSqMiwrJJ9x80ZzRRxGkigAIjoGXkUJeZh0FrJHWDd+U8peODpDF1QP73b
 YgA01NOD/G+Rpo5v+80dEJlK1Us8fkmnVs+2P0YGruUyoIsxSSMXrsxKsRm3dR4QSWTBHE4cv
 4P5gzj9C6nAwdCkwzpRSranuL4Y4whIFeefBwe8DH9z0q7AlSDF9Zj+dcYAor4bvu6Qh/Mx4Z
 uHO3PIVpxoSqboTMMtuOWrsKTDHNN3pGRIpVb4kwDIfvzdGdXHn8GS8nzEIhKUrkDMeq1rr6F
 OSSdlKK
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> Some data were printed into a sequence by six separate function calls.
>> Print the same data by a single function call instead.
> 
> ... why?
> 
> Beyond simply having fewer function calls, is there an upside?

Will it matter to improve run time characteristics at this source code place?


> This makes it harder to see the relationship between the format strings
> and their associated data, and makes the code longer.

Do you prefer an other layout for the passed data so that the increase
of line count in my update suggestion would look differently?

Regards,
Markus