From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 704A33246F0 for ; Tue, 25 Nov 2025 14:06:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.11 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764079563; cv=fail; b=UE95v5Y0IGLXVoDOUjRzgeGjvX1tsVo7yv3EpRadFTRxgdHx40XdQx7bSt78ThtPaw1o3AmZkP64qmvvTEqI7gjUTDWO0lvlvQrt7sgG7TPbeUtzRml3LrTzB1poAIDp48PhSAaa+6wA35vIDvc0cQU8CashhdlHm+WhqKoTank= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764079563; c=relaxed/simple; bh=+hElAZ1GQsiDFJIcFn1qzNQhR77Biwy6VWqB8FOuXe8=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=katYVvhQk97u/l+vHqfLGi47iOVjfm5A+hgpNVeMa8E7OZ/lFOeX7RY2vhLd8P2K6PDZb5NEpFj1cHbjOvHUOh58OUI73Wl2HPjxKXbkXUAy4mc6Xtf4GP4OV2BZaDQ7qv5wAq9PY6TXNZrUqhvbvdt66MfkfWju3+y9gGo+2lE= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=kjuvVsT4; arc=fail smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="kjuvVsT4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1764079562; x=1795615562; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=+hElAZ1GQsiDFJIcFn1qzNQhR77Biwy6VWqB8FOuXe8=; b=kjuvVsT4oGokfItfeKdrugjUkrylXIQAKoL2Mkiq2c0gEc2P99gL+66R b8hRth6mvnISUrE6SvOytO//gKviiAVJ1BXet6goJv6KbXcieOa3uUzum RsrjodvJf1iqcGPRdv9f8uDNCz9duwyjBGxCpKNlwi8xhq7HxuDuf4BFD Us88tGqyS77CN3fSIdL3d6lCwZtn6srqlenc/598qwlAp4XDwONjccQ2I cV07yeuGkQxQHpRM9VqOqJ1zCQVYTJNxRd8B6xbPooxukfOPgat3nVC0D g2B1Sd70MzH6PKGA4u1jxAQ8A0ZP2xd0uUSEYCbgevnRmtLdlOsuUJFB6 A==; X-CSE-ConnectionGUID: dLVpQ0MPRZaTKgrQTUwSbw== X-CSE-MsgGUID: P1GqLdl3Riyvn0whmu66wA== X-IronPort-AV: E=McAfee;i="6800,10657,11624"; a="76722373" X-IronPort-AV: E=Sophos;i="6.20,225,1758610800"; d="scan'208";a="76722373" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Nov 2025 06:06:02 -0800 X-CSE-ConnectionGUID: eJtLaqqqSF2CEqEwdIaQlg== X-CSE-MsgGUID: cD7YWUUCQhuBLslzo6IRrA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,225,1758610800"; d="scan'208";a="191899564" Received: from orsmsx902.amr.corp.intel.com ([10.22.229.24]) by orviesa010.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Nov 2025 06:06:01 -0800 Received: from ORSMSX903.amr.corp.intel.com (10.22.229.25) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Tue, 25 Nov 2025 06:06:01 -0800 Received: from ORSEDG902.ED.cps.intel.com (10.7.248.12) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29 via Frontend Transport; Tue, 25 Nov 2025 06:06:01 -0800 Received: from DM1PR04CU001.outbound.protection.outlook.com (52.101.61.7) by edgegateway.intel.com (134.134.137.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Tue, 25 Nov 2025 06:06:00 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=njbqkUtxXoypyCmQUOEwB42DIq3/sb7+R2PEWS/EocXrWo3DNc/QAIUy7KV4Q+kBQ13N/RXNmOKCY1/OKk2D5anw1RO+/S0PfiRNbSmpOb5XifTRMgCBYu2UJEBN8WUvhfJwc61Wp41Tn2xF9uR0jMn5QRTPGiHD4gonpUoNYJ8KnLic1GfQnQu5XU3XOgGCQgL1ArFYCL4UqRLwNxL7P4JD8yWHvM6gxW8jzFW7XVRX/knqI+PC8AwPhSxvUPV7DDYKt0VzrpITTOuFINj3ddmJIbU+fx7wTl7GCUWpl4AmvbGzQySGKb9f5+IeGrSbyua6r85OpMP3sSWXpPYKVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zAF5ryiT6MnNhPEknqvKn6hrfvl5aTfF+9wwKzYQqYU=; b=fNf7B7owhoEjouc91UBuBbhaClnQvTeBpMtpHFUFcdhNc0PfSGe7ANttsqdLg5UfbY9WYETRKmZPSO3ESLxKfzxEmjhowulukS0aoFvhmNtt9Pf3OWC3kyHMgvK/CShnj33lPbPQ6mx418tyMvKRA5q4QF5FFoeMI5tkkH2SO1jRb5JR8Y4og5hySi/iDde81/b3jXiQhn3ofbMmW0evzpS0f+GH+dr+Ok6k+KPwOeh2gqKIWvjKr2utgVSnOvgDQWbfCU3F8seeUZDUHdUigOElczMp4OvsK7J/Epi2Pr1lNTo9LTH3hNuhhrW7viiHcuCUae1P4K89dZ1QwXf/tw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from IA1PR11MB7198.namprd11.prod.outlook.com (2603:10b6:208:419::15) by SJ0PR11MB4975.namprd11.prod.outlook.com (2603:10b6:a03:2d0::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.11; Tue, 25 Nov 2025 14:05:59 +0000 Received: from IA1PR11MB7198.namprd11.prod.outlook.com ([fe80::2c4e:e92a:4fa:a456]) by IA1PR11MB7198.namprd11.prod.outlook.com ([fe80::2c4e:e92a:4fa:a456%4]) with mapi id 15.20.9366.009; Tue, 25 Nov 2025 14:05:58 +0000 Message-ID: Date: Tue, 25 Nov 2025 16:05:53 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] i3c: dw: Add sysfs support for Device NACK Retry count To: "Ng, Adrian Ho Yin" , Frank Li CC: , , References: Content-Language: en-US From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo, Business Identity Code: 0357606 - 4, Domiciled in Helsinki In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DUZPR01CA0314.eurprd01.prod.exchangelabs.com (2603:10a6:10:4ba::21) To IA1PR11MB7198.namprd11.prod.outlook.com (2603:10b6:208:419::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR11MB7198:EE_|SJ0PR11MB4975:EE_ X-MS-Office365-Filtering-Correlation-Id: 47606bde-d6fd-4a7b-d165-08de2c2bc207 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?TXd1MTZ1VE16eERTR0NubnBJNUc1YkhwdVZwWkJ2NDJTNFIrVWwwdUtYV0VS?= =?utf-8?B?VUh1cVk2em5GcmFVL2plUUhySDU4L3RDSGRicDhQYVRUZTY4MldKUWQvVk1w?= =?utf-8?B?SWZ6OTIxVjAxV29VVDVKa0trVjJLVFU3NjZteUE0enJKQzJZOHhkeHFnVWww?= =?utf-8?B?dCtVenBTOFZWeVdMRWF1MFRSeklMOHB0WWlRRXM5SmtDek5Zekw5SnhDZkdv?= =?utf-8?B?VUNJQkdzKzNiWVBmNFpJZVgzVjZ4TlNIaUFEc1F3cWx6aldnM25RK2RSdmNU?= =?utf-8?B?QTFPU2xNUFEvUVBGYTNsTEtvR3hRMGZDdzBpMmg3ZG4yRFZkeG1sNHFnZkR5?= =?utf-8?B?SGRIRGlaMHJ2YUYyUXBYdklyRmlldFlJQm94MUNvRWdWbXZZbzZiNU02SWs2?= =?utf-8?B?VGNvOVE0OG40UDFxR0lJalI2WnhIem83Y0pjOXFQT0FnVDEzL1praVFla0FG?= =?utf-8?B?Wm5aRXFtaGFtSm9WOTBZZVZqZy9ZRXZvTktCSEF3TEJXcElqZUYyNzVlM3dM?= =?utf-8?B?UGVkTXdOUllPdHpxOUU1R3pwVENzN0JHQ3dJaktnV0poSXdlcFBMUVZwYkVw?= =?utf-8?B?a3IwRjdvUlV2ejErVmFtbmpIR25iVkQzUkxJZ2dVaHhibitPL0V5dy9EcFpi?= =?utf-8?B?R2I2NG81OFdET051VjF6ak5qYWtocVFYcEpKQ1VqVk1jeDRuYlF5SnlMNXRt?= =?utf-8?B?b0NtY052am9xc0QvTGhMTU1KbGIzbjY5aUIyL2EvUHJLN2hmZDRCajNPdFI0?= =?utf-8?B?VXBiTmFMNm1tckdhUW5va0k2WnJXN3F2a3NQc2xkc3pZdWFSUlQ1cTJsNm54?= =?utf-8?B?SFE0U0JvVjhNRU9QZzAydmg2NXBmVHE3Zk92QU1CbkFiS2hoRllRTmd0QVIy?= =?utf-8?B?M0JpNjZWNGo5L05GcnVtUy9WNytBdGhqb0lJT1Y0Nno3TUIwUnhFSlFpc0hH?= =?utf-8?B?dGtVRnhRY1pJYmE5Ym1uY1hCRDJ5d2NrU2JlOXluemZGYk43OWRzRTBZeFo4?= =?utf-8?B?bXVnc3ZNQ0NEeFFnQ0c3dUNTSmZFblQxby9Ra3ZSTVB3MGlFbXZDNVJRK3JZ?= =?utf-8?B?bHhOQkFtbVZSazFNSm1BazlFMWwyYjBIaEFpVGlHR3BCMFREQkRnV2QvaTFK?= =?utf-8?B?dE9jSFQ0ckpJOWV5c0dWY3IrZ3pVMXh6Y2pGSmZqYUt4ZWt5VGJISEx4cEQr?= =?utf-8?B?QUI4YzFxWGNwenpmRWNteUV0RHpTc1UrbkhSM0NSTVlhQ3Q5VzJBR1k0NVB6?= =?utf-8?B?RGhFcnJrMkZMQVEvMTBMZDdocjEwdFJQWVJNK21ndmp5Njh1QVFNbjJ2U0cr?= =?utf-8?B?blJ4a25ycHBoRWNuNmg5UWhmNGdnZ1lveEdiOTZXNzBZVVhHQ3Rlb2loWElU?= =?utf-8?B?S0U4R1FSbUpoczFYV0dkT3htcEpDKytPSXJ1dXFZbHhDSkpLQUQwYWlRNHZQ?= =?utf-8?B?VUsxWXlxY0NHUXJ0UUJVT3QyUEltWS9VTjM4WWV6cXhHM1hUZmhkTG1INXUz?= =?utf-8?B?UUV1L3NWVnJ0MEk5bVRCUzhNTDJ2eHg0WjBtaXVuS2FQUzUwTHJDQy8zVWl3?= =?utf-8?B?L3BDQVFSNDdtclk1UEMvWmREQVFpZDR2ajVNOXFWV3dNSlBZanExeFZrdWdD?= =?utf-8?B?b3ZTK0NKNUNYbUNkdUhDUTArVWxtSkU0emk5UTJESVQzY1B4RzJuWG9wWTAr?= =?utf-8?B?VEt6OEJEbGtzOWZLbVVCZ0hlRnR4YnlFVkZUWHA1MmlieVhaM0YwS2pUeCtD?= =?utf-8?B?N1hvdU1NT1dyMm9kOVlhbVN1ZERobGFYald3K3pIQlNMK21KMGdSVWNkK3lK?= =?utf-8?B?QnZkOWtjTEdwcmtWOUV6YWY1emljYmJLcFp1UmtESk1jMzVpNzVHS3B6bkpu?= =?utf-8?B?dytmY2svQ25ybzRhQWdaMGhOWjhWdGRPYVVBb2U0cSt2Qm5GaTczWWdVOVpJ?= =?utf-8?Q?LH77L+lhhDqjZ+frvkt2ADYcfTYEbFBU?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR11MB7198.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VjVNODdxVXZ2TnpJNU5LVURJTHlwUm1FTG1BSHFaSXQyVFFSUzZwVk4rMGZ2?= =?utf-8?B?ekZ2SDJyZmxTWHpVbjBIWVR6M3NGdUQ5RG9nYXFzbjFyc3REeTlGelpRWHBE?= =?utf-8?B?VUw3YUtaY1Z0bno0WHduOGZMSFkxdWpicm53d0c3MFJMek40NmVnWnk3emln?= =?utf-8?B?L0MvcTNSSFZsZVRUU3BTSiswV2RrMFY4UjFFeEtEWkFiSWNJY2QzMExSMDM3?= =?utf-8?B?VnJER1paRWw1bnZXbEVDVnhxSms5dXVaTmpzZGxMUVpHWjlXSmh0aEo2akVL?= =?utf-8?B?cGlVenk2RWd2UzdqZFVXaE9naDBWQjZmWm1SNUIzK3RGa1dpVjJQMHBDZ1RR?= =?utf-8?B?QzBwaENQb0FsWnplU2tlYks4aVh2ejN5U1d4NUFZUTNMVUM4YjBtem1lSGd0?= =?utf-8?B?MThZR1hSUkp6U0E4dHhISHNneFhETnZTOWRKYTg1THFSMys4VExZNmhqdzh3?= =?utf-8?B?Ump0OUJnbWlyQTdlWDBSQXFNdGFDd3BNWllUdGVaMUZ2bDdZV1hTNjNzZytm?= =?utf-8?B?OFVPSTJGRDBXbFdHdGI3Z1pTK0syZllGT0RXQWg1M1RITDJWTmRjaDNaY3cx?= =?utf-8?B?QmdvaUhERk5ENWttOVRoYVQ2U2NnMno3bmVnSDRwRUdldGhCNVpIL3QrWmxt?= =?utf-8?B?aDlEQzFLOW9uczMybkJOaU53UkJVeENwdFRiSG81U3dkeVlsSC9tS0dtWS9Q?= =?utf-8?B?WnNNbTJHelloMEwwY3NHbEhOMGxlcjQwQlRKU0R3QlBYRURXcmZkNE1Uc2pD?= =?utf-8?B?WnJNWTV4ck93eW1OaXcvbEZTaWUydlBWVXkxQmJkSWtESHk3d2JQSkEveENJ?= =?utf-8?B?TEFZSVZCdmVwY2ZOM2tlR2xvaStZdkFsaVVLcndFenJpTHRlL3BKaWpVSUtQ?= =?utf-8?B?MHNDZCtNemwwZ3djSzJuc0R3K3pzME9NdTVueHZpMnFDeDJOS2s5LzFuNjF1?= =?utf-8?B?NnZYWWhRLzJxYktlajFHQXlXZGRkdTVRWkUvc1ZjQ1dBaHg2TkdXYWpKVlB0?= =?utf-8?B?ZDdVWFVVK3ZpbzYxRU9iZG5wbUF0ci9qd3VJRkZXV3BhK0NlMS96WHpna3Ey?= =?utf-8?B?aEMxdFJwN0RETmZvelErMU11eTRrMVhkQ041d3FVR0w5ZXVhOFl2VHpGNWJr?= =?utf-8?B?QnhEQUV2SGt5TTVZSTg4cUxZODVCNURtWi9DZUlJQUIzQlFLWTlXV0F4eEQ1?= =?utf-8?B?MUtsakFpTFZvcU9QS1VoQ1FzQUxjT09hOGRaNGFhSko0ZFI2NnZRMDRXWVc5?= =?utf-8?B?QnVpVCs3L3lJZ3N0emhnTDM5UkJLWDVrdHZEakRwZ3pWOUJrSEZsdndSclFU?= =?utf-8?B?cHFwRWtLY3JYTDV0bUwzS0FLSG9iSGNYRFRpczVBTTdPWCs0bWcrSkZtbStO?= =?utf-8?B?a1ZRTXZKTXdsY1pHV2xjeTE4aGh1elg4c2FRZ0RpcG5tYUJkUm54SW1UMTF4?= =?utf-8?B?QUFxVUVCOW9sMFlxMWdZWHNsZ25ib094Z2l5Tkw1UVZxS2ZyUzZCU3NJUTNY?= =?utf-8?B?aDlUZ1JJcDlxMEdNQ2F4bGR1MzREamg0TnpISEFRK1IveTk4SGFkRHNGcXBH?= =?utf-8?B?YmhLTFNWc3VYK0NlVXBGWjNPR3VFcVhJcDNubmJKZ29zN1BUb1VmOU5vV1Ew?= =?utf-8?B?V3JrV240eGJBUE5CUFI0Zlovd2JaWlFRUDNIb3dsbXg5dEtackpSY2xld3B0?= =?utf-8?B?MmVMbktqY0ladHoxZ1NMeEMveWhrR0piSFpWeVY3K2Z6ZWJ3QWhDRitIWEJv?= =?utf-8?B?Qm1hQm1hYkQxbXBiRi9jYmlyQmlOdVgrWmdZempyUjNNYmFYWElCK3g0eTNt?= =?utf-8?B?YldlWnRNdmN6aDlSZ3I3UUlTWDNsYzd0WVVvWDdXUmF3SzdMYmsweTFVTS8w?= =?utf-8?B?S3BCb1RkZ1VXc1AyQW5iSXdaVHlmLytjUzFUOTA3aFJzM3lpZHpwVnlldmJk?= =?utf-8?B?Y09BNFBYeHJNNTBFeU5WSDMrRWZldmVGS3FOMTcxSTdQd0VLeG12bDFRaVRO?= =?utf-8?B?TURXVU9Cc2UyVlMzUTJzYTFnZ3JkdWFMb28wd3Z4Nk5sL2ZGd0U5Nk50LzNQ?= =?utf-8?B?RkZDTGFsd3psVmZxVk9IWjNuTDFzNGwyOGZ0dWNhbzY3QVREamlFUnoyZ1Jj?= =?utf-8?B?OEIxbWpBb05PbURmUUY2SDVzTUJKYTJFT1hVSzFad2tkL3dDd0RPRGVjYTEr?= =?utf-8?B?emc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 47606bde-d6fd-4a7b-d165-08de2c2bc207 X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB7198.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2025 14:05:58.8931 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8r/xSoLJs7v3q4WIj8FPTD2RnhYjhDO5TMsGKLAbAB7AW3uUoyh3PAc8C9INcNp1nqsF3IZzsbmwRJAWXO2vzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4975 X-OriginatorOrg: intel.com On 25/11/2025 05:19, Ng, Adrian Ho Yin wrote: > On 11/25/2025 1:59 AM, Frank Li wrote: > >>> + >>> +    master->dev_nack_retry_cnt = val; >>> + >>> +    spin_lock_irqsave(&master->devs_lock, flags); >> >> I think you'd better to hold i3c_bus_maintenance_lock() lock to make >> sure not transfer on going. >> >> Frank > Hi Frank > > i3c_bus_maintenance_lock is a static function in master.c. So should i update it and expose a public helper to take the maintenance lock or continue using the existing spin lock to protect the DAT updates? > > Thank You > Adrian Other controllers (e.g. MIPI I3C) support dev_nack_retry_cnt. Seems to me this should be in master.c anyway, so it can be shared.