From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D80E2361DA7 for ; Wed, 4 Mar 2026 09:34:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772616852; cv=none; b=ZjNgd8bZ/JsO4NsHAm2SlSI2Qz/hdK3uoJrSHrc3lx5ANJvmX3nVg3g4+vEM6NeRsoJClQt+GV6oRBZ94EQlw609+xyBFPgZTOiUI2089yoDDHuJJMScBOa+vZ0/FNaIt6kpDPy4MbiXQ7YOScDO6bB1ik5vnJ3rBNNK8T34WTI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772616852; c=relaxed/simple; bh=6Im1afP1sgkC4nogaoxmhp/Qx7QYuTEir2dfH5M9TBI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AgkAPuxDaHHmyrMe2g0fXmVP+Gv5KhVDuNnoSjvxrsAtKTm8RlG8nig+yPIOmLyfMBRlEqNHyBies6k8Ldfa0+WJBvQR27DewXxN4cAPOpGradFJJ3up9LEzD1C0P7o4F+b9Y/4yoWwXdgOjt7qhH2MeXOIyboAyMaBYqkjuPgs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=n6pGDaZO; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UqUM+jou; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="n6pGDaZO"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UqUM+jou" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6249KYju1455810 for ; Wed, 4 Mar 2026 09:34:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UwA8zZfKe+4R4i3Dro//bDZHxe7EZ0deZWYOSGGABX4=; b=n6pGDaZONI6sPN0M LyohQzLltHQCj2BUIXV/aLaKnkuEAZUtbc0Go9+5Y5rpgquXed1zmukahBzn8Ri6 DBGxVGFaKP7wsFd/JRqjg7J5IxEaZZePG1u6c6Xlmaw1hKiSCifmrCwlCFQP89J7 BZiMmGs4pz6kXRrmb1z/a8k2e7yNKQpkvlV6hrunZdakrGIBmqUz+Ea/03XF3W6t KjOf3Rwo/GMr65yPoE41078/1ukwOanl2MuQ8D0VQuiVIPsdY2UoKR7boCvkn3zT lzLWk/HAiOx3T479zTCyYgBCJZCVngIbCQ8Q81jcLGAdGEHHUBRPfYx9+CZuTmpO Z7xESg== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cpj1801qn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 04 Mar 2026 09:34:09 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-899ebdd0b08so23484846d6.3 for ; Wed, 04 Mar 2026 01:34:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772616849; x=1773221649; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UwA8zZfKe+4R4i3Dro//bDZHxe7EZ0deZWYOSGGABX4=; b=UqUM+jouYA89m4xUExsVDDjJhlSqCvydW//kREn2CCfo4Vnificb53oQ98uv83U2X9 iCwlwSb8GH1EaWShCLDILMKFaRdgGW/yvSh6bu9ESPGfqNHpxF8ONG8ynY/RUj/J14fS 51T6VZKRj/4hZ1TFPr6bfhU3gZoxvaXXF8trsLuC/hN/eAziBIT2HbQ9QkBRkWklFrbe bsnBK3EdJWI/Efyb36TxdEjOh27Ip6Dfh4wodBh36aAMYJ0m8/ZkPlSGkNHI67jzwzs7 O4GgW8VN/7AtGyOdNwv1zkBfsMHfXxchwtfbUQ4DgxAituVl5QEOTHXll0rYZMlofZh6 gPCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772616849; x=1773221649; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UwA8zZfKe+4R4i3Dro//bDZHxe7EZ0deZWYOSGGABX4=; b=gXuIDxZ2Y1LIg/byQxuRUEIiKJU2CZ8IX8vmtBHgdXTKMy3d//C1Ofm5y/0Yh48p0P qxk3u/0TOeOuT1a5GZVETHMfJfNZ4VR8Lul9II1hX333msek/p43x+3z2eMCNSEgulEu Tyw2BYEvP/mdpTRRwA7mPY4OqzoeklCSlpoqGHkzdRKOm6uGwvd4uRmyCbY+OjX2gdWm lfikdg1qZLcKuzYQTxa9uLzOBZ1SZlAnKrS/+9mJ7NYxlHimRwejXM+2WR9vLCQiksaV XnxKmmEkkPYxaUn4y3cG0Px3n3JYreGz0uY+GRZpOyTjKEacvH5KIMaWa9N8KmiWkOf8 ZL4g== X-Forwarded-Encrypted: i=1; AJvYcCWyc9xFZ1Z+Vp+UDRlfGDfy6kdCbsaNO8sSKLC+Yf5pikC67JpbziDh5NTCkuG9nobidYyzfWjuTDAr9kE=@vger.kernel.org X-Gm-Message-State: AOJu0Yyi/F588ZmMWz40NSaFv5tSWR/xZkr2MofkcfojVxBMZJzVc32p mmNo/I3nqNbAv3p7YoF7J4+Th5P49Deh3uQUm+CC8eiRTMlCEEXELdXumpA2m4+PXQ1kTng8GOG aTrt//y83SmY4eGLAlouftWmaJgmD3jUNVBFurcpfgoq0XN3x/y7hn8ZVISgi6uJT7E4= X-Gm-Gg: ATEYQzz7gFPYwBoEkvci3Zj1df5rWSovCOwFAH+/Y8v0pMoD2+dDFzXXSwzj/x2vDfQ ZwqIGOpeR0s8Ea4/Vtdzh95/QH61VsS8LA0+hquh1VzaCXK4XGzcb491o3b5uI1T3WFKBBwkkkK aqlls1xKHdszPyswJRFVuai8HgCxB7WcTQoXNtJNJOUlplc0uNU0GHm1qB22OZbxj/VkR7QUCGd t1VRa6owfS3WmO44HT3EldejUZdZCnXk1aq6Uuqh+4VfNbK9YokQyF7wmo91Y7PXr4V/f5SV3Hk yb4V9rrKBJli3DUrbt424NZ/EkqDtovc8nfTWuAgZt7EpfeZwP6vI3AVP8p6Bwqykg+ImSGS/tw 90thTIUXTTVTnsnojiGOHQbD2MYmb3BhxNaytG/KHDevOYxalWACcWzOBQ9FIsYo4Mx5cjmHTnT FAyQ4= X-Received: by 2002:a05:620a:c55:b0:8c7:f61:eff8 with SMTP id af79cd13be357-8cd5afe710amr118337285a.10.1772616849048; Wed, 04 Mar 2026 01:34:09 -0800 (PST) X-Received: by 2002:a05:620a:c55:b0:8c7:f61:eff8 with SMTP id af79cd13be357-8cd5afe710amr118335985a.10.1772616848636; Wed, 04 Mar 2026 01:34:08 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-65fabd46753sm5281095a12.8.2026.03.04.01.34.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Mar 2026 01:34:07 -0800 (PST) Message-ID: Date: Wed, 4 Mar 2026 10:34:04 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] media: iris: add FPS calculation and VPP FW overhead in frequency formula To: Vishnu Reddy , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260304-update_fps_calculation-v1-1-4eeac373a504@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260304-update_fps_calculation-v1-1-4eeac373a504@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: HfqeTDKxdG0x-MUbubomR8ALODSGbdZo X-Proofpoint-ORIG-GUID: HfqeTDKxdG0x-MUbubomR8ALODSGbdZo X-Authority-Analysis: v=2.4 cv=Ed7FgfmC c=1 sm=1 tr=0 ts=69a7fc91 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=kFDTxuPyl3r0weC5jlwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA0MDA3MiBTYWx0ZWRfX7KvAiAjRdTcp BT9JKqyVesNGFXjQler9BtlSpJhWtDyVq5YvQeQmCBB1Jpe/c0gGxSXT8ApoEY91eXEF4NBGzwT cQq5a5+EVaGuFG50MHiJyXbKJ6reJTn/cYhrC9zSUSaTanaw0VuIScgO0LSDxruGBcypSldXADr bYzk+kLggj6Ldk9XkOcX4Kd7oktfBuNVR7oovgmt7P6geLmcc8YMUlzFZN7eznpaQd8xDGXz0wC zUh7/3N7f+4wQ8lVBbHUOXiwQ462zdZtLpeVSyANX5+zo/HWSJNCnju9m/kViPGnozPOVr4IXCv 09Om1byWgFmT7REWwGqTX+y+BXf64NLhSslcbe6ahrHAglM3/uYbYga4i1v7oOO7X8kkE8xz1c2 jBPlZEqKbxsGn6VtBH2FFqVlTU31xaAgJ/HM/zDFobaljIWyOOkh93yGMuTxCKM+OpBqEK/7/Yb B1brtkJPaWF0GX5msRA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-04_05,2026-03-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 impostorscore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603040072 On 3/4/26 10:18 AM, Vishnu Reddy wrote: > The driver was using a fixed default FPS value when calculating the VPU > frequency. This caused wrong frequency requests for high‑frame‑rate > streams, for example 4K at 240 FPS. Because of this, the hardware was > running at a lower frequency than needed. > > Add the FPS measurement based on the decoder input buffer arrival rate. > The measured FPS is stored per instance and used in frequency calculation > instead of the fixed default FPS. The value is clamped so that it does > not exceed platform limits. Add a VPP firmware overhead when running in > STAGE_2. > > Signed-off-by: Vishnu Reddy > --- [...] > + /* 1.050 is VPP FW overhead */ > + if (inst->fw_caps[STAGE].value == STAGE_2) > + vpp_cycles += div_u64(vpp_cycles * 50, 1000); let's use mult_frac() and trim the trailing zero Konrad