From: Dan Carpenter <dan.carpenter@linaro.org>
To: Soumya Negi <soumya.negi97@gmail.com>
Cc: Jonathan Kim <jonathankim@gctsemi.com>,
Dean ahn <deanahn@gctsemi.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
outreachy@lists.linux.dev, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] tty: gdm724x: Match alignment with open parenthesis
Date: Fri, 13 Oct 2023 11:57:40 +0300 [thread overview]
Message-ID: <a0a7274f-eba6-4f72-9569-ec4c4fff3a1a@kadam.mountain> (raw)
In-Reply-To: <ff627fcbc9e450c2e8f4aa5810b94e56151efa2a.1697184167.git.soumya.negi97@gmail.com>
On Fri, Oct 13, 2023 at 01:26:34AM -0700, Soumya Negi wrote:
> Fix CHECK: Alignment should match open parenthesis
> Issue found by checkpatch.pl
>
> Signed-off-by: Soumya Negi <soumya.negi97@gmail.com>
> ---
> drivers/staging/gdm724x/gdm_tty.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> index 32b2e817ff04..4e5cac76db58 100644
> --- a/drivers/staging/gdm724x/gdm_tty.c
> +++ b/drivers/staging/gdm724x/gdm_tty.c
> @@ -271,8 +271,8 @@ int register_lte_tty_driver(void)
> int ret;
>
> for (i = 0; i < TTY_MAX_COUNT; i++) {
> - tty_driver = tty_alloc_driver(GDM_TTY_MINOR,
> - TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV);
> + tty_driver = tty_alloc_driver(GDM_TTY_MINOR, TTY_DRIVER_REAL_RAW |
> + TTY_DRIVER_DYNAMIC_DEV);
I prefered the original code. It was more readable.
regards,
dan carpenter
next prev parent reply other threads:[~2023-10-13 8:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 8:26 [PATCH 0/2] tty: gdm724x: Fix coding style in gdm_tty.c Soumya Negi
2023-10-13 8:26 ` [PATCH 1/2] tty: gdm724x: Match alignment with open parenthesis Soumya Negi
2023-10-13 8:57 ` Dan Carpenter [this message]
2023-10-13 21:13 ` Soumya Negi
2023-10-14 7:38 ` Dan Carpenter
2023-10-20 2:14 ` Soumya Negi
2023-10-13 8:26 ` [PATCH 2/2] tty: gdm724x: Add blank line after declaration Soumya Negi
2023-10-15 5:37 ` Greg Kroah-Hartman
2023-10-15 6:07 ` Soumya Negi
2023-10-15 12:50 ` Greg Kroah-Hartman
2023-10-15 19:19 ` Soumya Negi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0a7274f-eba6-4f72-9569-ec4c4fff3a1a@kadam.mountain \
--to=dan.carpenter@linaro.org \
--cc=deanahn@gctsemi.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathankim@gctsemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=soumya.negi97@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®